refactor(Base): Move GetRootManager to FairModule

... and simplify by using the already existing `fRunSim`.

Author: ChristianTackeGSI

fairroot/base/sim/FairDetector.h

@@ -105,25 +105,7 @@ class FairDetector : public FairModule
     void SaveGeoParams();
     Int_t GetDetId() { return fDetId; }
 
-    /**
-     * \brief For internal use: Set the manager
-     *
-     * \note Usually called from FairMCApplication::RegisterOutput()
-     */
-    void SetRootManager(FairRootManager* rm) { fRootManager = rm; }
-
   protected:
-    /**
-     * \brief Get the FairRootManager for this Detector
-     *
-     * \note Only valid during \ref Initialize() and Register()
-     */
-    FairRootManager& GetRootManager()
-    {
-        assert(fRootManager);
-        return *fRootManager;
-    }
-
     /** Copy constructor */
     FairDetector(const FairDetector&);
     /** Assignment operator */
@@ -134,8 +116,6 @@ class FairDetector : public FairModule
     Int_t fDetId;   // Detector Id has to be set from ctr.
 
   private:
-    FairRootManager* fRootManager{nullptr};   //!
-
     ClassDefOverride(FairDetector, 1);
 };
 #endif   // FAIRDETECTOR_H

fairroot/base/sim/FairMCApplication.cxx

@@ -177,6 +177,7 @@ FairMCApplication::FairMCApplication(const FairMCApplication& rhs, std::unique_p
         auto& clone = fOwnedModules.emplace_back(module->CloneModule());
         fListModules.emplace_back(clone.get());
         fModules->Add(clone.get());
+        clone->SetRunSim(fRun);
     }
 
     // Create and fill a list of active detectors
@@ -943,7 +944,6 @@ void FairMCApplication::RegisterOutput()
         }
         if (detector) {
             // check whether detector is active
-            detector->SetRootManager(fRootManager);
             if (detector->IsActive()) {
                 detector->Initialize();
                 detector->Register();

fairroot/base/sim/FairModule.cxx

@@ -159,6 +159,12 @@ void FairModule::Streamer(TBuffer& b)
     }
 }
 
+FairRootManager& FairModule::GetRootManager()
+{
+    assert(fRunSim);
+    return fRunSim->GetRootManager();
+}
+
 FairGeoLoader& FairModule::GetGeometryLoader()
 {
     assert(fRunSim);

fairroot/base/sim/FairModule.h

@@ -188,6 +188,13 @@ class FairModule : public TNamed
     Bool_t fGeoSaved{kFALSE};   //! flag for initialisation
     TVirtualMC* fMC{nullptr};   //! cahed pointer to MC (available only after initialization)
 
+    /**
+     * \brief Get the FairRootManager for this Module
+     *
+     * \note Only valid after being added to a FairRunSim
+     */
+    FairRootManager& GetRootManager();
+
     /**
      * \brief Get Geometry Loader
      * \note Only valid during ConstructGeometry