Skip to content

Commit ea5fc29

Browse files
committed
Remove extraneous comment and preliminary ChangeLog
1 parent 612912a commit ea5fc29

2 files changed

Lines changed: 71 additions & 10 deletions

File tree

doc/ChangeLog

Lines changed: 71 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,83 @@
11

2-
Tag name: cam6_4_0XX
3-
Originator(s): PeterHjortLauritzen, mbramberger
4-
Date:
2+
3+
===============================================================
4+
5+
Tag name: cam6_4_078
6+
Originator(s): PeterHjortLauritzen, mbramberger, cacraig
7+
Date: March 19, 2025
58
One-line Summary: Improvements to moving mountains parameterization
6-
Github PR URL:
9+
Github PR URL: https://github.com/ESCOMP/CAM/pull/1281
710

811
Purpose of changes (include the issue number and title text for each relevant GitHub issue):
12+
- Updates to moving mountains scheme for tuning QBO in MT (same settings adopted for LT: https://github.com/ESCOMP/CAM/issues/1276
13+
- Turn off moving mountains for dycores not passing vorticity to physics: https://github.com/ESCOMP/CAM/issues/1270
14+
15+
Describe any changes made to build system: N/A
16+
17+
Describe any changes made to the namelist:
18+
- use_gw_movmtn_pbl is set to false if it is not CAM7 and SE dycore
19+
- change values for gw_qbo_hdepth_scaling and effgw_beres_dp for specific configurations
20+
21+
List any changes to the defaults for the boundary datasets: N/A
22+
23+
Describe any substantial timing or memory changes: N/A
24+
25+
Code reviewed by: cacraig
26+
27+
List all files eliminated:
28+
29+
List all files added and what they do:
30+
31+
List all existing files that have been modified, and describe the changes:
32+
M bld/build-namelist
33+
M bld/namelist_files/namelist_defaults_cam.xml
34+
- update namelist settings
35+
36+
M src/physics/cam/gw_convect.F90
37+
- Limit value for hdepth
38+
39+
M src/physics/cam/gw_drag.F90
40+
- Change the beres storm_shift setting
41+
42+
43+
If there were any failures reported from running test_driver.sh on any test
44+
platform, and checkin with these failures has been OK'd by the gatekeeper,
45+
then copy the lines from the td.*.status files for the failed tests to the
46+
appropriate machine below. All failed tests must be justified.
47+
48+
derecho/intel/aux_cam:
949

10-
Updates to moving mountains scheme for tuning QBO in MT (same settings adopted for LT; issue 1276).
11-
Turn off moving mountains for dycores not passing vorticity to physics (1270).
50+
derecho/nvhpc/aux_cam:
51+
52+
izumi/nag/aux_cam:
1253

13-
Resolves #1276 - tune QBO in MT.
54+
izumi/gnu/aux_cam:
1455

15-
Resolves #1270 - Crash when running moving mountains with FV dycore.
56+
CAM tag used for the baseline comparison tests if different than previous
57+
tag:
1658

17-
Only SE dycore in LT and MT regression tests should be affected.
59+
Summarize any changes to answers, i.e.,
60+
- what code configurations:
61+
- what platforms/compilers:
62+
- nature of change (roundoff; larger than roundoff but same climate; new
63+
climate):
1864

65+
If bitwise differences were observed, how did you show they were no worse
66+
than roundoff?
67+
68+
If this tag changes climate describe the run(s) done to evaluate the new
69+
climate in enough detail that it(they) could be reproduced, i.e.,
70+
- source tag (all code used must be in the repository):
71+
- platform/compilers:
72+
- configure commandline:
73+
- build-namelist command (or complete namelist):
74+
- MSS location of output:
75+
76+
MSS location of control simulations used to validate new climate:
77+
78+
URL for AMWG diagnostics output used to validate new climate:
79+
80+
===============================================================
1981
===============================================================
2082

2183
Tag name: cam6_4_077

src/physics/cam/gw_convect.F90

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ subroutine gw_beres_src(ncol, band, desc, u, v, &
190190
hdepth = [ ( (zm(i,topi(i))-zm(i,boti(i))), i = 1, ncol ) ]
191191

192192
! J. Richter: this is an effective reduction of the GW phase speeds (needed to drive the QBO)
193-
! hdepth = hdepth*qbo_hdepth_scaling
194193
hdepth = max(1000._r8, hdepth*qbo_hdepth_scaling)
195194
hd_idx = index_of_nearest(hdepth, desc%hd)
196195

0 commit comments

Comments
 (0)