Skip to content

Commit 3b6d25d

Browse files
JiangJiasgregkh
authored andcommitted
dmaengine: sh: rcar-dmac: Check for error num after dma_set_max_seg_size
commit da2ad87 upstream. As the possible failure of the dma_set_max_seg_size(), it should be better to check the return value of the dma_set_max_seg_size(). Fixes: 97d49c5 ("dmaengine: rcar-dmac: set scatter/gather max segment size") Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/20220111011239.452837-1-jiasheng@iscas.ac.cn Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2c35c95 commit 3b6d25d

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/dma/sh/rcar-dmac.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1844,7 +1844,10 @@ static int rcar_dmac_probe(struct platform_device *pdev)
18441844

18451845
dmac->dev = &pdev->dev;
18461846
platform_set_drvdata(pdev, dmac);
1847-
dma_set_max_seg_size(dmac->dev, RCAR_DMATCR_MASK);
1847+
ret = dma_set_max_seg_size(dmac->dev, RCAR_DMATCR_MASK);
1848+
if (ret)
1849+
return ret;
1850+
18481851
ret = dma_set_mask_and_coherent(dmac->dev, DMA_BIT_MASK(40));
18491852
if (ret)
18501853
return ret;

0 commit comments

Comments
 (0)