um: Clean up stacktrace dump

jmberg-intel · richardweinberger · commit 273fe1b676cb · 2020-10-11T23:25:07.000+02:00
We currently get a few stray newlines, due to the interaction
between printk() and the code here. Remove a few explicit
newline prints to neaten the output.

Signed-off-by: Johannes Berg &lt;johannes.berg@intel.com&gt;
Signed-off-by: Richard Weinberger &lt;richard@nod.at&gt;
diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
@@ -47,12 +47,10 @@ void show_stack(struct task_struct *task, unsigned long *stack,
 		if (kstack_end(stack))
 			break;
 		if (i && ((i % STACKSLOTS_PER_LINE) == 0))
-			printk("%s\n", loglvl);
+			pr_cont("\n");
 		pr_cont(" %08lx", *stack++);
 	}
-	printk("%s\n", loglvl);
 
 	printk("%sCall Trace:\n", loglvl);
 	dump_trace(current, &stackops, (void *)loglvl);
-	printk("%s\n", loglvl);
 }

Original file line number	Diff line number	Diff line change
`@@ -47,12 +47,10 @@ void show_stack(struct task_struct task, unsigned long stack,`
`47`	`47`	`if (kstack_end(stack))`
`48`	`48`	`break;`
`49`	`49`	`if (i && ((i % STACKSLOTS_PER_LINE) == 0))`
`50`		`- printk("%s\n", loglvl);`
	`50`	`+ pr_cont("\n");`
`51`	`51`	`pr_cont(" %08lx", *stack++);`
`52`	`52`	`}`
`53`		`- printk("%s\n", loglvl);`
`54`	`53`
`55`	`54`	`printk("%sCall Trace:\n", loglvl);`
`56`	`55`	`dump_trace(current, &stackops, (void *)loglvl);`
`57`		`- printk("%s\n", loglvl);`
`58`	`56`	`}`