Configurable log level in service and CLI (#100)

* Make log level configurable for CLI

* Make log level in service configurable

Author: callumforrester

src/blueapi/cli/cli.py

@@ -1,5 +1,6 @@
 import itertools
 import json
+import logging
 from pathlib import Path
 from typing import Dict, Mapping, Optional
 
@@ -46,11 +47,21 @@ def start_worker(config: Optional[Path]):
     help="Broker port",
     default=61613,
 )
+@click.option(
+    "-l",
+    "--log-level",
+    type=str,
+    help="Logger level: TRACE, DEBUG, INFO, WARNING, ERROR or CRITICAL, "
+    "defaults to WARNING",
+    default="WARNING",
+)
 @click.pass_context
-def controller(ctx, host: str, port: int):
+def controller(ctx, host: str, port: int, log_level: str):
     # if no command is supplied, run with the options passed
     if ctx.invoked_subcommand is None:
         print("Please invoke subcommand!")
+        return
+    logging.basicConfig(level=log_level)
     ctx.ensure_object(dict)
     client = AmqClient(StompMessagingTemplate.autoconfigured(StompConfig(host, port)))
     ctx.obj["client"] = client

src/blueapi/config.py

@@ -22,6 +22,11 @@ class EnvironmentConfig:
     startup_script: Union[Path, str] = "blueapi.startup.example"
 
 
+@dataclass
+class LoggingConfig:
+    level: str = "INFO"
+
+
 @dataclass
 class ApplicationConfig:
     """
@@ -31,3 +36,4 @@ class ApplicationConfig:
 
     stomp: StompConfig = field(default_factory=StompConfig)
     env: EnvironmentConfig = field(default_factory=EnvironmentConfig)
+    logging: LoggingConfig = field(default_factory=LoggingConfig)

src/blueapi/service/app.py

@@ -19,8 +19,6 @@
     TaskResponse,
 )
 
-logging.basicConfig(level=logging.INFO)
-
 
 class Service:
     _config: ApplicationConfig
@@ -36,6 +34,7 @@ def __init__(self, config: ApplicationConfig) -> None:
         self._template = StompMessagingTemplate.autoconfigured(config.stomp)
 
     def run(self) -> None:
+        logging.basicConfig(level=self._config.logging.level)
         self._worker.worker_events.subscribe(self._on_worker_event)
         self._worker.task_events.subscribe(self._on_task_event)
         self._worker.data_events.subscribe(self._on_data_event)