Set mIsBeingDeleted before emitting isBeingDestroyed in WbNode (cyberbotics#6857)

* set mIsBeingDeleted before emitting isBeingDestroyed

* update changelog

* disable debug symbols in release builds (revert unnecessary changes)

* fix casts

Author: CoolSpy3

docs/reference/changelog-r2025.md

@@ -5,6 +5,7 @@
     - Fixed a bug preventing the `webots-controller` executable from running on arm-based mac devices ([#6806](https://github.com/cyberbotics/webots/pull/6806)).
     - Fixed a bug causing Webots to crash when multiple sounds were used with a [Speaker](speaker.md) node ([#6843](https://github.com/cyberbotics/webots/pull/6843)).
     - Fixed a bug causing the "Reload/Reset" buttons in the controller recompilation popup to not work on Windows ([#6844](https://github.com/cyberbotics/webots/pull/6844)).
+    - Fixed a bug causing Webots to occasionally crash when unloading a world ([#6857](https://github.com/cyberbotics/webots/pull/6857)).
 
 ## Webots R2025a
 Released on January 31st, 2025.

src/webots/app/WbSelection.cpp

@@ -72,7 +72,7 @@ void WbSelection::selectNode(WbBaseNode *n, bool handlesDisabled) {
 
       if (mSelectedAbstractPose && poseChanged) {
         mSelectedAbstractPose->detachTranslateRotateManipulator();
-        disconnect(mSelectedAbstractPose->baseNode(), &WbBaseNode::isBeingDestroyed, this, &WbSelection::clear);
+        disconnect(mSelectedAbstractPose->baseNode(), &WbNode::isBeingDestroyed, this, &WbSelection::clear);
       }
     }
   }
@@ -88,7 +88,7 @@ void WbSelection::selectNode(WbBaseNode *n, bool handlesDisabled) {
     updateMatterSelection(true);
 
     if (mSelectedAbstractPose && poseChanged) {
-      connect(mSelectedNode, &WbBaseNode::isBeingDestroyed, this, &WbSelection::clear, Qt::UniqueConnection);
+      connect(mSelectedNode, &WbNode::isBeingDestroyed, this, &WbSelection::clear, Qt::UniqueConnection);
       if (!handlesDisabled && !mSelectedNode->isUseNode() &&
           !WbNodeUtilities::isNodeOrAncestorLocked(mSelectedAbstractPose->baseNode()))
         mSelectedAbstractPose->attachTranslateRotateManipulator();

src/webots/gui/WbMainWindow.cpp

@@ -2181,7 +2181,7 @@ void WbMainWindow::showHtmlRobotWindow(WbRobot *robot, bool manualTrigger) {
       currentRobotWindow = new WbRobotWindow(robot);
       mRobotWindows << currentRobotWindow;
       connect(mTcpServer, &WbTcpServer::sendRobotWindowClientID, currentRobotWindow, &WbRobotWindow::setClientID);
-      connect(robot, &WbBaseNode::isBeingDestroyed, this, [this, robot]() { deleteRobotWindow(robot); });
+      connect(robot, &WbNode::isBeingDestroyed, this, [this, robot]() { deleteRobotWindow(robot); });
       connect(robot, &WbMatter::matterNameChanged, this, [this, robot]() { showHtmlRobotWindow(robot, false); });
       connect(robot, &WbRobot::controllerChanged, this, [this, robot]() { showHtmlRobotWindow(robot, false); });
       connect(robot, &WbRobot::externControllerChanged, this, [this, robot]() { showHtmlRobotWindow(robot, false); });

src/webots/gui/WbRenderingDeviceWindowFactory.cpp

@@ -116,7 +116,7 @@ WbRenderingDeviceWindow *WbRenderingDeviceWindowFactory::getWindowForDevice(WbRe
     return NULL;
 
   WbRenderingDeviceWindow *window = new WbRenderingDeviceWindow(device);
-  connect(device, &WbRenderingDevice::isBeingDestroyed, this, &WbRenderingDeviceWindowFactory::deleteWindow);
+  connect(device, &WbNode::isBeingDestroyed, this, &WbRenderingDeviceWindowFactory::deleteWindow);
   mWindowsList.append(window);
   return window;
 }
@@ -140,7 +140,7 @@ void WbRenderingDeviceWindowFactory::setWindowsEnabled(bool enabled) {
 }
 
 void WbRenderingDeviceWindowFactory::deleteWindow() {
-  WbBaseNode *node = dynamic_cast<WbBaseNode *>(sender());
+  WbNode *node = dynamic_cast<WbNode *>(sender());
   assert(node);
   for (int i = 0; i < mWindowsList.size(); ++i) {
     if (mWindowsList[i]->deviceId() == node->uniqueId()) {

src/webots/nodes/WbBaseNode.cpp

@@ -72,7 +72,6 @@ WbBaseNode::WbBaseNode(const QString &modelName) : WbNode(modelName) {
 }
 
 WbBaseNode::~WbBaseNode() {
-  emit isBeingDestroyed(this);
   if (mPostFinalizeCalled && !defName().isEmpty() && !WbWorld::instance()->isCleaning() && !WbTemplateManager::isRegenerating())
     WbDictionary::instance()->removeNodeFromDictionary(this);
 }

src/webots/nodes/WbBaseNode.hpp

@@ -129,7 +129,6 @@ class WbBaseNode : public WbNode {
   QString documentationUrl() const;
 
 signals:
-  void isBeingDestroyed(WbBaseNode *node);
   void visibleHandlesChanged(bool resizeHandlesEnabled);
   void finalizationCompleted(WbBaseNode *node);
 

src/webots/nodes/WbRobot.cpp

@@ -284,7 +284,7 @@ void WbRobot::addDevices(WbNode *node) {
 
       WbRenderingDevice *renderingDevice = dynamic_cast<WbRenderingDevice *>(node);
       if (renderingDevice) {
-        connect(renderingDevice, &WbBaseNode::isBeingDestroyed, this, &WbRobot::removeRenderingDevice, Qt::UniqueConnection);
+        connect(renderingDevice, &WbNode::isBeingDestroyed, this, &WbRobot::removeRenderingDevice, Qt::UniqueConnection);
         mRenderingDevices.append(renderingDevice);
         WbAbstractCamera *camera = dynamic_cast<WbAbstractCamera *>(renderingDevice);
         if (camera) {
@@ -632,7 +632,7 @@ void WbRobot::updateBattery(bool itemInserted) {
 }
 
 void WbRobot::removeRenderingDevice() {
-  mRenderingDevices.removeOne(static_cast<WbRenderingDevice *>(sender()));
+  mRenderingDevices.removeOne(dynamic_cast<WbRenderingDevice *>(sender()));
 }
 
 void WbRobot::assignDeviceTags(bool reset) {

src/webots/vrml/WbNode.cpp

@@ -250,6 +250,7 @@ WbNode::WbNode(const WbNode &other) :
 
 WbNode::~WbNode() {
   mIsBeingDeleted = true;
+  emit isBeingDestroyed(this);
 
   // Delete fields backwards to always delete USE nodes before DEF nodes
   int n = mFields.size() - 1;

src/webots/vrml/WbNode.hpp

@@ -281,6 +281,8 @@ class WbNode : public QObject {
   virtual const bool isRobot() const { return false; };
 
 signals:
+  void isBeingDestroyed(WbNode *node);
+
   // emitted when any value has changed
   void fieldChanged(WbField *field);
   void parameterChanged(WbField *field);