Fixed QFile.open() compilation warnings and macos-13 CI tests (cyberbotics#6924)

* Fixed Qt file open compilation warnings

* Initial plan

* Fix updateStyleSheet() to only read files when open succeeds

Co-authored-by: omichel <1264964+omichel@users.noreply.github.com>

* Fixed lupdate and lrelease command line names on Windows

* Reverted lrelease/lupdate to previous names

* Simplified/factorized

* Fixed consistency

* Fixed used of now retired macOS-13 runner

* Update src/webots/sound/WbWaveFile.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omichel <1264964+omichel@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

.github/workflows/test_suite_mac.yml

@@ -19,7 +19,7 @@ jobs:
     if: ${{ contains(github.event.pull_request.labels.*.name, 'test webots build') }}
     strategy:
       matrix:
-        os: [macos-13]
+        os: [macos-14]
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v3
@@ -33,7 +33,7 @@ jobs:
     if: ${{ github.event_name == 'push' || github.event_name == 'schedule' || contains(github.event.pull_request.labels.*.name, 'test distribution') || contains(github.event.pull_request.labels.*.name, 'test suite') }}
     strategy:
       matrix:
-        os: [macos-13]
+        os: [macos-14]
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v3
@@ -70,7 +70,7 @@ jobs:
     if: ${{ contains(github.event.pull_request.labels.*.name, 'test suite mac') }}
     strategy:
       matrix:
-        os: [macos-13]
+        os: [macos-14]
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v3
@@ -103,7 +103,7 @@ jobs:
     if: ${{ always() && !contains(github.event.pull_request.labels.*.name, 'test distribution')  && !contains(github.event.pull_request.labels.*.name, 'test webots build') }}
     strategy:
       matrix:
-        os: [macos-13]
+        os: [macos-14]
     runs-on: ubuntu-latest
     steps:
     - name: Delete artifacts

src/webots/app/WbApplication.cpp

@@ -271,7 +271,8 @@ void WbApplication::loadWorld(QString worldName, bool reloading, bool isLoadingA
   emit preWorldLoaded(reloading);
   // create a file in tmp path for ipc extern controllers
   QFile loading_file(WbStandardPaths::webotsTmpPath() + "loading");
-  loading_file.open(QIODevice::WriteOnly | QIODevice::Text | QIODevice::Truncate);
+  if (!loading_file.open(QIODevice::WriteOnly | QIODevice::Text | QIODevice::Truncate))
+    WbLog::warning(tr("Could not create loading signal file: '%1'.").arg(loading_file.fileName()));
 
   bool isFirstLoad = (mWorld == NULL);
   delete mWorld;

src/webots/core/WbIniParser.cpp

@@ -21,7 +21,10 @@ WbIniParser::WbIniParser(const QString &filename) {
   QFile file(filename);
   QString line;
   QString section;
-  file.open(QIODevice::ReadOnly);
+  if (!file.open(QIODevice::ReadOnly)) {
+    mValid = false;
+    return;
+  }
   mValid = true;
   while (!file.atEnd()) {
     line = file.readLine();

src/webots/gui/WbGuiApplication.cpp

@@ -565,25 +565,26 @@ static void setDarkTitlebar(HWND hwnd) {
 void WbGuiApplication::updateStyleSheet() {
   mThemeLoaded = WbPreferences::instance()->value("General/theme").toString();
   QFile qssFile(WbStandardPaths::resourcesPath() + mThemeLoaded);
-  qssFile.open(QFile::ReadOnly);
-  QString styleSheet = QString::fromUtf8(qssFile.readAll());
+  QString styleSheet;
+  if (qssFile.open(QFile::ReadOnly))
+    styleSheet = QString::fromUtf8(qssFile.readAll());
+  else
+    WbLog::warning(tr("Could not open theme file: '%1'.").arg(qssFile.fileName()));
 
 #ifdef __APPLE__
-  QFile macOSQssFile(WbStandardPaths::resourcesPath() + "stylesheet.macos.qss");
-  macOSQssFile.open(QFile::ReadOnly);
-  styleSheet += QString::fromUtf8(macOSQssFile.readAll());
-
+  const QString platformStylesheet = "stylesheet.macos.qss";
 #elif defined(__linux__)
-  QFile linuxQssFile(WbStandardPaths::resourcesPath() + "stylesheet.linux.qss");
-  linuxQssFile.open(QFile::ReadOnly);
-  styleSheet += QString::fromUtf8(linuxQssFile.readAll());
-
+  const QString platformStylesheet = "stylesheet.linux.qss";
 #elif _WIN32
-  QFile windowsQssFile(WbStandardPaths::resourcesPath() + "stylesheet.windows.qss");
-  windowsQssFile.open(QFile::ReadOnly);
-  styleSheet += QString::fromUtf8(windowsQssFile.readAll());
+  const QString platformStylesheet = "stylesheet.windows.qss";
 #endif
 
+  QFile platformQssFile(WbStandardPaths::resourcesPath() + platformStylesheet);
+  if (platformQssFile.open(QFile::ReadOnly))
+    styleSheet += QString::fromUtf8(platformQssFile.readAll());
+  else
+    WbLog::warning(tr("Could not open stylesheet file: '%1'.").arg(platformQssFile.fileName()));
+
   qApp->setStyleSheet(styleSheet);
 #ifdef _WIN32
   if (mThemeLoaded != "webots_classic.qss")

src/webots/gui/WbMainWindow.cpp

@@ -2432,7 +2432,10 @@ void WbMainWindow::openFileInTextEditor(const QString &fileName, bool modify, bo
       const QString webotsRepo = fileName.mid(0, index);
 
       QFile localFile(fileToOpen);
-      localFile.open(QIODevice::ReadWrite);
+      if (!localFile.open(QIODevice::ReadWrite)) {
+        WbLog::error(tr("Could not open file for editing: '%1'.").arg(fileToOpen));
+        return;
+      }
       const QString contents = QString(localFile.readAll());
       QStringList lines = contents.split('\n');
       for (QString &line : lines) {

src/webots/gui/WbNewWorldWizard.cpp

@@ -17,6 +17,7 @@
 #include "WbApplicationInfo.hpp"
 #include "WbFileUtil.hpp"
 #include "WbLineEdit.hpp"
+#include "WbLog.hpp"
 #include "WbMessageBox.hpp"
 #include "WbPreferences.hpp"
 #include "WbProject.hpp"
@@ -49,7 +50,10 @@ int WbNewWorldWizard::exec() {
 
 void WbNewWorldWizard::createWorldFile() {
   QFile file(WbProject::current()->worldsPath() + fileName());
-  file.open(QIODevice::WriteOnly);
+  if (!file.open(QIODevice::WriteOnly)) {
+    WbLog::error(tr("Could not create world file: '%1'.").arg(file.fileName()));
+    return;
+  }
   QByteArray worldContent;
   worldContent.append(QString("#VRML_SIM %1 utf8\n").arg(WbApplicationInfo::version().toString(false)).toUtf8());
   QStringList externProtoList;

src/webots/scene_tree/WbSceneTree.cpp

@@ -1593,7 +1593,10 @@ void WbSceneTree::openTemplateInstanceInTextEditor() {
   tmpDir.mkdir(generatedProtos);
   QFile file(
     QString("%1%2/%3.generated_proto").arg(WbStandardPaths::webotsTmpPath()).arg(generatedProtos).arg(node->proto()->name()));
-  file.open(QIODevice::WriteOnly | QIODevice::Text);
+  if (!file.open(QIODevice::WriteOnly | QIODevice::Text)) {
+    WbLog::error(tr("Could not create temporary file: '%1'.").arg(file.fileName()));
+    return;
+  }
   file.write(node->protoInstanceTemplateContent());
   file.close();
   if (!file.fileName().isEmpty())

src/webots/sound/WbWaveFile.cpp

@@ -14,6 +14,7 @@
 
 #include "WbWaveFile.hpp"
 
+#include "WbLog.hpp"
 #include "WbStandardPaths.hpp"
 
 #include <QtCore/QDir>
@@ -187,7 +188,11 @@ void WbWaveFile::loadConvertedFile(int side) {
 void WbWaveFile::loadConvertedFile(int side, const QString &filename) {
   assert(mDevice == NULL);
   mDevice = new QFile(filename);
-  mDevice->open(QIODevice::ReadOnly);
+  if (!mDevice->open(QIODevice::ReadOnly)) {
+    delete mDevice;
+    mDevice = NULL;
+    throw QObject::tr("Could not open audio device: '%1'.").arg(filename);
+  }
   loadConvertedFile(side);
   mDevice->close();
   delete mDevice;
@@ -216,7 +221,8 @@ void WbWaveFile::loadFromFile(const QString &extension, int side) {
   if (mDevice) {
     inputFilename = WbStandardPaths::webotsTmpPath() + "input." + extension;
     QFile input(inputFilename);
-    input.open(QFile::WriteOnly);
+    if (!input.open(QFile::WriteOnly))
+      throw QObject::tr("Could not create temporary audio file: '%1'.").arg(inputFilename);
     input.write(mDevice->readAll());
     input.close();
   } else