Skip to content

Commit da73305

Browse files
jeremymanningclaude
andcommitted
Add submodule support to CI and pre-push checks (Phase 5)
- Updated build-cv.yml to checkout with submodules: true - Added submodule initialization check to pre_push_check.py (warning only) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent e7c1f77 commit da73305

3 files changed

Lines changed: 18 additions & 2 deletions

File tree

.github/workflows/build-cv.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ jobs:
2828
steps:
2929
- name: Checkout repository
3030
uses: actions/checkout@v4
31+
with:
32+
submodules: true
3133

3234
- name: Install TeX Live
3335
run: |

scripts/pre_push_check.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,27 @@ def run_script(script_name: str) -> bool:
2323
return result.returncode == 0
2424

2525

26+
def check_submodule() -> bool:
27+
"""Check if lab-manual submodule is initialized."""
28+
lab_manual = Path(__file__).parent.parent / 'lab-manual' / 'lab_manual.tex'
29+
if not lab_manual.exists():
30+
print("\nWARNING: Lab-manual submodule not initialized.")
31+
print("Run: git submodule update --init")
32+
print("Some sync features will not work without it.\n")
33+
return False
34+
return True
35+
36+
2637
def main():
2738
"""Run all pre-push checks."""
2839
print("Context Lab Website Pre-Push Check")
2940
print("=" * 50)
3041

3142
all_passed = True
3243

44+
# Step 0: Check submodule
45+
check_submodule() # Warning only, doesn't block
46+
3347
# Step 1: Validate data
3448
if not run_script('validate_data.py'):
3549
print("\n*** Data validation FAILED ***")

specs/001-people-labmanual-sync/tasks.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@
9191

9292
### Implementation for User Story 3
9393

94-
- [ ] T026 [US3] Update `.github/workflows/build-cv.yml` to init submodule before build steps (if reconciliation or CV sync references lab-manual)
95-
- [ ] T027 [US3] Add submodule initialization check to `scripts/pre_push_check.py`: warn if submodule is not initialized when running checks that depend on it
94+
- [x] T026 [US3] Update `.github/workflows/build-cv.yml` to init submodule before build steps (if reconciliation or CV sync references lab-manual)
95+
- [x] T027 [US3] Add submodule initialization check to `scripts/pre_push_check.py`: warn if submodule is not initialized when running checks that depend on it
9696
- [ ] T028 [US3] Test that GitHub Actions workflows succeed with the submodule (verify CI can access lab-manual/lab_manual.tex)
9797

9898
**Checkpoint**: Submodule works in local dev AND CI environments

0 commit comments

Comments
 (0)