Fixed not finding attributes on methods symbols, misc cleanup

Author: Arlodotexe

CommunityToolkit.Tooling.SampleGen.Tests/ToolkitSampleGeneratedPaneTests.cs

@@ -83,7 +83,7 @@ public class UserControl { }
         // Create application head that references generated sample project
         var headCompilation = string.Empty
             .ToSyntaxTree()
-            .CreateCompilation("MyApp.Head", TestHelpers.GetAllReferencedAssemblies())
+            .CreateCompilation("MyApp.Head")
             .AddReferences(sampleProjectAssembly);
 
         // Run source generator
@@ -414,7 +414,7 @@ public class UserControl {{ }}
         // Create application head that references generated sample project
         var headCompilation = string.Empty
             .ToSyntaxTree()
-            .CreateCompilation("MyApp.Head", TestHelpers.GetAllReferencedAssemblies())
+            .CreateCompilation("MyApp.Head")
             .AddReferences(sampleProjectAssembly);
 
         // Run source generator

CommunityToolkit.Tooling.SampleGen/GeneratorExtensions.cs

@@ -16,17 +16,6 @@ public static class GeneratorExtensions
     /// <returns>A flattened enumerable of <see cref="INamedTypeSymbol"/>s.</returns>
     public static IEnumerable<ISymbol> CrawlForAllSymbols(this INamespaceSymbol namespaceSymbol)
     {
-        foreach (var member in namespaceSymbol.GetNamespaceMembers())
-        {
-            if (member is INamespaceSymbol nestedNamespace)
-            {
-                foreach (var item in CrawlForAllSymbols(nestedNamespace))
-                {
-                    yield return item;
-                }
-            }
-        }
-
         // Get all classes and methods
         foreach (var item in namespaceSymbol.GetTypeMembers())
         {
@@ -35,8 +24,17 @@ public static IEnumerable<ISymbol> CrawlForAllSymbols(this INamespaceSymbol name
             foreach (var itemMember in item.GetMembers())
             {
                 if (itemMember.Kind == SymbolKind.Method)
-                {
                     yield return itemMember;
+            }
+        }
+
+        foreach (var member in namespaceSymbol.GetNamespaceMembers())
+        {
+            if (member is INamespaceSymbol nestedNamespace)
+            {
+                foreach (var item in CrawlForAllSymbols(nestedNamespace))
+                {
+                    yield return item;
                 }
             }
         }

CommunityToolkit.Tooling.SampleGen/Metadata/ToolkitSampleButtonCommand.cs

@@ -20,11 +20,11 @@ public ToolkitSampleButtonCommand(Action callback)
 
     /// <inheritdoc />
     public event EventHandler? CanExecuteChanged;
-    
+
     /// <inheritdoc />
     public bool CanExecute(object parameter)
     {
-        throw new NotImplementedException();
+        return true;
     }
     /// <inheritdoc />
     public void Execute(object parameter)

CommunityToolkit.Tooling.SampleGen/ToolkitSampleMetadataGenerator.Sample.cs

@@ -54,7 +54,7 @@ void Execute(IncrementalValuesProvider<ISymbol> types, bool skipDiagnostics = fa
 
             // Find and reconstruct generated pane option attributes + the original type symbol.
             var generatedPaneOptions = allAttributeData
-                .Select(static (x, _) =>
+                .Select((x, _) =>
                 {
                     (ISymbol Symbol, ToolkitSampleOptionBaseAttribute Attribute) item = default;
 
@@ -118,7 +118,7 @@ void Execute(IncrementalValuesProvider<ISymbol> types, bool skipDiagnostics = fa
 
             context.RegisterSourceOutput(all, (ctx, data) =>
             {
-                var toolkitSampleAttributeData = data.Left.Left.Left.Right.Where(x => x != default).Distinct();
+                var toolkitSampleAttributeData = data.Left.Left.Left.Right.Where(x => x != default).Distinct().ToArray();
                 var optionsPaneAttribute = data.Left.Left.Left.Left.Where(x => x != default).Distinct();
                 var generatedOptionPropertyData = data.Left.Left.Right.Where(x => x.Attribute is not null && x.Symbol is not null);
                 var markdownFileData = data.Left.Right.Where(x => x != default).Distinct();
@@ -138,7 +138,7 @@ void Execute(IncrementalValuesProvider<ISymbol> types, bool skipDiagnostics = fa
                                 sample.Attribute.Description,
                                 sample.AttachedQualifiedTypeName,
                                 optionsPaneAttribute.FirstOrDefault(x => x.Item1?.SampleId == sample.Attribute.Id).Item2?.ToString(),
-                                generatedOptionPropertyData.Where(x => Equals(x.Symbol, sample.Symbol)).Select(x => x.Item2)
+                                generatedOptionPropertyData.Where(x => x.Symbol.Equals(sample.Symbol, SymbolEqualityComparer.Default)).Select(x => x.Item2)
                             )
                     );
 
@@ -315,7 +315,7 @@ private static IEnumerable<string> BuildNewGeneratedSampleOptionMetadataSource(T
             }
             else if (item is ToolkitSampleButtonActionAttribute buttonAttribute)
             {
-                yield return $@"new {typeof(ToolkitSampleButtonActionMetadataViewModel).FullName}(name: ""{buttonAttribute.Name}"", label: ""{buttonAttribute.Label}"", title: ""{buttonAttribute.Title}"")";
+                yield return $@"new {typeof(ToolkitSampleButtonActionMetadataViewModel).FullName}(name: ""{buttonAttribute.Name}"", controlToBindingValueFactory: x => x.{buttonAttribute.Name}Command, label: ""{buttonAttribute.Label}"", title: ""{buttonAttribute.Title}"")";
             }
             else if (item is ToolkitSampleNumericOptionAttribute numericAttribute)
             {

CommunityToolkit.Tooling.SampleGen/ToolkitSampleOptionGenerator.cs

@@ -206,7 +206,7 @@ public partial class {{attachedMethodSymbol.ContainingSymbol.Name}}
             get
             {
                 var metadata = GeneratedPropertyMetadata!.First(x => x.Name == nameof({{attachedMethodSymbol.Name}}));
-                return ({{typeof(System.Windows.Input.ICommand).FullName}})(metadata.Value ??= new {{typeof(ToolkitSampleButtonCommand).FullName}}({{attachedMethodSymbol.Name}}));
+                return ({{typeof(System.Windows.Input.ICommand).FullName}})(metadata.Value ??= new {{typeof(ToolkitSampleButtonCommand).FullName}}(() => {{attachedMethodSymbol.Name}}()));
             }
             set
             {