Complete refactor of SampleGen tests

Author: Arlodotexe

CommunityToolkit.Tooling.SampleGen.Tests/SampleGenTestHelpers.cs

@@ -29,7 +29,6 @@ internal static void VerifyGeneratedDiagnostics<TGenerator>(SyntaxTree syntaxTre
 
         _ = driver.RunGeneratorsAndUpdateCompilation(compilation, out Compilation generatorCompilation, out ImmutableArray<Diagnostic> postGeneratorCompilationDiagnostics);
 
-        VerifyCompilationErrors(compilation);
         VerifyCompilationErrors(generatorCompilation);
         VerifyDiagnostics(diagnosticsIds, postGeneratorCompilationDiagnostics);
     }
@@ -48,7 +47,7 @@ internal static void VerifyGenerateSources(string assemblyName, string source, I
             CollectionAssert.AreEquivalent(Array.Empty<Diagnostic>(), diagnostics);
         }
 
-        VerifyCompilationErrors(compilation);
+        VerifyCompilationErrors(generatorCompilation);
         VerifyGeneratedSources(results, generatorCompilation);
     }
 

CommunityToolkit.Tooling.SampleGen.Tests/ToolkitSampleGeneratedPaneTests.cs

@@ -58,8 +58,6 @@ public partial class Sample : Windows.UI.Xaml.Controls.UserControl
                 {
                     public Sample()
                     {
-                        var x = this.Test;
-                        var y = this.TextFontFamily;
                     }
                 }
             }
@@ -83,7 +81,7 @@ public static class ToolkitSampleRegistry
             }
             """;
 
-        ToolkitSampleMetadataTests.VerifyGenerateSources("MyApp.Tests", source, new[] { new ToolkitSampleMetadataGenerator() }, ignoreDiagnostics: true, ("ToolkitSampleRegistry.g.cs", result));
+        TestHelpers.VerifyGenerateSources("MyApp.Tests", source, new[] { new ToolkitSampleMetadataGenerator() }, ignoreDiagnostics: true, ("ToolkitSampleRegistry.g.cs", result));
     }
 
     // https://github.com/CommunityToolkit/Labs-Windows/issues/175

CommunityToolkit.Tooling.SampleGen.Tests/ToolkitSampleMetadataTests.Documentation.cs

@@ -40,7 +40,7 @@ public void MissingFrontMatterSection()
             Without any front matter.
             ";
 
-        VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown, DiagnosticDescriptors.MarkdownYAMLFrontMatterException.Id, DiagnosticDescriptors.SampleNotReferencedInMarkdown.Id);
+        TestHelpers.VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown, DiagnosticDescriptors.MarkdownYAMLFrontMatterException.Id, DiagnosticDescriptors.SampleNotReferencedInMarkdown.Id);
     }
 
     [DataRow(1, DisplayName = "Title")]
@@ -74,7 +74,7 @@ public void MissingFrontMatterField(int removeline)
         lines.RemoveAt(removeline);
         markdown = String.Join('\n', lines);
 
-        VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown, DiagnosticDescriptors.MarkdownYAMLFrontMatterMissingField.Id, DiagnosticDescriptors.SampleNotReferencedInMarkdown.Id); // We won't see the sample reference as we bail out when the front matter fails to be complete...
+        TestHelpers.VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown, DiagnosticDescriptors.MarkdownYAMLFrontMatterMissingField.Id, DiagnosticDescriptors.SampleNotReferencedInMarkdown.Id); // We won't see the sample reference as we bail out when the front matter fails to be complete...
     }
 
     [TestMethod]
@@ -97,7 +97,7 @@ public void MarkdownInvalidSampleReference()
 Without any front matter.
 ";
 
-        VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown,
+        TestHelpers.VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown,
             DiagnosticDescriptors.MarkdownSampleIdNotFound.Id,
             DiagnosticDescriptors.SampleNotReferencedInMarkdown.Id);
     }
@@ -120,7 +120,7 @@ public void DocumentationMissingSample()
 # This is some test documentation...
 Without any sample.";
 
-        VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown,
+        TestHelpers.VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown,
             DiagnosticDescriptors.DocumentationHasNoSamples.Id,
             DiagnosticDescriptors.SampleNotReferencedInMarkdown.Id);
     }
@@ -144,7 +144,7 @@ public void DocumentationValid()
 Which is valid.
 > [!SAMPLE Sample]";
 
-        VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown);
+        TestHelpers.VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(SimpleSource, markdown);
     }
 
     [TestMethod]
@@ -165,7 +165,7 @@ public void DocumentationInvalidDiscussionId()
 # This is some test documentation...
 Without an invalid discussion id.";
 
-        VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(string.Empty, markdown,
+        TestHelpers.VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(string.Empty, markdown,
             DiagnosticDescriptors.MarkdownYAMLFrontMatterException.Id,
             DiagnosticDescriptors.DocumentationHasNoSamples.Id);
     }
@@ -188,7 +188,7 @@ public void DocumentationInvalidIssueId()
 # This is some test documentation...
 Without an invalid discussion id.";
 
-        VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(string.Empty, markdown,
+        TestHelpers.VerifyGeneratedDiagnostics<ToolkitSampleMetadataGenerator>(string.Empty, markdown,
             DiagnosticDescriptors.MarkdownYAMLFrontMatterException.Id,
             DiagnosticDescriptors.DocumentationHasNoSamples.Id);
     }