Skip to content

Commit b64ac97

Browse files
committed
Merge pull request #404 from CodeNow/SAN-3816-move-logs-or-dont-its-up-to-you
app_log_dir is now variable (default: /var/log)
2 parents 3135894 + f84c7da commit b64ac97

16 files changed

Lines changed: 38 additions & 15 deletions

File tree

ansible/group_vars/all.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ loggly_username: ops
3232
## cores and logs
3333
##
3434

35+
app_log_dir: /var/log
3536
core_file_dir: /var/log/core
3637

3738
##

ansible/group_vars/alpha-vault.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ container_run_opts: >
1414
-v /opt/runnable/vault/vault.hcl:/vault.hcl:ro
1515
-v /opt/vault/client-consul:/opt/vault/client-consul:ro
1616
-v /opt/vault/server:/opt/vault/server:ro
17-
-v /var/log:/var/log:rw
17+
-v {{ app_log_dir }}:{{ app_log_dir }}:rw
1818
-p {{ ansible_default_ipv4.address }}:8200:8200
1919
-p {{ ansible_default_ipv4.address }}:8201:8201
2020
--cap-add IPC_LOCK

ansible/roles/builder/templates/basic_node/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,4 @@ RUN {{ command }}
4545
{% endif %}
4646

4747
# Define default command.
48-
CMD ulimit -c unlimited && /usr/local/bin/npm {{ npm_start_command | default('start') }} > /var/log/{{ name }}.log 2>&1
48+
CMD ulimit -c unlimited && /usr/local/bin/npm {{ npm_start_command | default('start') }} > {{ app_log_dir }}/{{ name }}.log 2>&1

ansible/roles/container_kill_start/tasks/main.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@
6464
command: >
6565
sudo docker run
6666
--log-driver={{ log_driver | default("none")}}
67-
-v /var/log:/var/log:rw
67+
-v {{ app_log_dir }}:{{ app_log_dir }}:rw
68+
-v /dev/log:/dev/log:rw
6869
--restart={{ restart_policy | default('always') }}
6970
{{ container_run_opts}}
7071
{{ container_image }}:{{ container_tag }}

ansible/roles/container_start/tasks/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
- name: start new container
3030
tags: deploy
31-
shell: for i in {{ '{' }}1..{{ number_of_containers }}{{ '}' }}; do sudo docker run --log-driver=none -v /var/log:/var/log:rw --restart={{ restart_policy | default('no') }} {{ container_run_opts }} {{ container_image }}:{{ container_tag }} {{ container_run_args }}; done
31+
shell: for i in {{ '{' }}1..{{ number_of_containers }}{{ '}' }}; do sudo docker run --log-driver=none -v {{ app_log_dir }}:{{ app_log_dir }}:rw -v /dev/log://dev/log:rw --restart={{ restart_policy | default('no') }} {{ container_run_opts }} {{ container_image }}:{{ container_tag }} {{ container_run_args }}; done
3232
args:
3333
executable: /bin/bash
3434
register: new_container_ids

ansible/roles/docker/tasks/main.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,15 @@
9191
update_cache=yes
9292
cache_valid_time=604800
9393

94+
- name: enforce modes on /docker
95+
become: true
96+
file:
97+
path=/docker
98+
state=directory
99+
owner=root
100+
group=root
101+
mode=0755
102+
94103
- name: restart docker
95104
when: (copied_config.changed and restart is defined) or dock is defined
96105
command: sudo service docker restart

ansible/roles/khronos/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
Run Khronos CLI tool out of cron once daily.
22

3-
`tasks/main.yml` - install cron entry to run `/khronos/bin/cli.js` and output to `/var/log/khonos_cron.log`
3+
`tasks/main.yml` - install cron entry to run `/khronos/bin/cli.js` and output to `{{ app_log_dir }}/khonos_cron.log`

ansible/roles/khronos/tasks/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
tags: cron
1818
cron:
1919
name: "{{ item.name }}"
20-
job: /opt/runnable/{{ item.script }} >> /var/log/{{ item.script }}.log 2>&1
20+
job: /opt/runnable/{{ item.script }} >> {{ app_log_dir }}/{{ item.script }}.log 2>&1
2121
minute: "{{ item.minute | default('*') }}"
2222
hour: "{{ item.hour | default('*') }}"
2323
state: "{{ item.state | default('present') }}"
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
- name: create application logs directory
3+
tags: rsyslog
4+
when: app_log_dir != "/var/log"
5+
become: true
6+
file:
7+
path="{{ app_log_dir }}"
8+
state=directory
9+
owner=root
10+
group=syslog
11+
mode=0775
12+

ansible/roles/loggly-rotate/tasks/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
tags: [loggly, deploy]
9999
become: true
100100
file:
101-
path=/var/log/{{ name }}-daemon.log
101+
path={{ app_log_dir }}/{{ name }}-daemon.log
102102
state=touch
103103
owner=syslog
104104
group=adm

0 commit comments

Comments
 (0)