🚨 remove sonarlint warnings

Jérémie Bertrand · Jérémie Bertrand · commit be16c34be158 · 2017-02-08T21:51:52.000+01:00
diff --git a/src/Pretzel.Logic/Commands/CommandParameters.cs b/src/Pretzel.Logic/Commands/CommandParameters.cs
@@ -78,7 +78,7 @@ public decimal Port
 
         private OptionSet Settings { get; set; }
 
-        private IFileSystem fileSystem;
+        private readonly IFileSystem fileSystem;
 
         public void Parse(IEnumerable<string> arguments)
         {
diff --git a/src/Pretzel.Logic/Extensibility/Extensions/PostUrlTag.cs b/src/Pretzel.Logic/Extensibility/Extensions/PostUrlTag.cs
@@ -10,7 +10,7 @@ namespace Pretzel.Logic.Extensibility.Extensions
     public class PostUrlTag : DotLiquid.Tag, ITag
     {
         private string _postFileName;
-        private SiteContext _siteContext;
+        private readonly SiteContext _siteContext;
 
         public new string Name { get { return "PostUrl"; } }
         
diff --git a/src/Pretzel.Logic/Extensibility/Extensions/SlugifyFilter.cs b/src/Pretzel.Logic/Extensibility/Extensions/SlugifyFilter.cs
@@ -1,4 +1,5 @@
-﻿using System.Text.RegularExpressions;
+﻿using System.Globalization;
+using System.Text.RegularExpressions;
 
 namespace Pretzel.Logic.Extensibility.Extensions
 {
@@ -11,7 +12,7 @@ public string Name
 
         public static string Slugify(string input)
         {
-            var str = input.ToLower().Trim('.', ' ');
+            var str = input.ToLower(CultureInfo.InvariantCulture).Trim('.', ' ');
 
             str = str.Replace("#", "sharp").Replace('.', '-');
             // invalid chars, make into spaces
diff --git a/src/Pretzel.Logic/Extensibility/TagFactoryBase.cs b/src/Pretzel.Logic/Extensibility/TagFactoryBase.cs
@@ -7,7 +7,7 @@ namespace Pretzel.Logic.Extensibility
     [InheritedExport]
     public abstract class TagFactoryBase : DotLiquid.ITagFactory
     {
-        private string _tageName;
+        private readonly string _tageName;
         
         protected SiteContext SiteContext { get; private set; }
 
diff --git a/src/Pretzel.Logic/Extensions/StringExtensions.cs b/src/Pretzel.Logic/Extensions/StringExtensions.cs
@@ -1,6 +1,5 @@
 ﻿using System;
 using System.Collections.Generic;
-using System.IO;
 using System.IO.Abstractions;
 using System.Linq;
 
@@ -532,7 +531,7 @@ public static string MimeType(this string filename)
         {
             if (!filename.Contains("."))
                 return "text/html";
-            string extension = filename.Substring(filename.LastIndexOf("."));
+            string extension = filename.Substring(filename.LastIndexOf(".", StringComparison.InvariantCulture));
             return Get(extension, types["bin"]);
         }
 
diff --git a/src/Pretzel.Logic/Import/BloggerImport.cs b/src/Pretzel.Logic/Import/BloggerImport.cs
@@ -46,10 +46,9 @@ public void Import()
             //    <entry>
 
             XNamespace atom = "http://www.w3.org/2005/Atom";
-            var count = root.Descendants(atom + "entry").Count();
 
             var posts = from e in root.Descendants(atom + "entry")
-                        where e.Elements(atom + "category").Where(x => x.Attribute("term").Value == "http://schemas.google.com/blogger/2008/kind#post").Count() > 0
+                        where e.Elements(atom + "category").Any(x => x.Attribute("term").Value == "http://schemas.google.com/blogger/2008/kind#post")
                         select new BloggerPost
                         {
                             Title = e.Element(atom + "title").Value,
diff --git a/src/Pretzel.Logic/Import/HtmlToMarkdownConverter.cs b/src/Pretzel.Logic/Import/HtmlToMarkdownConverter.cs
@@ -108,9 +108,6 @@ private void ProcessNodes(StringBuilder markdown, IEnumerable<HtmlNode> htmlNode
                         break;
                     case "img":
                     case "blockquote":
-                        // leave html unchanged for now, maybe revisit later
-                        markdown.Append(htmlNode.OuterHtml);
-                        break;
                     case "object":
                     case "table":
                     case "div":
diff --git a/src/Pretzel.Logic/Liquid/CgiEscapeFilter.cs b/src/Pretzel.Logic/Liquid/CgiEscapeFilter.cs
@@ -1,8 +1,8 @@
-using System;
+﻿using System;
 
 namespace Pretzel.Logic.Liquid
 {
-    public class CgiEscapeFilter
+    public static class CgiEscapeFilter
     {
         public static string cgi_escape(string input)
         {
diff --git a/src/Pretzel.Logic/Liquid/DateToLongStringFilter.cs b/src/Pretzel.Logic/Liquid/DateToLongStringFilter.cs
@@ -3,11 +3,10 @@
 
 namespace Pretzel.Logic.Liquid
 {
-    public class DateToLongStringFilter
+    public static class DateToLongStringFilter
     {
         public static string date_to_long_string(DateTime input)
         {
-            //return input.ToString("dd MMMM yyyy");
             return XmlConvert.ToString(input, "dd MMMM yyyy");
         }
 
@@ -20,7 +19,7 @@ public static string date_to_long_string(string input)
                 return date_to_long_string(inputDate);
             }
 
-            return "";
+            return string.Empty;
         }
     }
 }
diff --git a/src/Pretzel.Logic/Liquid/DateToRfc822FormatFilter.cs b/src/Pretzel.Logic/Liquid/DateToRfc822FormatFilter.cs
@@ -2,7 +2,7 @@
 
 namespace Pretzel.Logic.Liquid
 {
-    public class DateToRfc822FormatFilter
+    public static class DateToRfc822FormatFilter
     {
         public static string date_to_rfc822(DateTime input)
         {
diff --git a/src/Pretzel.Logic/Liquid/DateToStringFilter.cs b/src/Pretzel.Logic/Liquid/DateToStringFilter.cs
@@ -2,7 +2,7 @@
 
 namespace Pretzel.Logic.Liquid
 {
-    public class DateToStringFilter
+    public static class DateToStringFilter
     {
         public static string date_to_string(DateTime input)
         {
diff --git a/src/Pretzel.Logic/Liquid/DateToXmlSchemaFilter.cs b/src/Pretzel.Logic/Liquid/DateToXmlSchemaFilter.cs
@@ -3,7 +3,7 @@
 
 namespace Pretzel.Logic.Liquid
 {
-    public class DateToXmlSchemaFilter
+    public static class DateToXmlSchemaFilter
     {
         public static string date_to_xmlschema(DateTime input)
         {
diff --git a/src/Pretzel.Logic/Liquid/NumberOfWordsFilter.cs b/src/Pretzel.Logic/Liquid/NumberOfWordsFilter.cs
@@ -2,7 +2,7 @@
 
 namespace Pretzel.Logic.Liquid
 {
-    public class NumberOfWordsFilter
+    public static class NumberOfWordsFilter
     {
         public static string number_of_words(string input)
         {
diff --git a/src/Pretzel.Logic/Liquid/UriEscapeFilter.cs b/src/Pretzel.Logic/Liquid/UriEscapeFilter.cs
@@ -1,8 +1,8 @@
-using System;
+﻿using System;
 
 namespace Pretzel.Logic.Liquid
 {
-    public class UriEscapeFilter
+    public static class UriEscapeFilter
     {
         public static string uri_escape(string input)
         {
diff --git a/src/Pretzel.Logic/Minification/FileSystemExtensions.cs b/src/Pretzel.Logic/Minification/FileSystemExtensions.cs
@@ -10,10 +10,8 @@ public static class FileSystemExtensions
     {
         public static string BundleFiles(this IFileSystem fileSystem, IEnumerable<FileInfo> filePaths)
         {
-            var outputCss = new StringBuilder();
-
-            filePaths.Select(file => fileSystem.File.ReadAllText(file.FullName))
-                .Aggregate(outputCss, (builder, val) => builder.Append(val + "\n"));
+            var outputCss = filePaths.Select(file => fileSystem.File.ReadAllText(file.FullName))
+                .Aggregate(new StringBuilder(), (builder, val) => builder.Append(val + "\n"));
 
             return outputCss.ToString();
         }
diff --git a/src/Pretzel.Logic/Templating/Context/PathExtensions.cs b/src/Pretzel.Logic/Templating/Context/PathExtensions.cs
@@ -1,4 +1,5 @@
 ﻿using System;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 
@@ -11,7 +12,7 @@ public static class PathExtensions
 
         public static bool IsMarkdownFile(this string extension)
         {
-            return MarkdownFiles.Contains(extension.ToLower());
+            return MarkdownFiles.Contains(extension.ToLower(CultureInfo.InvariantCulture));
         }
 
         public static bool IsRazorFile(this string extension)
@@ -26,7 +27,7 @@ public static string ToRelativeFile(this string path)
 
         public static bool IsImageFormat(this string extension)
         {
-            return ImageFiles.Contains(extension.ToLower());
+            return ImageFiles.Contains(extension.ToLower(CultureInfo.InvariantCulture));
         }
     }
 }
diff --git a/src/Pretzel.Logic/Templating/Context/SiteContextGenerator.cs b/src/Pretzel.Logic/Templating/Context/SiteContextGenerator.cs
@@ -233,7 +233,7 @@ private Page CreatePage(SiteContext context, IConfiguration config, string file,
 
                 var header = scopedDefaults.Merge(content.YamlHeader());
 
-                if (header.ContainsKey("published") && header["published"].ToString().ToLower() == "false")
+                if (header.ContainsKey("published") && header["published"].ToString().ToLower(CultureInfo.InvariantCulture) == "false")
                 {
                     return null;
                 }
diff --git a/src/Pretzel.Logic/Templating/Jekyll/Includes.cs b/src/Pretzel.Logic/Templating/Jekyll/Includes.cs
@@ -1,11 +1,11 @@
-using System.IO;
+﻿using System.IO;
 using System.IO.Abstractions;
 
 namespace Pretzel.Logic.Templating.Jekyll
 {
     public class Includes : DotLiquid.FileSystems.IFileSystem
     {
-        private IFileSystem _fileSystem;
+        private readonly IFileSystem _fileSystem;
 
         public string Root { get; set; }
 
diff --git a/src/Pretzel.Logic/Templating/Jekyll/LiquidEngine.cs b/src/Pretzel.Logic/Templating/Jekyll/LiquidEngine.cs
@@ -14,9 +14,9 @@ namespace Pretzel.Logic.Templating.Jekyll
     public class LiquidEngine : JekyllEngineBase
     {
         private SiteContextDrop contextDrop;
-        private readonly Regex emHtmlRegex = new Regex(@"(?<=\{[\{\%].*?)(</?em>)(?=.*?[\%\}]\})", RegexOptions.Compiled);
+        private static readonly Regex emHtmlRegex = new Regex(@"(?<=\{[\{\%].*?)(</?em>)(?=.*?[\%\}]\})", RegexOptions.Compiled);
 
-        public LiquidEngine()
+        static LiquidEngine()
         {
             DotLiquid.Liquid.UseRubyDateFormat = true;
         }
diff --git a/src/Pretzel.Logic/Templating/Razor/RazorSiteEngine.cs b/src/Pretzel.Logic/Templating/Razor/RazorSiteEngine.cs
@@ -21,7 +21,7 @@ public class RazorSiteEngine : JekyllEngineBase
 
         private string includesPath;
 
-        private List<ITag> _allTags = new List<ITag>();
+        private readonly List<ITag> _allTags = new List<ITag>();
 
         public override void Initialize()
         {
diff --git a/src/Pretzel.Tests/Import/BloggerImportTests.cs b/src/Pretzel.Tests/Import/BloggerImportTests.cs
@@ -70,11 +70,6 @@ public class BloggerImportTests
     </entry>
 </feed>";
 
-        public BloggerImportTests()
-        {
-            //ImportContent = System.IO.File.ReadAllText(@"path-to-test-data.xml");
-        }
-
         [Fact]
         public void Posts_Are_Imported()
         {
diff --git a/src/Pretzel.Tests/Templating/Context/SiteContextGeneratorTests.cs b/src/Pretzel.Tests/Templating/Context/SiteContextGeneratorTests.cs
@@ -18,7 +18,7 @@ namespace Pretzel.Tests.Templating.Context
 {
     public class SiteContextGeneratorTests
     {
-        private readonly SiteContextGenerator generator;
+        private SiteContextGenerator generator;
         private readonly MockFileSystem fileSystem;
 
         public SiteContextGeneratorTests()
@@ -92,7 +92,7 @@ public void posts_without_front_matter_and_override_config_renders_folder()
             post.LastWriteTime = lastmod;
             fileSystem.AddFile(@"C:\TestSite\_posts\SomeFile.md", post);
 
-            var generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock("permalink: /blog/:year/:month/:day/:title.html"));
+            generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock("permalink: /blog/:year/:month/:day/:title.html"));
 
             var outputPath = string.Format("/blog/{0}/{1}",lastmod.ToString("yyyy'/'MM'/'dd"), "SomeFile.html");
 
@@ -403,7 +403,7 @@ public void CanBeIncluded_Scenarios_AreWorking()
         public void CanBeIncluded_Scenarios_Include()
         {
             // arrange
-            var generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(@"---
+            generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(@"---
 include: [_folder, .something-else, some-file.tmp, test\somefile.txt, subfolder\childfolder, anotherfolder\tempfile.tmp]
 ---"));
             Func<string, bool> function = generator.CanBeIncluded;
@@ -432,7 +432,7 @@ public void CanBeIncluded_Scenarios_Include()
         public void CanBeIncluded_Scenarios_Exclude()
         {
             // arrange
-            var generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(@"---
+            generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(@"---
 exclude: [folder, .htaccess, some-file.tmp, test\somefile.txt, subfolder\childfolder, anotherfolder\tempfile.tmp]
 ---"));
             Func <string, bool> function = generator.CanBeIncluded;
@@ -460,7 +460,7 @@ public void CanBeIncluded_Scenarios_Exclude()
         public void CanBeIncluded_Scenarios_IncludeExclude()
         {
             // arrange
-            var generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(@"include: [_folder, .something-else]
+            generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(@"include: [_folder, .something-else]
 exclude: [folder, test\somefile.txt]"));
             Func <string, bool> function = generator.CanBeIncluded;
 
@@ -801,10 +801,9 @@ public void page_with_date_in_title()
         {
             Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;
             var currentDate = new DateTime(2015, 1, 26).ToShortDateString();
-            var expectedContent = string.Format(@"---
+            var expectedContent = @"---
 param: value
----# Title",
-            currentDate);
+---# Title";
             var filePath = string.Format(@"C:\TestSite\{0}-SomeFile.md", currentDate.Replace("/", "-"));
             fileSystem.AddFile(filePath, new MockFileData(expectedContent));
 
@@ -825,10 +824,9 @@ public void page_with_date_in_title()
         public void page_with_false_date_in_title()
         {
             var currentDate = new DateTime(2015, 1, 26).ToShortDateString();
-            var expectedContent = string.Format(@"---
+            var expectedContent = @"---
 param: value
----# Title",
-            currentDate);
+---# Title";
             var lastmod = new DateTime(2012,03,12);
             var filePath = string.Format(@"C:\TestSite\{0}SomeFile.md", currentDate.Replace("/", "-"));
             var file = new MockFileData(expectedContent);
@@ -905,10 +903,9 @@ public void post_with_date_in_title()
         {
             Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;
             var currentDate = new DateTime(2015, 1, 26).ToShortDateString();
-            var expectedContent = string.Format(@"---
+            var expectedContent = @"---
 param: value
----# Title",
-            currentDate);
+---# Title";
             var filePath = string.Format(@"C:\TestSite\_posts\{0}-SomeFile.md", currentDate.Replace("/", "-"));
             fileSystem.AddFile(filePath, new MockFileData(expectedContent));
 
@@ -931,10 +928,9 @@ public void post_with_false_date_in_title()
             Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;
             var lastmod = new DateTime(2011,10,11);
             var currentDate = new DateTime(2015, 1, 26).ToShortDateString();
-            var expectedContent = string.Format(@"---
+            var expectedContent = @"---
 param: value
----# Title",
-            currentDate);
+---# Title";
             var filePath = string.Format(@"C:\TestSite\_posts\{0}SomeFile.md", currentDate.Replace("/", "-"));
             var file = new MockFileData(expectedContent);
             file.LastWriteTime = lastmod;
@@ -1013,7 +1009,7 @@ public void file_with_1_ioexception_on_ReadAllText_is_processed()
             fileSystemSubstitute.Directory.Returns(directorySubstitute);
             fileSystemSubstitute.FileInfo.Returns(fileInfoFactorySubstitute);
 
-            var generator = new SiteContextGenerator(fileSystemSubstitute, new LinkHelper(), new Configuration());
+            generator = new SiteContextGenerator(fileSystemSubstitute, new LinkHelper(), new Configuration());
 
             // act
             var siteContext = generator.BuildContext(@"C:\TestSite", @"C:\TestSite\_site", false);
@@ -1104,7 +1100,7 @@ public void permalink_with_folder_categories()
         [Fact]
         public void permalink_with_folder_categories_frontmatter_only()
         {
-            var generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(@"only_frontmatter_categories: true"));
+            generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(@"only_frontmatter_categories: true"));
             fileSystem.AddFile(@"C:\TestSite\foo\bar\_posts\2015-03-09-SomeFile.md", new MockFileData(@"---
 categories: [cat1, cat2]
 ---# Title"));
@@ -1133,7 +1129,7 @@ public void permalink_with_folder_categories_frontmatter_only()
         [Theory]
         public void permalink_is_well_formatted(string permalink, string expectedUrl, string categories)
         {
-            var generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(string.Format("permalink: {0}", permalink)));
+            generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(string.Format("permalink: {0}", permalink)));
             fileSystem.AddFile(@"C:\TestSite\_posts\2015-03-09-foobar-baz.md", new MockFileData(string.Format(@"---
 categories: [{0}]
 ---# Title", categories)));
@@ -1147,7 +1143,7 @@ public void permalink_is_well_formatted(string permalink, string expectedUrl, st
         [Fact]
         public void permalink_supports_custom_slug()
         {
-            var generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(string.Format("permalink: {0}", "/:year-:month-:day/:slug.html")));
+            generator = new SiteContextGenerator(fileSystem, new LinkHelper(), new ConfigurationMock(string.Format("permalink: {0}", "/:year-:month-:day/:slug.html")));
             fileSystem.AddFile(@"C:\TestSite\_posts\2015-03-09-foobar-baz.md", new MockFileData(@"---
 slug: my-slug
 ---# Title"));
diff --git a/src/Pretzel.Tests/Templating/Jekyll/LiquidEngineTests.cs b/src/Pretzel.Tests/Templating/Jekyll/LiquidEngineTests.cs
@@ -2211,7 +2211,7 @@ public void Page_should_contain_custom_tag()
 
             public class CustomTag : DotLiquid.Tag, ITag
             {
-                private SiteContext _siteContext;
+                private readonly SiteContext _siteContext;
 
                 public new string Name { get { return "Custom"; } }
 
diff --git a/src/Pretzel/Commands/CommandCollection.cs b/src/Pretzel/Commands/CommandCollection.cs
diff --git a/src/Pretzel/Commands/HungryCommand.cs b/src/Pretzel/Commands/HungryCommand.cs
diff --git a/src/Pretzel/Commands/TemplateEngineCollection.cs b/src/Pretzel/Commands/TemplateEngineCollection.cs
diff --git a/src/Pretzel/Program.cs b/src/Pretzel/Program.cs
diff --git a/src/Pretzel/WebHost/WebHost.cs b/src/Pretzel/WebHost/WebHost.cs

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public decimal Port`
`78`	`78`
`79`	`79`	`private OptionSet Settings { get; set; }`
`80`	`80`
`81`		`- private IFileSystem fileSystem;`
	`81`	`+ private readonly IFileSystem fileSystem;`
`82`	`82`
`83`	`83`	`public void Parse(IEnumerable<string> arguments)`
`84`	`84`	`{`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace Pretzel.Logic.Extensibility.Extensions`
`10`	`10`	`public class PostUrlTag : DotLiquid.Tag, ITag`
`11`	`11`	`{`
`12`	`12`	`private string _postFileName;`
`13`		`- private SiteContext _siteContext;`
	`13`	`+ private readonly SiteContext _siteContext;`
`14`	`14`
`15`	`15`	`public new string Name { get { return "PostUrl"; } }`
`16`	`16`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`		`-using System.Text.RegularExpressions;`
	`1`	`+using System.Globalization;`
	`2`	`+using System.Text.RegularExpressions;`
`2`	`3`
`3`	`4`	`namespace Pretzel.Logic.Extensibility.Extensions`
`4`	`5`	`{`
`@@ -11,7 +12,7 @@ public string Name`
`11`	`12`
`12`	`13`	`public static string Slugify(string input)`
`13`	`14`	`{`
`14`		`- var str = input.ToLower().Trim('.', ' ');`
	`15`	`+ var str = input.ToLower(CultureInfo.InvariantCulture).Trim('.', ' ');`
`15`	`16`
`16`	`17`	`str = str.Replace("#", "sharp").Replace('.', '-');`
`17`	`18`	`// invalid chars, make into spaces`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ namespace Pretzel.Logic.Extensibility`
`7`	`7`	`[InheritedExport]`
`8`	`8`	`public abstract class TagFactoryBase : DotLiquid.ITagFactory`
`9`	`9`	`{`
`10`		`- private string _tageName;`
	`10`	`+ private readonly string _tageName;`
`11`	`11`
`12`	`12`	`protected SiteContext SiteContext { get; private set; }`
`13`	`13`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.Collections.Generic;`
`3`		`-using System.IO;`
`4`	`3`	`using System.IO.Abstractions;`
`5`	`4`	`using System.Linq;`
`6`	`5`
`@@ -532,7 +531,7 @@ public static string MimeType(this string filename)`
`532`	`531`	`{`
`533`	`532`	`if (!filename.Contains("."))`
`534`	`533`	`return "text/html";`
`535`		`- string extension = filename.Substring(filename.LastIndexOf("."));`
	`534`	`+ string extension = filename.Substring(filename.LastIndexOf(".", StringComparison.InvariantCulture));`
`536`	`535`	`return Get(extension, types["bin"]);`
`537`	`536`	`}`
`538`	`537`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`		`-using System;`
	`1`	`+using System;`
`2`	`2`
`3`	`3`	`namespace Pretzel.Logic.Liquid`
`4`	`4`	`{`
`5`		`- public class CgiEscapeFilter`
	`5`	`+ public static class CgiEscapeFilter`
`6`	`6`	`{`
`7`	`7`	`public static string cgi_escape(string input)`
`8`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -3,11 +3,10 @@`
`3`	`3`
`4`	`4`	`namespace Pretzel.Logic.Liquid`
`5`	`5`	`{`
`6`		`- public class DateToLongStringFilter`
	`6`	`+ public static class DateToLongStringFilter`
`7`	`7`	`{`
`8`	`8`	`public static string date_to_long_string(DateTime input)`
`9`	`9`	`{`
`10`		`- //return input.ToString("dd MMMM yyyy");`
`11`	`10`	`return XmlConvert.ToString(input, "dd MMMM yyyy");`
`12`	`11`	`}`
`13`	`12`
`@@ -20,7 +19,7 @@ public static string date_to_long_string(string input)`
`20`	`19`	`return date_to_long_string(inputDate);`
`21`	`20`	`}`
`22`	`21`
`23`		`- return "";`
	`22`	`+ return string.Empty;`
`24`	`23`	`}`
`25`	`24`	`}`
`26`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Pretzel.Logic.Liquid`
`4`	`4`	`{`
`5`		`- public class DateToRfc822FormatFilter`
	`5`	`+ public static class DateToRfc822FormatFilter`
`6`	`6`	`{`
`7`	`7`	`public static string date_to_rfc822(DateTime input)`
`8`	`8`	`{`