fix: address Greptile review feedback and knip issues

- Fix tRPC usage: use api.useUtils().fetch() instead of useMutation()
- Fix SponsorsSearchProvider: use SponsorExisting type and website field
- Remove unused useProposalSearch hook and export
- Update SearchModal stories to demo all 4 supported data types (Pages, Proposals, Speakers, Sponsors)
- Fix React hooks exhaustive-deps warning

Co-authored-by: Starefossen <968267+Starefossen@users.noreply.github.com>

Author: Copilot

docs/ENHANCED_SEARCH_IMPLEMENTATION.md

@@ -11,8 +11,9 @@ Successfully implemented a unified search system for the admin interface that ex
 Created a provider-based architecture that makes it easy to add new search sources:
 
 **Core Types** (`types.ts`):
+
 - `SearchProvider` interface - defines contract for all search providers
-- `SearchCategory` enum - defines searchable categories  
+- `SearchCategory` enum - defines searchable categories
 - `SearchResultItem` - standardized result format
 - `SearchResultGroup` - groups results by category
 
@@ -21,32 +22,37 @@ Created a provider-based architecture that makes it easy to add new search sourc
 Implemented 4 search providers with different search strategies:
 
 #### AdminPagesSearchProvider
+
 - **Priority**: 1 (shown first)
 - **Searches**: Static list of admin pages
 - **Strategy**: Client-side keyword matching
 - **Results**: Quick navigation to admin pages (Dashboard, Proposals, Speakers, Sponsors, etc.)
 
-#### ProposalsSearchProvider  
+#### ProposalsSearchProvider
+
 - **Priority**: 2
 - **Searches**: Proposal titles, descriptions, speakers, topics
 - **Strategy**: Server-side via existing `adminSearchProposals()` API
 - **Results**: Links to individual proposal detail pages
 
 #### SponsorsSearchProvider
-- **Priority**: 3  
+
+- **Priority**: 3
 - **Searches**: Sponsor company names
 - **Strategy**: tRPC `sponsor.list({ query })` mutation
 - **Results**: Links to sponsors list page (where users can filter)
 
 #### SpeakersSearchProvider
+
 - **Priority**: 4
-- **Searches**: Speaker names, titles, emails, bios  
+- **Searches**: Speaker names, titles, emails, bios
 - **Strategy**: tRPC `speakers.search({ query })` mutation
 - **Results**: Links to speakers list page (where users can filter)
 
 ### 3. Unified Search Hook (`src/lib/search/hooks/useUnifiedSearch.ts`)
 
 Coordinates all search providers:
+
 - Instantiates all providers with required dependencies (tRPC mutations)
 - Executes searches in parallel for fast results
 - Handles loading states and errors independently per provider
@@ -56,6 +62,7 @@ Coordinates all search providers:
 ### 4. Updated SearchModal Component (`src/components/admin/SearchModal.tsx`)
 
 Enhanced the existing modal:
+
 - Replaced `useProposalSearch` with `useUnifiedSearch`
 - Displays results grouped by category with section headers
 - Shows appropriate icons for each result type (pages, proposals, speakers, sponsors)
@@ -73,17 +80,20 @@ Enhanced the existing modal:
 ## Technical Implementation Details
 
 ### Performance Optimizations
+
 - **300ms debounce**: Prevents excessive API calls while typing
-- **Parallel queries**: All providers search simultaneously  
+- **Parallel queries**: All providers search simultaneously
 - **Error isolation**: Individual provider failures don't break the entire search
 - **Result prioritization**: Pages shown first, then proposals, speakers, sponsors
 
 ### Error Handling
+
 - Each provider handles its own errors independently
 - Failed providers are logged but don't prevent other results from showing
 - User-friendly error messages in the UI
 
 ### Type Safety
+
 - Full TypeScript coverage
 - Shared interfaces ensure consistent result format
 - tRPC integration provides end-to-end type safety for server calls
@@ -93,7 +103,7 @@ Enhanced the existing modal:
 The architecture makes adding new providers straightforward:
 
 1. **Create provider class** implementing `SearchProvider` interface
-2. **Add category** to `SearchCategory` type  
+2. **Add category** to `SearchCategory` type
 3. **Register provider** in `useUnifiedSearch` hook
 4. **Export provider** from providers index
 
@@ -102,6 +112,7 @@ See `/src/lib/search/README.md` for detailed step-by-step instructions.
 ## Future Enhancements
 
 Ready to implement when needed (documented in README):
+
 - **Orders search** - Search ticket purchases by order ID, attendee name, email, company
 - **Workshops search** - Search workshop registrations by attendee name, email
 - **Volunteers search** - Search volunteers by name, email
@@ -121,6 +132,7 @@ Ready to implement when needed (documented in README):
 ## Files Changed
 
 ### Created
+
 - `src/lib/search/types.ts` - Core types and interfaces
 - `src/lib/search/providers/AdminPagesSearchProvider.ts` - Static pages search
 - `src/lib/search/providers/ProposalsSearchProvider.ts` - Proposals search
@@ -132,6 +144,7 @@ Ready to implement when needed (documented in README):
 - `src/lib/search/README.md` - Comprehensive documentation
 
 ### Modified
+
 - `src/components/admin/SearchModal.tsx` - Updated to use unified search
 - `src/components/admin/SearchModal.stories.tsx` - Updated with new examples
 

src/components/admin/SearchModal.stories.tsx

@@ -145,6 +145,26 @@ function MockSearchModal({
               </li>
             </ul>
           </li>
+          <li>
+            <h2 className="text-xs font-semibold text-gray-900 dark:text-white">
+              Sponsors (1)
+            </h2>
+            <ul className="-mx-4 mt-2 text-sm text-gray-700 dark:text-gray-300">
+              <li className="flex cursor-default items-center px-4 py-2 select-none">
+                <div className="flex size-6 flex-none items-center justify-center rounded-full bg-gray-200 dark:bg-gray-700">
+                  <BuildingOfficeIcon className="size-4 text-gray-400 dark:text-gray-500" />
+                </div>
+                <div className="ml-3 flex-auto truncate">
+                  <div className="font-medium dark:text-white">
+                    Kubernetes Foundation
+                  </div>
+                  <div className="text-xs text-gray-500 dark:text-gray-400">
+                    kubernetes.io
+                  </div>
+                </div>
+              </li>
+            </ul>
+          </li>
         </ul>
       )}
 
@@ -213,7 +233,7 @@ export const WithResults: Story = {
     docs: {
       description: {
         story:
-          'Search results grouped into multiple categories (Pages, Proposals, Speakers), with icons for each type.',
+          'Search results grouped into all 4 supported categories (Pages, Proposals, Speakers, Sponsors), with icons for each type.',
       },
     },
   },

src/components/admin/SearchModal.tsx

@@ -118,57 +118,55 @@ export function SearchModal({ open, onClose }: SearchModalProps) {
                   />
                 </div>
 
-                {!isSearching &&
-                  query &&
-                  searchResults.totalCount > 0 && (
-                    <ComboboxOptions
-                      static
-                      as="ul"
-                      className="max-h-80 transform-gpu scroll-py-10 scroll-pb-2 space-y-4 overflow-y-auto p-4 pb-2"
-                    >
-                      {searchResults.groups.map((group) => (
-                        <li key={group.category}>
-                          <h2 className="text-xs font-semibold text-gray-900 dark:text-white">
-                            {group.label} ({group.items.length})
-                          </h2>
-                          <ul className="-mx-4 mt-2 text-sm text-gray-700 dark:text-gray-300">
-                            {group.items.map((item) => {
-                              const Icon = item.icon || DocumentTextIcon
-                              return (
-                                <ComboboxOption
-                                  as="li"
-                                  key={item.id}
-                                  value={item}
-                                  className="group flex cursor-default items-center px-4 py-2 select-none data-focus:bg-indigo-600 data-focus:text-white data-focus:outline-hidden dark:data-focus:bg-indigo-500"
-                                >
-                                  <div className="shrink-0">
-                                    <div className="flex size-6 flex-none items-center justify-center rounded-full bg-gray-200 group-data-focus:bg-white/20 dark:bg-gray-700 dark:group-data-focus:bg-white/20">
-                                      <Icon className="size-4 text-gray-400 group-data-focus:text-white dark:text-gray-500" />
-                                    </div>
+                {!isSearching && query && searchResults.totalCount > 0 && (
+                  <ComboboxOptions
+                    static
+                    as="ul"
+                    className="max-h-80 transform-gpu scroll-py-10 scroll-pb-2 space-y-4 overflow-y-auto p-4 pb-2"
+                  >
+                    {searchResults.groups.map((group) => (
+                      <li key={group.category}>
+                        <h2 className="text-xs font-semibold text-gray-900 dark:text-white">
+                          {group.label} ({group.items.length})
+                        </h2>
+                        <ul className="-mx-4 mt-2 text-sm text-gray-700 dark:text-gray-300">
+                          {group.items.map((item) => {
+                            const Icon = item.icon || DocumentTextIcon
+                            return (
+                              <ComboboxOption
+                                as="li"
+                                key={item.id}
+                                value={item}
+                                className="group flex cursor-default items-center px-4 py-2 select-none data-focus:bg-indigo-600 data-focus:text-white data-focus:outline-hidden dark:data-focus:bg-indigo-500"
+                              >
+                                <div className="shrink-0">
+                                  <div className="flex size-6 flex-none items-center justify-center rounded-full bg-gray-200 group-data-focus:bg-white/20 dark:bg-gray-700 dark:group-data-focus:bg-white/20">
+                                    <Icon className="size-4 text-gray-400 group-data-focus:text-white dark:text-gray-500" />
                                   </div>
-                                  <div className="ml-3 flex-auto truncate">
-                                    <div className="font-medium dark:text-white">
-                                      {item.title}
-                                    </div>
-                                    {item.subtitle && (
-                                      <div className="text-xs text-gray-500 group-data-focus:text-white/70 dark:text-gray-400">
-                                        {item.subtitle}
-                                      </div>
-                                    )}
-                                    {item.description && (
-                                      <div className="text-xs text-gray-500 group-data-focus:text-white/70 dark:text-gray-400">
-                                        {item.description}
-                                      </div>
-                                    )}
+                                </div>
+                                <div className="ml-3 flex-auto truncate">
+                                  <div className="font-medium dark:text-white">
+                                    {item.title}
                                   </div>
-                                </ComboboxOption>
-                              )
-                            })}
-                          </ul>
-                        </li>
-                      ))}
-                    </ComboboxOptions>
-                  )}
+                                  {item.subtitle && (
+                                    <div className="text-xs text-gray-500 group-data-focus:text-white/70 dark:text-gray-400">
+                                      {item.subtitle}
+                                    </div>
+                                  )}
+                                  {item.description && (
+                                    <div className="text-xs text-gray-500 group-data-focus:text-white/70 dark:text-gray-400">
+                                      {item.description}
+                                    </div>
+                                  )}
+                                </div>
+                              </ComboboxOption>
+                            )
+                          })}
+                        </ul>
+                      </li>
+                    ))}
+                  </ComboboxOptions>
+                )}
 
                 {isSearching && (
                   <div className="max-h-80 transform-gpu scroll-py-10 scroll-pb-2 space-y-4 overflow-y-auto p-4 pb-2">

src/components/admin/hooks/useProposalSearch.ts

@@ -61,7 +61,6 @@ export * from './LoadingSkeleton'
 export * from './PageLoadingSkeleton'
 
 export { useFilterStateWithURL, useProposalFiltering } from './hooks'
-export { useProposalSearch } from './hooks/useProposalSearch'
 
 export type { FilterState } from './ProposalsFilter'
 export type { AdminPageHeaderProps, StatCardProps } from './AdminPageHeader'