fix: remove capacity requirement from user-facing workshop proposal schema (#356)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Starefossen <968267+Starefossen@users.noreply.github.com>

Author: Copilot

__tests__/lib/proposal/schemas.test.ts

@@ -121,19 +121,19 @@ describe('ProposalInputSchema (strict)', () => {
     expect(result.success).toBe(false)
   })
 
-  it('requires capacity for workshop formats', () => {
+  it('accepts workshop format with capacity', () => {
     const result = ProposalInputSchema.safeParse({
       ...fullProposal,
       format: Format.workshop_120,
+      capacity: 30,
     })
-    expect(result.success).toBe(false)
+    expect(result.success).toBe(true)
   })
 
-  it('accepts workshop format with capacity', () => {
+  it('accepts workshop format without capacity', () => {
     const result = ProposalInputSchema.safeParse({
       ...fullProposal,
       format: Format.workshop_120,
-      capacity: 30,
     })
     expect(result.success).toBe(true)
   })

__tests__/lib/proposal/validation.test.ts

@@ -103,42 +103,6 @@ describe('validateProposalForm', () => {
     expect(errors.tos).toBe(PROPOSAL_VALIDATION_MESSAGES.TOS_REQUIRED)
   })
 
-  it('returns capacity error for workshop_120 without capacity', () => {
-    const errors = validateProposalForm(
-      makeValidProposal({ format: Format.workshop_120 }),
-    )
-    expect(errors.capacity).toBe(PROPOSAL_VALIDATION_MESSAGES.CAPACITY_REQUIRED)
-  })
-
-  it('returns capacity error for workshop_240 without capacity', () => {
-    const errors = validateProposalForm(
-      makeValidProposal({ format: Format.workshop_240 }),
-    )
-    expect(errors.capacity).toBe(PROPOSAL_VALIDATION_MESSAGES.CAPACITY_REQUIRED)
-  })
-
-  it('accepts workshop format with capacity', () => {
-    const errors = validateProposalForm(
-      makeValidProposal({ format: Format.workshop_120, capacity: 30 }),
-    )
-    expect(errors.capacity).toBeUndefined()
-  })
-
-  it('does not return capacity error for non-workshop formats', () => {
-    const errors = validateProposalForm(
-      makeValidProposal({ format: Format.presentation_40 }),
-    )
-    expect(errors.capacity).toBeUndefined()
-  })
-
-  it('suppresses capacity check when requireCapacity is false', () => {
-    const errors = validateProposalForm(
-      makeValidProposal({ format: Format.workshop_120 }),
-      { requireCapacity: false },
-    )
-    expect(errors.capacity).toBeUndefined()
-  })
-
   it('returns multiple errors simultaneously', () => {
     const errors = validateProposalForm(
       makeValidProposal({

src/lib/proposal/validation.ts

@@ -1,4 +1,4 @@
-import { ProposalInput, isWorkshopFormat } from './types'
+import { ProposalInput } from './types'
 
 export const PROPOSAL_VALIDATION_MESSAGES = {
   TITLE_REQUIRED: 'Title is required',
@@ -9,20 +9,12 @@ export const PROPOSAL_VALIDATION_MESSAGES = {
   TOPICS_REQUIRED: 'At least one topic is required',
   SPEAKERS_REQUIRED: 'At least one speaker is required',
   TOS_REQUIRED: 'You must accept the terms of service',
-  CAPACITY_REQUIRED: 'Workshop capacity is required for workshop formats',
 } as const
 
-export interface ProposalValidationOptions {
-  requireSpeakers?: boolean
-  requireCapacity?: boolean
-}
-
 export function validateProposalForm(
   proposal: ProposalInput,
-  options: ProposalValidationOptions = {},
 ): Record<string, string> {
   const errors: Record<string, string> = {}
-  const { requireCapacity = true } = options
 
   if (!proposal.title || proposal.title.trim() === '') {
     errors.title = PROPOSAL_VALIDATION_MESSAGES.TITLE_REQUIRED
@@ -52,23 +44,14 @@ export function validateProposalForm(
     errors.tos = PROPOSAL_VALIDATION_MESSAGES.TOS_REQUIRED
   }
 
-  // Workshop-specific validation
-  if (
-    requireCapacity &&
-    isWorkshopFormat(proposal.format) &&
-    !proposal.capacity
-  ) {
-    errors.capacity = PROPOSAL_VALIDATION_MESSAGES.CAPACITY_REQUIRED
-  }
-
   return errors
 }
 
 export function validateProposalForAdmin(
   proposal: ProposalInput,
   speakerIds: string[],
 ): Record<string, string> {
-  const errors = validateProposalForm(proposal, { requireSpeakers: true })
+  const errors = validateProposalForm(proposal)
 
   if (!speakerIds || speakerIds.length === 0) {
     errors.speakers = PROPOSAL_VALIDATION_MESSAGES.SPEAKERS_REQUIRED

src/server/schemas/proposal.ts

@@ -69,18 +69,6 @@ const ProposalInputBaseSchema = z.object({
 
 // Proposal input schema (for create/update)
 export const ProposalInputSchema = ProposalInputBaseSchema.refine(
-  (data) => {
-    // Workshop formats require capacity
-    if (isWorkshopFormat(data.format) && !data.capacity) {
-      return false
-    }
-    return true
-  },
-  {
-    message: 'Workshop capacity is required for workshop formats',
-    path: ['capacity'],
-  },
-).refine(
   (data) => {
     // Prerequisites should only be provided for workshop formats
     if (data.prerequisites && !isWorkshopFormat(data.format)) {