Update merge_notification_subscription_provider_ct

Author: Ostap-Zherebetskyi

scripts/remove_after_use/merge_notification_subscription_provider_ct.py

@@ -7,6 +7,11 @@
 from django.contrib.contenttypes.models import ContentType
 from framework.celery_tasks import app as celery_app
 from osf.models import NotificationSubscription
+from django.db.models import Exists, OuterRef
+from celery.utils.log import get_task_logger
+
+logger = get_task_logger(__name__)
+
 
 
 @celery_app.task(name='scripts.remove_after_use.merge_notification_subscription_provider_ct')
@@ -19,13 +24,37 @@ def merge_notification_subscription_provider_ct():
         ContentType.objects.get_by_natural_key('osf', 'registrationprovider'),
         ContentType.objects.get_by_natural_key('osf', 'collectionprovider'),
     ]
-    subscriptions = NotificationSubscription.objects.filter(
-        content_type__in=provider_ct_list
-    )
-    subscriptions.update(
+
+    provider_ct_ids = [ct.id for ct in provider_ct_list]
+
+    abstract_qs = NotificationSubscription.objects.filter(
         content_type=abstract_provider_ct
     )
 
+    duplicates = NotificationSubscription.objects.filter(
+        content_type_id__in=provider_ct_ids
+    ).annotate(
+        abstract_exists=Exists(
+            abstract_qs.filter(
+                notification_type_id=OuterRef('notification_type_id'),
+                user_id=OuterRef('user_id'),
+                object_id=OuterRef('object_id'),
+                _is_digest=OuterRef('_is_digest'),
+            )
+        )
+    ).filter(abstract_exists=True)
+
+    # delete rows that would conflict
+    logger.info(f'Deleted {duplicates.count()} duplicate NotificationSubscription rows with provider content types.')
+    duplicates.delete()
+
+    # update remaining rows
+    update_qs = NotificationSubscription.objects.filter(
+        content_type_id__in=provider_ct_ids
+    )
+    logger.info(f'Updated {update_qs.count()} NotificationSubscription rows to use abstract provider content type.')
+    update_qs.update(content_type=abstract_provider_ct)
+
 
 if __name__ == '__main__':
     merge_notification_subscription_provider_ct.delay()

website/settings/defaults.py

@@ -439,9 +439,6 @@ class CeleryConfig:
         'scripts.populate_new_and_noteworthy_projects',
         'website.search.elastic_search',
         'scripts.generate_sitemap',
-        'scripts.remove_after_use.populate_notification_subscriptions_node_file_updated',
-        'scripts.remove_after_use.populate_notification_subscriptions_user_global_file_updated',
-        'scripts.remove_after_use.populate_notification_subscriptions_user_global_reviews',
         'osf.management.commands.clear_expired_sessions',
         'osf.management.commands.delete_withdrawn_or_failed_registration_files',
         'osf.management.commands.migrate_pagecounter_data',
@@ -571,9 +568,6 @@ class CeleryConfig:
         'scripts.approve_embargo_terminations',
         'scripts.triggered_mails',
         'scripts.generate_sitemap',
-        'scripts.remove_after_use.populate_notification_subscriptions_node_file_updated',
-        'scripts.remove_after_use.populate_notification_subscriptions_user_global_file_updated',
-        'scripts.remove_after_use.populate_notification_subscriptions_user_global_reviews',
         'scripts.premigrate_created_modified',
         'scripts.add_missing_identifiers_to_preprints',
         'osf.management.commands.clear_expired_sessions',