Simplify shortcut SSO mode check

Author: cslzchen

src/main/java/io/cos/cas/osf/authentication/support/OsfInstitutionUtils.java

@@ -37,16 +37,17 @@ public static String getInstitutionSupportEmail(final JpaOsfDao jpaOsfDao, final
     public static Map<String, String> getInstitutionLoginUrlMap(
             final JpaOsfDao jpaOsfDao,
             final String target,
-            final String institutionId,
-            boolean isShortcutSso
+            final String institutionId
     ) {
         List<OsfInstitution> institutionList = new LinkedList<>();
+        boolean isShortcutSso = false;
         if (institutionId == null || institutionId.isEmpty()) {
             institutionList = jpaOsfDao.findAllInstitutions();
         } else {
             final OsfInstitution institution = jpaOsfDao.findOneInstitutionById(institutionId);
             if (institution != null) {
                 institutionList.add(institution);
+                isShortcutSso = true;
             } else {
                 institutionList = jpaOsfDao.findAllInstitutions();
             }

src/main/java/io/cos/cas/osf/web/flow/login/OsfInstitutionLoginPreparationAction.java

@@ -71,7 +71,6 @@ protected Event doExecute(RequestContext context) {
         }
 
         String institutionId = null;
-        boolean isShortcutSsoMode = false;
         OsfCasLoginContext loginContext;
         loginContext = Optional.of(context).map(requestContext
                 -> (OsfCasLoginContext) requestContext.getFlowScope().get(PARAMETER_LOGIN_CONTEXT)).orElse(null);
@@ -82,7 +81,6 @@ protected Event doExecute(RequestContext context) {
                 context.getFlowScope().put(PARAMETER_LOGIN_CONTEXT, loginContext);
                 institutionId = null;
             } else {
-                isShortcutSsoMode = true;
                 final String institutionSupportEmail = OsfInstitutionUtils.getInstitutionSupportEmail(jpaOsfDao, institutionId);
                 if (institutionSupportEmail != null) {
                     loginContext.setInstitutionSupportEmail(institutionSupportEmail);
@@ -91,7 +89,7 @@ protected Event doExecute(RequestContext context) {
         }
 
         final Map<String, String> institutionLoginUrlMap
-                = OsfInstitutionUtils.getInstitutionLoginUrlMap(jpaOsfDao, target, institutionId, isShortcutSsoMode);
+                = OsfInstitutionUtils.getInstitutionLoginUrlMap(jpaOsfDao, target, institutionId);
         final Map<String, String> institutionLoginUrlMapSorted;
         if (institutionId != null) {
             institutionLoginUrlMapSorted = institutionLoginUrlMap;