fix(lint): fixed lint issues

Author: nsemets

src/app/features/preprints/components/preprint-details/preprint-make-decision/preprint-make-decision.component.ts

@@ -228,18 +228,17 @@ export class PreprintMakeDecisionComponent {
   }
 
   submit() {
-    // Don't remove comments
     const preprint = this.preprint();
     if (!preprint) return;
 
-    let trigger = '';
+    let trigger;
     if (preprint.reviewsState !== ReviewsState.Pending && this.commentEdited() && !this.decisionChanged()) {
       // If the submission is not pending,
       // the decision has not changed and the comment is edited.
       // the trigger would be 'edit_comment'
       trigger = 'edit_comment';
     } else {
-      let actionType = '';
+      let actionType;
       if (preprint.isPublished && this.isPendingWithdrawal()) {
         // if the submission is published and is pending withdrawal.
         // actionType would be 'reject'
@@ -262,7 +261,7 @@ export class PreprintMakeDecisionComponent {
       trigger = this.decision() === ReviewsState.Accepted ? 'accept' : actionType;
     }
 
-    let comment: StringOrNull = '';
+    let comment: StringOrNull;
 
     if (this.isPendingWithdrawal()) {
       if (trigger === 'reject') {

src/app/shared/pipes/citation-format.pipe.ts

@@ -16,14 +16,11 @@ export class CitationFormatPipe implements PipeTransform {
     const middleInitials = this.getInitials(user.middleNames);
     const suffix = user.suffix ? `, ${this.formatSuffix(user.suffix)}` : '';
 
-    let cite = '';
-
-    if (format === 'apa') {
-      const initials = [this.getInitials(givenName), middleInitials].filter(Boolean).join(' ');
-      cite = `${familyName}, ${initials}${suffix}`;
-    } else {
-      cite = `${familyName}, ${givenName} ${middleInitials}${suffix}`.trim();
-    }
+    const initials = [this.getInitials(givenName), middleInitials].filter(Boolean).join(' ');
+    const cite =
+      format === 'apa'
+        ? `${familyName}, ${initials}${suffix}`
+        : `${familyName}, ${givenName} ${middleInitials}${suffix}`.trim();
 
     return cite.endsWith('.') ? cite : `${cite}.`;
   }

src/app/shared/services/csl-style-manager.service.ts

@@ -95,7 +95,7 @@ export class CslStyleManagerService {
           const config = Cite.plugins.config.get('@csl');
           config.templates.add(styleId, cslXml);
         } catch (error) {
-          throw new Error(`Failed to register CSL style ${styleId}: ${error?.toString()}`);
+          throw new Error(`Failed to register CSL style ${styleId}: ${String(error)}`, { cause: error });
         }
       })
     );

src/app/shared/services/datacite/datacite.service.spec.ts

@@ -65,7 +65,7 @@ function assertSendBeacon(
   doi: string,
   event: DataciteEvent
 ) {
-  expect(navigator.sendBeacon).toBeCalledTimes(1);
+  expect(navigator.sendBeacon).toHaveBeenCalledTimes(1);
   expect(navigator.sendBeacon).toHaveBeenCalledWith(
     dataciteTrackerAddress,
     JSON.stringify({
@@ -87,6 +87,7 @@ describe('DataciteService', () => {
   const dataciteTrackerRepoId = 'repo-123';
   describe('with proper configuration', () => {
     beforeEach(() => {
+      sentry = {} as jest.Mocked<any>;
       Object.defineProperty(navigator, 'sendBeacon', {
         configurable: true,
         value: jest.fn(() => false),