fix(search-results-container): added data attribute for resource card

Author: nsemets

src/app/shared/components/search-results-container/search-results-container.component.html

@@ -110,8 +110,12 @@ <h4 class="result-count">
         } @else {
           <div class="flex flex-column gap-4">
             @if (resources().length > 0) {
-              @for (item of resources(); track $index) {
-                <osf-resource-card [resource]="item" [provider]="provider()" />
+              @for (item of resources(); track item.absoluteUrl) {
+                <osf-resource-card
+                  [resource]="item"
+                  [provider]="provider()"
+                  [attr.data-test-search-result-card]="item.id || item.absoluteUrl"
+                />
               }
 
               <div class="flex column-gap-2 w-full justify-content-center pt-2">

src/app/shared/components/search-results-container/search-results-container.component.ts

@@ -69,9 +69,7 @@ export class SearchResultsContainerComponent {
   readonly searchSortingOptions = searchSortingOptions;
   readonly ResourceType = ResourceType;
 
-  readonly hasSelectedOptions = computed(() => {
-    return Object.values(this.selectedOptions()).length > 0;
-  });
+  readonly hasSelectedOptions = computed(() => Object.values(this.selectedOptions()).length > 0);
 
   readonly hasFilters = computed(() => this.filters().length > 0);
   filtersComponent = contentChild<TemplateRef<unknown>>('filtersComponent');

src/app/shared/mappers/search/search.mapper.ts

@@ -31,8 +31,12 @@ export function MapResources(indexCardSearchResponseJsonApi: IndexCardSearchResp
     const searchResultItem = searchResultItems.find(
       (searchResult) => searchResult.relationships.indexCard.data.id === indexCard.id
     )!;
+
+    const absoluteUrl = resourceMetadata['@id'];
+
     resources.push({
-      absoluteUrl: resourceMetadata['@id'],
+      id: absoluteUrl.split('/').filter(Boolean).pop() ?? '',
+      absoluteUrl,
       resourceType: ResourceType[resourceMetadata.resourceType[0]['@id'] as keyof typeof ResourceType],
       name: resourceMetadata.name?.[0]?.['@value'],
       title: replaceBadEncodedChars(resourceMetadata.title?.[0]?.['@value']),

src/app/shared/models/search/resource.model.ts

@@ -4,6 +4,7 @@ import { StringOrNull } from '@osf/shared/helpers/types.helper';
 import { DiscoverableFilter } from './discoverable-filter.model';
 
 export interface ResourceModel {
+  id?: string;
   absoluteUrl: string;
   resourceType: ResourceType;
   name?: string;

src/testing/mocks/resource.mock.ts

@@ -3,6 +3,7 @@ import { ResourceType } from '@shared/enums/resource-type.enum';
 import { ResourceModel } from '@shared/models/search/resource.model';
 
 export const MOCK_RESOURCE: ResourceModel = {
+  id: 'resource-123',
   absoluteUrl: 'https://api.osf.io/v2/resources/resource-123',
   resourceType: ResourceType.Registration,
   title: 'Test Resource',
@@ -44,6 +45,7 @@ export const MOCK_RESOURCE: ResourceModel = {
 };
 
 export const MOCK_AGENT_RESOURCE: ResourceModel = {
+  id: 'user-123',
   absoluteUrl: 'https://api.osf.io/v2/users/user-123',
   resourceType: ResourceType.Agent,
   title: 'Test User',