fix(dialog-service): updated dialog services

Author: nsemets

src/app/features/project/project-addons/services/addon-dialog.service.ts

@@ -35,6 +35,11 @@ export class AddonDialogService {
       },
     });
 
+    if (!dialogRef) {
+      const errorMessage = this.translateService.instant('common.errorMessages.dialogOpenError');
+      throw new Error(errorMessage);
+    }
+
     return dialogRef.onClose;
   }
 
@@ -57,6 +62,11 @@ export class AddonDialogService {
       },
     });
 
+    if (!dialogRef) {
+      const errorMessage = this.translateService.instant('common.errorMessages.dialogOpenError');
+      throw new Error(errorMessage);
+    }
+
     return dialogRef.onClose;
   }
 }

src/app/shared/services/custom-dialog.service.ts

@@ -27,6 +27,13 @@ export class CustomDialogService {
       header: config?.header ? this.translateService.instant(config.header) : undefined,
     };
 
-    return this.dialogService.open(component, finalConfig);
+    const dialogRef = this.dialogService.open(component, finalConfig);
+
+    if (!dialogRef) {
+      const errorMessage = this.translateService.instant('common.errorMessages.dialogOpenError');
+      throw new Error(errorMessage);
+    }
+
+    return dialogRef;
   }
 }

src/assets/i18n/en.json

@@ -173,7 +173,8 @@
       "viewOnlyLinksBanner": "You are viewing OSF through a view-only link, which may limit the data you have permission to see."
     },
     "errorMessages": {
-      "serverError": "An unexpected error occurred. Please try again later."
+      "serverError": "An unexpected error occurred. Please try again later.",
+      "dialogOpenError": "Failed to open dialog."
     }
   },
   "navigation": {