Refactoring: Always require passing all BitmapCroppingWorkerJob.Result parameters & use more named arguments. (#511)

Author: vanniktech

cropper/src/main/kotlin/com/canhub/cropper/BitmapCroppingWorkerJob.kt

@@ -74,11 +74,17 @@ internal class BitmapCroppingWorkerJob(
             }
             else -> {
               onPostExecute(
-                Result(bitmap = null, sampleSize = 1),
+                Result(
+                  bitmap = null,
+                  uri = null,
+                  error = null,
+                  sampleSize = 1,
+                ),
               )
               return@launch
             }
           }
+
           val resizedBitmap = BitmapUtils.resizeBitmap(
             bitmap = bitmapSampled.bitmap,
             reqWidth = reqWidth,
@@ -100,13 +106,19 @@ internal class BitmapCroppingWorkerJob(
                 bitmap = resizedBitmap,
                 uri = newUri,
                 sampleSize = bitmapSampled.sampleSize,
+                error = null,
               ),
             )
           }
         }
       } catch (throwable: Exception) {
         onPostExecute(
-          Result(error = throwable, sampleSize = 1),
+          Result(
+            bitmap = null,
+            uri = null,
+            error = throwable,
+            sampleSize = 1,
+          ),
         )
       }
     }
@@ -134,11 +146,11 @@ internal class BitmapCroppingWorkerJob(
 
   internal data class Result(
     /** The cropped bitmap. */
-    val bitmap: Bitmap? = null,
+    val bitmap: Bitmap?,
     /** The saved cropped bitmap uri. */
-    val uri: Uri? = null,
+    val uri: Uri?,
     /** The error that occurred during async bitmap cropping. */
-    val error: Exception? = null,
+    val error: Exception?,
     /** Sample size used creating the crop bitmap to lower its size. */
     val sampleSize: Int,
   )

cropper/src/main/kotlin/com/canhub/cropper/CropImageView.kt

@@ -930,16 +930,16 @@ class CropImageView @JvmOverloads constructor(
     val listener = mOnCropImageCompleteListener
     if (listener != null) {
       val cropResult = CropResult(
-        originalBitmap,
-        imageUri,
-        result.bitmap,
-        result.uri,
-        result.error,
-        cropPoints,
-        cropRect,
-        wholeImageRect,
-        rotatedDegrees,
-        result.sampleSize,
+        originalBitmap = originalBitmap,
+        originalUri = imageUri,
+        bitmap = result.bitmap,
+        uriContent = result.uri,
+        error = result.error,
+        cropPoints = cropPoints,
+        cropRect = cropRect,
+        wholeImageRect = wholeImageRect,
+        rotation = rotatedDegrees,
+        sampleSize = result.sampleSize,
       )
       listener.onCropImageComplete(this, cropResult)
     }