add integration tests

Author: emathew5

src/controller/registry-org.controller/index.js

@@ -541,7 +541,7 @@ router.post('/registryOrg/:shortname/user',
   // // mw.onlyOrgWithPartnerRole,
   mw.onlySecretariat,
   param(['shortname']).isString().trim().notEmpty().isLength({ min: CONSTANTS.MIN_SHORTNAME_LENGTH, max: CONSTANTS.MAX_SHORTNAME_LENGTH }),
-  body(['cve_program_org_membership']).optional().custom(isFlatStringArray), // TO-DO: implement custom(mw.isCveProgramOrgMembershipObject),
+  // body(['cve_program_org_membership']).optional().custom(isFlatStringArray), // TO-DO: implement custom(mw.isCveProgramOrgMembershipObject),
   body(
     [
       'user_id',
@@ -558,10 +558,8 @@ router.post('/registryOrg/:shortname/user',
     ])
     .default('')
     .isString(),
-  body(['org_affiliations'])
-    .optional()
-    .custom(isFlatStringArray)
-    .customSanitizer(toUpperCaseArray),
+  body(['org_affiliations']) // TO-DO
+    .optional(),
   body(['authority.active_roles'])
     .optional()
     .custom(isFlatStringArray)

test/integration-tests/org/postRegistryOrgUsers.js

@@ -0,0 +1,110 @@
+/* eslint-disable no-unused-expressions */
+const chai = require('chai')
+chai.use(require('chai-http'))
+const expect = chai.expect
+const _ = require('lodash')
+
+const constants = require('../constants.js')
+const app = require('../../../src/index.js')
+
+describe('Testing user can be created by org with /registryOrg endpoint', () => {
+  context('Positive Tests', () => {
+    it('Allows creation of user by org', async () => {
+    // Create a new org
+      await chai.request(app)
+        .post('/api/registryOrg')
+        .set(constants.headers)
+        .send({ long_name: 'Test Registry Create Org', short_name: 'testOrg' })
+
+      const payload = {
+        user_id: 'fakeregistryuser999',
+        name: {
+          first: 'TestFirstName',
+          last: 'FakeLastName',
+          middle: 'Cool',
+          suffix: 'Mr.'
+        },
+        authority: {
+          active_roles: ['CNA']
+        }
+      }
+
+      // Create a new user by org
+      const res = await chai
+        .request(app)
+        .post('/api/registryOrg/testOrg/user')
+        .set(constants.headers)
+        .send(payload)
+
+      expect(res).to.have.status(200)
+      expect(res.body).to.have.property('message', `${payload.user_id} was successfully created.`)
+      expect(res.body).to.have.property('created').that.is.an('object')
+
+      const created = res.body.created
+      expect(created).to.include({
+        user_id: payload.user_id
+      })
+      expect(created.name).to.deep.include({
+        first: payload.name.first,
+        last: payload.name.last,
+        middle: payload.name.middle,
+        suffix: payload.name.suffix
+      })
+
+      expect(created).to.have.property('UUID').that.is.a('string')
+      expect(created).to.have.property('last_active', null)
+      expect(created).to.have.property('deactivation_date', null)
+      expect(created).to.have.property('org_affiliations')
+      expect(created.org_affiliations[0]).to.have.nested.property('org_id')
+    })
+  })
+  context('Negative Tests', () => {
+    it('Fails creation of user for nonSecretariat role', async () => {
+      const payload = {
+        user_id: 'fakeregistryuser999',
+        name: {
+          first: 'TestFirstName',
+          last: 'FakeLastName',
+          middle: 'Cool',
+          suffix: 'Mr.'
+        },
+        authority: {
+          active_roles: ['CNA']
+        }
+      }
+      await chai
+        .request(app)
+        .post('/api/registryOrg/testOrg/user')
+        .set(constants.nonSecretariatUserHeaders)
+        .send(payload)
+        .then((res, err) => {
+          expect(res).to.have.status(403)
+          expect(res.body.error).to.equal('SECRETARIAT_ONLY')
+        // expect(res.body.error).to.equal('NOT_ORG_ADMIN_OR_SECRETARIAT') // Will be this error when validation is fixed
+        })
+    })
+    it('Fails creation of user if they exist', async () => {
+      const payload = {
+        user_id: 'fakeregistryuser999',
+        name: {
+          first: 'TestFirstName',
+          last: 'FakeLastName',
+          middle: 'Cool',
+          suffix: 'Mr.'
+        },
+        authority: {
+          active_roles: ['CNA']
+        }
+      }
+      await chai
+        .request(app)
+        .post('/api/registryOrg/testOrg/user')
+        .set(constants.headers)
+        .send(payload)
+        .then((res, err) => {
+          expect(res).to.have.status(400)
+          expect(res.body.error).to.equal('USER_EXISTS')
+        })
+    })
+  })
+})