Debugged Interval::operator!=

Author: Kalashnikovni

sbg/interval.cpp

@@ -93,18 +93,18 @@ bool operator==(const Interval& lhs, const Interval& rhs)
 bool operator!=(const Interval& lhs, const Interval& rhs)
 {
   if (lhs.begin() != rhs.begin()) {
-    return false;
+    return true;
   }
 
   if (lhs.step() != rhs.step()) {
-    return false;
+    return true;
   }
 
   if (lhs.end() != rhs.end()) {
-    return false;
+    return true;
   }
 
-  return true;
+  return false;
 }
 
 bool Interval::operator<(const Interval& other) const

sbg/map.cpp

@@ -166,8 +166,7 @@ Set Map::lessImage(const Map& other) const
   }
 
   Set result = detail::MapDetail::lessImage(_law, other._law);
-  result = std::move(result).intersection(cap_dom);
-  return result;
+  return result.intersection(cap_dom);
 }
 
 Map Map::minAdj(const Map& other) const

sbg/multidim_inter.cpp

@@ -224,10 +224,10 @@ MaybeMDI MultiDimInter::compact(const MultiDimInter& other) const
   for (; j < arity(); ++j) {
     Interval jth_this = operator[](j);
     Interval jth_other = other[j];
-    MaybeInterval jth_compact = jth_this.compact(jth_other);
     if (jth_this == jth_other) {
       result.pushBack(jth_this);
     } else {
+      MaybeInterval jth_compact = jth_this.compact(jth_other);
       if (jth_compact) {
         result.pushBack(jth_compact.value());
         ++j;