Skip to content

Commit b4eea77

Browse files
committed
fix: catch unknown error type in TUI component error handlers
CloneRepo, Install, and FileCleanup all assumed .catch received an Error instance. If a non-Error value is rejected, error.message would be undefined. Now catches unknown and derives a safe message string.
1 parent 73d35d3 commit b4eea77

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

source/components/steps/CloneRepo/CloneRepo.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ const CloneRepo: FC<Props> = ({ projectName, onCompletion }) => {
1818
setStatus('done')
1919
onCompletion()
2020
})
21-
.catch((error: Error) => {
21+
.catch((error: unknown) => {
2222
setStatus('error')
23-
setErrorMessage(error.message)
23+
setErrorMessage(error instanceof Error ? error.message : String(error))
2424
})
2525
}, [projectName, onCompletion])
2626

source/components/steps/FileCleanup.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ const FileCleanup: FC<Props> = ({ onCompletion, installationConfig, projectName
2929
setStatus('done')
3030
onCompletion()
3131
})
32-
.catch((error: Error) => {
32+
.catch((error: unknown) => {
3333
setStatus('error')
34-
setErrorMessage(error.message)
34+
setErrorMessage(error instanceof Error ? error.message : String(error))
3535
})
3636
}, [projectFolder, installationType, selectedFeatures, onCompletion])
3737

source/components/steps/Install/Install.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ const Install: FC<Props> = ({ projectName, onCompletion, installationConfig }) =
3939
setStatus('done')
4040
onCompletion()
4141
})
42-
.catch((error: Error) => {
42+
.catch((error: unknown) => {
4343
setStatus('error')
44-
setErrorMessage(error.message)
44+
setErrorMessage(error instanceof Error ? error.message : String(error))
4545
})
4646
}, [projectFolder, installationType, selectedFeatures, onCompletion])
4747

0 commit comments

Comments
 (0)