Skip to content

Commit ec3dfa4

Browse files
committed
simplify parse (possibly with performance gain)
1 parent ca3aabd commit ec3dfa4

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

src/select.jl

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -515,12 +515,9 @@ function parse_to_type(key::Keyword, val)
515515
elseif key.value_type == Char && length(val) == 1
516516
return val[1]
517517
end
518-
try
519-
val = parse(key.value_type, val)
520-
return val
521-
catch
522-
throw(ArgumentError("Could not parse $val for keyword $(key.name), expected $(key.value_type)"))
523-
end
518+
val = tryparse(key.value_type, val)
519+
isnothing(val) && throw(ArgumentError("Could not parse $val for keyword $(key.name), expected $(key.value_type)"))
520+
return val
524521
end
525522

526523
const keywords = [

0 commit comments

Comments
 (0)