Skip to content

Commit 8d20562

Browse files
committed
remove unreachable safeguards that were commented
1 parent e96b356 commit 8d20562

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

src/select.jl

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,6 @@ end
644644
# Modified parse_query_vector
645645
function parse_query_vector(s_vec_const::AbstractVector{<:AbstractString})
646646
s_vec = s_vec_const # Operate on slices or copies, not modifying original array passed around
647-
648647
if isempty(s_vec)
649648
parse_error("Empty query segment.")
650649
end
@@ -694,9 +693,6 @@ function parse_query_vector(s_vec_const::AbstractVector{<:AbstractString})
694693

695694
# Base case: No top-level logical operators. Must be a keyword phrase.
696695
else
697-
#if isempty(s_vec) # Should not happen if initial checks are correct
698-
# parse_error("Unexpected empty query segment.")
699-
#end
700696
token_keyword_name = s_vec[begin]
701697

702698
# Standard Keywords (e.g., "name", "resnum", "index")
@@ -733,13 +729,6 @@ function parse_query_vector(s_vec_const::AbstractVector{<:AbstractString})
733729
# keyword_args will be ["<", "13"]. The Keyword functor handles this structure.
734730
return key_obj(keyword_args)
735731
else
736-
# Case: Not a recognized "keyword operator value" structure.
737-
# This implies implicit equality: "keyword value" or "keyword value1 value2 ..." (for OR expansion).
738-
739-
#if isempty(keyword_args) # Should have been caught by length(s_vec) == 1
740-
# parse_error("No arguments provided for keyword '$(key_obj.name)'.") # Should be unreachable
741-
#end
742-
743732
# Sanity check for multi-value: ensure no operators are present in the value list.
744733
# E.g. "resnum 10 < 20" is an error here because "10" is not an operator,
745734
# but "<" appears later in a context expecting only values.

0 commit comments

Comments
 (0)