clean unused state properties

Author: BenjaminCanape

lib/data/repositories/friend_request_repository_impl.dart

@@ -1,11 +1,11 @@
 import 'package:hooks_riverpod/hooks_riverpod.dart';
-import '../../domain/entities/page.dart';
-import '../api/friend_request_api.dart';
-import '../../domain/entities/enum/friend_request_status.dart';
-import '../../domain/repositories/friend_request_repository.dart';
 
+import '../../domain/entities/enum/friend_request_status.dart';
 import '../../domain/entities/friend_request.dart';
+import '../../domain/entities/page.dart';
 import '../../domain/entities/user.dart';
+import '../../domain/repositories/friend_request_repository.dart';
+import '../api/friend_request_api.dart';
 
 /// Provider for the FriendRequestRepository implementation.
 final friendRequestRepositoryProvider =

lib/presentation/common/activity/view_model/activity_item_interaction_view_model.dart

@@ -1,4 +1,5 @@
 import 'package:hooks_riverpod/hooks_riverpod.dart';
+
 import 'state/activity_item_interaction_state.dart';
 
 /// Provider for the activity item interaction view model.

lib/presentation/common/activity/view_model/activity_list_view_model.dart

@@ -1,7 +1,6 @@
 import 'package:flutter/material.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 
-import '../../../../domain/entities/activity.dart';
 import 'state/activity_list_state.dart';
 
 /// Provider for the activity list view model.
@@ -20,23 +19,6 @@ class ActivityListWidgetViewModel
   ActivityListWidgetViewModel(this.ref, this.listId)
       : super(ActivityListWidgetState.initial());
 
-  /// Sets the position in the state
-  void setScrollPosition(double position) {
-    state = state.copyWith(position: position);
-  }
-
-  void setGroupedActivities(List<List<Activity>> activities, int total) {
-    state = state.copyWith(groupedActivities: activities, total: total);
-  }
-
-  void setNbOfElements(int nbOfElements) {
-    state = state.copyWith(nbOfElements: nbOfElements);
-  }
-
-  void isLoading(bool loading) {
-    state = state.copyWith(isLoading: loading);
-  }
-
   int calculateTotalElements(List<dynamic> listOfLists) {
     int totalElements =
         listOfLists.fold(0, (sum, list) => sum + (list.length as int));

lib/presentation/common/activity/view_model/state/activity_list_state.dart

@@ -2,45 +2,17 @@ import '../../../../../domain/entities/activity.dart';
 
 /// The state class for activity list.
 class ActivityListWidgetState {
-  final double scrollPosition;
-  final int pageNumber;
-  final int total;
-  final int nbOfElements;
-  final bool isLoading;
   final List<List<Activity>> groupedActivities;
 
-  const ActivityListWidgetState(
-      {required this.scrollPosition,
-      required this.pageNumber,
-      required this.total,
-      required this.nbOfElements,
-      required this.isLoading,
-      required this.groupedActivities});
+  const ActivityListWidgetState({required this.groupedActivities});
 
   /// Factory method to create the initial state.
   factory ActivityListWidgetState.initial() {
-    return const ActivityListWidgetState(
-        scrollPosition: 0,
-        pageNumber: 0,
-        total: 0,
-        nbOfElements: 0,
-        isLoading: false,
-        groupedActivities: []);
+    return const ActivityListWidgetState(groupedActivities: []);
   }
 
-  ActivityListWidgetState copyWith(
-      {double? position,
-      int? pageNumber,
-      int? total,
-      int? nbOfElements,
-      bool? isLoading,
-      List<List<Activity>>? groupedActivities}) {
+  ActivityListWidgetState copyWith({List<List<Activity>>? groupedActivities}) {
     return ActivityListWidgetState(
-        scrollPosition: position ?? scrollPosition,
-        isLoading: isLoading ?? this.isLoading,
-        pageNumber: pageNumber ?? this.pageNumber,
-        total: total ?? this.total,
-        nbOfElements: nbOfElements ?? this.nbOfElements,
         groupedActivities: groupedActivities ?? this.groupedActivities);
   }
 }

lib/presentation/common/activity/widgets/activity_item_details.dart

@@ -1,6 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_gen/gen_l10n/app_localizations.dart';
 import 'package:intl/intl.dart';
+
 import '../../../../domain/entities/activity.dart';
 import '../../core/utils/activity_utils.dart';
 import '../../core/utils/color_utils.dart';

lib/presentation/common/user/view_model/profile_view_model.dart

@@ -24,8 +24,6 @@ class ProfileViewModel extends StateNotifier<ProfileState> {
   /// Retrieves the friendship status.
   Future<void> getFriendshipStatus(String userId) async {
     final friendRequestRepository = ref.read(friendRequestRepositoryProvider);
-    //final activityRepository = ref.read(activityRepositoryProvider);
-
     final currentUser = await StorageUtils.getUser();
 
     if (userId != currentUser?.id) {
@@ -34,16 +32,6 @@ class ProfileViewModel extends StateNotifier<ProfileState> {
     } else {
       state = state.copyWith(status: FriendRequestStatus.noDisplay);
     }
-/*
-    if (state.friendshipStatus != null &&
-        state.friendshipStatus == FriendRequestStatus.accepted) {
-      final activities = await activityRepository.getUserActivities(userId);
-      state =
-          state.copyWith(activities: activities.list, total: activities.total);
-    } else if (userId == currentUser?.id) {
-      final activities = await activityRepository.getActivities();
-      state = state.copyWith(activities: activities.list);
-    }*/
   }
 
   Future<EntityPage<Activity>> fetchActivities({int pageNumber = 0}) async {

lib/presentation/common/user/view_model/state/profile_state.dart

@@ -2,43 +2,29 @@ import 'dart:typed_data';
 
 import '../../../../../domain/entities/enum/friend_request_status.dart';
 
-import '../../../../../domain/entities/activity.dart';
-
 /// The state class for profile.
 class ProfileState {
-  final List<Activity> activities; // List of activities
-  final int total; // total of activities to display
   final bool isLoading; // Indicates if the list is currently loading
   final FriendRequestStatus? friendshipStatus; //the friend request status
   final Uint8List? profilePicture; // the profile picture
 
   const ProfileState(
-      {required this.activities,
-      required this.total,
-      required this.isLoading,
+      {required this.isLoading,
       required this.friendshipStatus,
       required this.profilePicture});
 
   /// Factory method to create the initial state.
   factory ProfileState.initial() {
     return const ProfileState(
-        activities: [],
-        total: 0,
-        isLoading: false,
-        friendshipStatus: null,
-        profilePicture: null);
+        isLoading: false, friendshipStatus: null, profilePicture: null);
   }
 
   /// Method to create a copy of the state with updated values.
   ProfileState copyWith(
-      {List<Activity>? activities, // Updated list of activities
-      int? total, // updated total
-      bool? isLoading, // Updated loading state
+      {bool? isLoading, // Updated loading state
       FriendRequestStatus? status, // Updated friend request status
       Uint8List? profilePicture}) {
     return ProfileState(
-        activities: activities ?? this.activities,
-        total: total ?? this.total,
         isLoading: isLoading ?? this.isLoading,
         friendshipStatus: status ?? friendshipStatus,
         profilePicture: profilePicture ?? this.profilePicture);

lib/presentation/community/view_model/community_view_model.dart

@@ -1,4 +1,6 @@
 import 'package:hooks_riverpod/hooks_riverpod.dart';
+import '../../common/core/enums/infinite_scroll_list.enum.dart';
+import '../../common/core/widgets/view_model/infinite_scroll_list_view_model.dart';
 
 import '../../../data/repositories/activity_repository_impl.dart';
 import '../../../data/repositories/user_repository_impl.dart';
@@ -22,25 +24,19 @@ class CommunityViewModel extends StateNotifier<CommunityState> {
     return ref.read(userRepositoryProvider).search(text);
   }
 
-  void getMyAndMyFriendsActivities() async {
-    if (!state.isLoading) {
-      state = state.copyWith(isLoading: true);
-
-      EntityPage<Activity> newActivities = await ref
-          .read(activityRepositoryProvider)
-          .getMyAndMyFriendsActivities(pageNumber: state.pageNumber);
-      state = state.copyWith(
-          activities: [...state.activities, ...newActivities.list],
-          isLoading: false,
-          pageNumber: state.pageNumber + 1);
-    }
-  }
-
   Future<EntityPage<Activity>> getInitialMyAndMyFriendsActivities(
       {int pageNumber = 0}) async {
     EntityPage<Activity> newActivities = await ref
         .read(activityRepositoryProvider)
         .getMyAndMyFriendsActivities(pageNumber: pageNumber);
     return newActivities;
   }
+
+  void refreshList() {
+    ref
+        .read(infiniteScrollListViewModelProvider(
+                InfiniteScrollListEnum.community.toString())
+            .notifier)
+        .reset();
+  }
 }

lib/presentation/community/view_model/state/community_state.dart

@@ -1,30 +1,14 @@
-import '../../../../domain/entities/activity.dart';
-
 /// The state class for community screen.
 class CommunityState {
-  final List<Activity> activities; // List of activities
-  final bool isLoading; // Indicates if the list is currently loading
-  final int pageNumber;
-
-  const CommunityState(
-      {required this.activities,
-      required this.isLoading,
-      required this.pageNumber});
+  const CommunityState();
 
   /// Factory method to create the initial state.
   factory CommunityState.initial() {
-    return const CommunityState(
-        activities: [], isLoading: false, pageNumber: 0);
+    return const CommunityState();
   }
 
   /// Method to create a copy of the state with updated values.
-  CommunityState copyWith(
-      {List<Activity>? activities, // Updated list of activities
-      bool? isLoading, // Updated loading state
-      int? pageNumber}) {
-    return CommunityState(
-        activities: activities ?? this.activities,
-        isLoading: isLoading ?? this.isLoading,
-        pageNumber: pageNumber ?? this.pageNumber);
+  CommunityState copyWith() {
+    return const CommunityState();
   }
 }

lib/presentation/my_activities/view_model/activity_list_view_model.dart

@@ -69,9 +69,4 @@ class ActivityListViewModel extends StateNotifier<ActivityListState> {
       ),
     );
   }
-
-  /// Reload the state with new list of activities
-  void reloadActivities(List<Activity> activities) {
-    state = state.copyWith(activities: activities);
-  }
 }