Address PR review feedback for BRTC endpoints tests

- Smoke tests: Replace has_properties with individual assertions, remove
  hamcrest dependency, add assertions for links/data/errors fields and
  all properties on response objects, remove AI-generated comments,
  reuse endpoint ID from create test in delete test
- Unit API tests: Remove pagination test, required-only props test, and
  error handling test; add assertions for tag, devices, and other fields
  on mocked response data
- Unit model tests: Add missing test files for ErrorResponse, Page,
  SipConnectionMetadata, and SipCredentials models

Generated from Claude9 with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: smoghe-bw

test/smoke/test_endpoints_api.py

@@ -4,8 +4,6 @@
 import unittest
 from datetime import datetime
 
-from hamcrest import assert_that, has_properties, instance_of, equal_to, greater_than
-
 from bandwidth import ApiClient, ApiResponse, Configuration
 from bandwidth.api.endpoints_api import EndpointsApi
 from bandwidth.models.create_web_rtc_connection_request import CreateWebRtcConnectionRequest
@@ -57,22 +55,21 @@ def createEndpoint(self):
             create_request
         )
 
-        assert_that(response.status_code, equal_to(201))
-        assert_that(response.data, instance_of(CreateEndpointResponse))
-        assert_that(response.data.links, instance_of(list))
-        assert_that(len(response.data.links), equal_to(0))
-        assert_that(response.data.errors, instance_of(list))
-        assert_that(response.data.data, instance_of(CreateEndpointResponseData))
-        assert_that(response.data.data, has_properties(
-            'endpoint_id', instance_of(str),
-            'type', EndpointTypeEnum.WEBRTC,
-            'status', instance_of(EndpointStatusEnum),
-            'token', instance_of(str),
-            'creation_timestamp', instance_of(datetime),
-            'expiration_timestamp', instance_of(datetime),
-            'tag', equal_to("python-sdk-test-endpoint"),
-            'devices', instance_of(list)
-        ))
+        assert response.status_code == 201
+        assert isinstance(response.data, CreateEndpointResponse)
+        assert isinstance(response.data.links, list)
+        assert len(response.data.links) == 0
+        assert isinstance(response.data.errors, list)
+        assert len(response.data.errors) == 0
+        assert isinstance(response.data.data, CreateEndpointResponseData)
+        assert isinstance(response.data.data.endpoint_id, str)
+        assert response.data.data.type == EndpointTypeEnum.WEBRTC
+        assert isinstance(response.data.data.status, EndpointStatusEnum)
+        assert isinstance(response.data.data.token, str)
+        assert isinstance(response.data.data.creation_timestamp, datetime)
+        assert isinstance(response.data.data.expiration_timestamp, datetime)
+        assert response.data.data.tag == "python-sdk-test-endpoint"
+        assert isinstance(response.data.data.devices, list)
 
         self.__class__.endpoint_id = response.data.data.endpoint_id
 
@@ -83,68 +80,54 @@ def listEndpoints(self):
             limit=10
         )
 
-        assert_that(response.status_code, equal_to(200))
-        assert_that(response.data, instance_of(ListEndpointsResponse))
-        assert_that(response.data.links, instance_of(list))
-        assert_that(len(response.data.links), equal_to(0))
-        assert_that(response.data.errors, instance_of(list))
-        assert_that(response.data.data, instance_of(list))
-        assert_that(len(response.data.data), greater_than(0))
+        assert response.status_code == 200
+        assert isinstance(response.data, ListEndpointsResponse)
+        assert isinstance(response.data.links, list)
+        assert len(response.data.links) == 0
+        assert isinstance(response.data.errors, list)
+        assert len(response.data.errors) == 0
+        assert isinstance(response.data.data, list)
+        assert len(response.data.data) > 0
 
         listed_ids = [ep.endpoint_id for ep in response.data.data]
-        assert_that(self.endpoint_id in listed_ids, equal_to(True))
+        assert self.endpoint_id in listed_ids
 
         endpoint = response.data.data[0]
-        assert_that(endpoint, instance_of(Endpoints))
-        assert_that(endpoint, has_properties(
-            'endpoint_id', instance_of(str),
-            'type', instance_of(EndpointTypeEnum),
-            'status', instance_of(EndpointStatusEnum),
-            'creation_timestamp', instance_of(datetime),
-            'expiration_timestamp', instance_of(datetime)
-        ))
+        assert isinstance(endpoint, Endpoints)
+        assert isinstance(endpoint.endpoint_id, str)
+        assert isinstance(endpoint.type, EndpointTypeEnum)
+        assert isinstance(endpoint.status, EndpointStatusEnum)
+        assert isinstance(endpoint.creation_timestamp, datetime)
+        assert isinstance(endpoint.expiration_timestamp, datetime)
 
     def getEndpoint(self):
         response: ApiResponse = self.endpoints_api_instance.get_endpoint_with_http_info(
             self.account_id,
             self.endpoint_id
         )
 
-        assert_that(response.status_code, equal_to(200))
-        assert_that(response.data, instance_of(EndpointResponse))
-        assert_that(response.data.links, instance_of(list))
-        assert_that(len(response.data.links), equal_to(0))
-        assert_that(response.data.errors, instance_of(list))
-        assert_that(response.data.data, instance_of(Endpoint))
-        assert_that(response.data.data, has_properties(
-            'endpoint_id', equal_to(self.endpoint_id),
-            'type', EndpointTypeEnum.WEBRTC,
-            'status', instance_of(EndpointStatusEnum),
-            'creation_timestamp', instance_of(datetime),
-            'expiration_timestamp', instance_of(datetime),
-            'tag', equal_to("python-sdk-test-endpoint"),
-            'devices', instance_of(list)
-        ))
-
-    # Note: This endpoint is currently not working in the API, so this test is commented out for now. Once the API issue is resolved, this test should be uncommented and verified.
-    # def updateEndpointBxml(self):
-    #     bxml = '<?xml version="1.0" encoding="UTF-8"?><Bxml><StartStream name="test_stream"/></Bxml>'
-    #     response: ApiResponse = self.endpoints_api_instance.update_endpoint_bxml_with_http_info(
-    #         self.account_id,
-    #         self.endpoint_id,
-    #         bxml
-    #     )
-    #
-    #     assert_that(response.status_code, equal_to(204))
-    #     ...
+        assert response.status_code == 200
+        assert isinstance(response.data, EndpointResponse)
+        assert isinstance(response.data.links, list)
+        assert len(response.data.links) == 0
+        assert isinstance(response.data.errors, list)
+        assert len(response.data.errors) == 0
+        assert isinstance(response.data.data, Endpoint)
+        assert response.data.data.endpoint_id == self.endpoint_id
+        assert response.data.data.type == EndpointTypeEnum.WEBRTC
+        assert isinstance(response.data.data.status, EndpointStatusEnum)
+        assert isinstance(response.data.data.creation_timestamp, datetime)
+        assert isinstance(response.data.data.expiration_timestamp, datetime)
+        assert response.data.data.tag == "python-sdk-test-endpoint"
+        assert isinstance(response.data.data.devices, list)
 
     def deleteEndpoint(self):
         response: ApiResponse = self.endpoints_api_instance.delete_endpoint_with_http_info(
             self.account_id,
             self.endpoint_id
         )
 
-        assert_that(response.status_code, equal_to(204))
+        assert response.status_code == 204
 
     def _steps(self):
         call_order = ['createEndpoint', 'listEndpoints', 'getEndpoint', 'deleteEndpoint']
@@ -156,9 +139,7 @@ def test_steps(self):
             step()
 
     def assertApiException(self, context, expected_status_code: int):
-        assert_that(context.exception, has_properties(
-            'status', expected_status_code,
-        ))
+        assert context.exception.status == expected_status_code
 
     def test_create_endpoint_unauthorized(self):
         create_request = CreateWebRtcConnectionRequest(

test/unit/api/test_endpoints_api.py

@@ -28,7 +28,6 @@
 from bandwidth.models.endpoints import Endpoints
 from bandwidth.models.list_endpoints_response import ListEndpointsResponse
 from bandwidth.models.link import Link
-from bandwidth.models.page import Page
 from bandwidth.models.endpoint_type_enum import EndpointTypeEnum
 from bandwidth.models.endpoint_direction_enum import EndpointDirectionEnum
 from bandwidth.models.endpoint_status_enum import EndpointStatusEnum
@@ -85,6 +84,8 @@ def test_create_endpoint(self) -> None:
         assert_that(response.data.data.creation_timestamp, instance_of(datetime))
         assert_that(response.data.data.expiration_timestamp, instance_of(datetime))
         assert_that(response.data.data.token, instance_of(str))
+        assert_that(response.data.data.tag, instance_of(str))
+        assert_that(response.data.data.devices, instance_of(list))
 
         assert_that(response.data.errors, instance_of(list))
 
@@ -125,6 +126,8 @@ def test_get_endpoint(self) -> None:
         assert_that(response.data.data.status, is_in(EndpointStatusEnum))
         assert_that(response.data.data.creation_timestamp, instance_of(datetime))
         assert_that(response.data.data.expiration_timestamp, instance_of(datetime))
+        assert_that(response.data.data.tag, instance_of(str))
+        assert_that(response.data.data.devices, instance_of(list))
 
         assert_that(response.data.errors, instance_of(list))
 
@@ -155,14 +158,8 @@ def test_list_endpoints(self) -> None:
         assert_that(response.data.data[0].creation_timestamp, instance_of(datetime))
         assert_that(response.data.data[0].expiration_timestamp, instance_of(datetime))
 
-        if response.data.page:
-            assert_that(response.data.page, instance_of(Page))
-            assert_that(response.data.page.page_size, greater_than_or_equal_to(0))
-
         assert_that(response.data.errors, instance_of(list))
 
 
-
-
 if __name__ == '__main__':
     unittest.main()

test/unit/models/test_error_response.py

@@ -0,0 +1,68 @@
+# coding: utf-8
+
+"""
+    Bandwidth
+
+    Bandwidth's Communication APIs
+
+    The version of the OpenAPI document: 1.0.0
+    Contact: letstalk@bandwidth.com
+    Generated by OpenAPI Generator (https://openapi-generator.tech)
+
+    Do not edit the class manually.
+"""  # noqa: E501
+
+
+import unittest
+
+from bandwidth.models.error_response import ErrorResponse
+from bandwidth.models.error import Error
+from bandwidth.models.link import Link
+
+class TestErrorResponse(unittest.TestCase):
+    """ErrorResponse unit test stubs"""
+
+    def setUp(self):
+        pass
+
+    def tearDown(self):
+        pass
+
+    def make_instance(self, include_optional) -> ErrorResponse:
+        """Test ErrorResponse
+            include_optional is a boolean, when False only required
+            params are included, when True both required and
+            optional params are included """
+        return ErrorResponse(
+            links=[
+                Link(href='https://api.bandwidth.com/errors', rel='self')
+            ],
+            data={'key': 'value'},
+            errors=[
+                Error(
+                    code=400,
+                    description='Bad Request'
+                )
+            ]
+        )
+
+    def testErrorResponse(self):
+        """Test ErrorResponse"""
+        instance = self.make_instance(True)
+        assert instance is not None
+        assert isinstance(instance, ErrorResponse)
+        assert isinstance(instance.links, list)
+        assert len(instance.links) == 1
+        assert isinstance(instance.links[0], Link)
+        assert instance.links[0].href == 'https://api.bandwidth.com/errors'
+        assert instance.links[0].rel == 'self'
+        assert isinstance(instance.data, dict)
+        assert instance.data['key'] == 'value'
+        assert isinstance(instance.errors, list)
+        assert len(instance.errors) == 1
+        assert isinstance(instance.errors[0], Error)
+        assert instance.errors[0].code == 400
+        assert instance.errors[0].description == 'Bad Request'
+
+if __name__ == '__main__':
+    unittest.main()

test/unit/models/test_page.py

@@ -0,0 +1,57 @@
+# coding: utf-8
+
+"""
+    Bandwidth
+
+    Bandwidth's Communication APIs
+
+    The version of the OpenAPI document: 1.0.0
+    Contact: letstalk@bandwidth.com
+    Generated by OpenAPI Generator (https://openapi-generator.tech)
+
+    Do not edit the class manually.
+"""  # noqa: E501
+
+
+import unittest
+
+from bandwidth.models.page import Page
+
+class TestPage(unittest.TestCase):
+    """Page unit test stubs"""
+
+    def setUp(self):
+        pass
+
+    def tearDown(self):
+        pass
+
+    def make_instance(self, include_optional) -> Page:
+        """Test Page
+            include_optional is a boolean, when False only required
+            params are included, when True both required and
+            optional params are included """
+        if include_optional:
+            return Page(
+                page_size=10,
+                total_elements=100,
+                total_pages=10,
+                page_number=1
+            )
+        else:
+            return Page(
+                page_size=10
+            )
+
+    def testPage(self):
+        """Test Page"""
+        instance = self.make_instance(True)
+        assert instance is not None
+        assert isinstance(instance, Page)
+        assert instance.page_size == 10
+        assert instance.total_elements == 100
+        assert instance.total_pages == 10
+        assert instance.page_number == 1
+
+if __name__ == '__main__':
+    unittest.main()

test/unit/models/test_sip_connection_metadata.py

@@ -0,0 +1,61 @@
+# coding: utf-8
+
+"""
+    Bandwidth
+
+    Bandwidth's Communication APIs
+
+    The version of the OpenAPI document: 1.0.0
+    Contact: letstalk@bandwidth.com
+    Generated by OpenAPI Generator (https://openapi-generator.tech)
+
+    Do not edit the class manually.
+"""  # noqa: E501
+
+
+import unittest
+
+from bandwidth.models.sip_connection_metadata import SipConnectionMetadata
+from bandwidth.models.sip_credentials import SipCredentials
+
+class TestSipConnectionMetadata(unittest.TestCase):
+    """SipConnectionMetadata unit test stubs"""
+
+    def setUp(self):
+        pass
+
+    def tearDown(self):
+        pass
+
+    def make_instance(self, include_optional) -> SipConnectionMetadata:
+        """Test SipConnectionMetadata
+            include_optional is a boolean, when False only required
+            params are included, when True both required and
+            optional params are included """
+        if include_optional:
+            return SipConnectionMetadata(
+                ip_address='192.168.1.1',
+                port=5060,
+                credentials=SipCredentials(
+                    username='sip_user',
+                    password='sip_password'
+                ),
+                uui_header='test-uui-header'
+            )
+        else:
+            return SipConnectionMetadata()
+
+    def testSipConnectionMetadata(self):
+        """Test SipConnectionMetadata"""
+        instance = self.make_instance(True)
+        assert instance is not None
+        assert isinstance(instance, SipConnectionMetadata)
+        assert instance.ip_address == '192.168.1.1'
+        assert instance.port == 5060
+        assert isinstance(instance.credentials, SipCredentials)
+        assert instance.credentials.username == 'sip_user'
+        assert instance.credentials.password == 'sip_password'
+        assert instance.uui_header == 'test-uui-header'
+
+if __name__ == '__main__':
+    unittest.main()