Fix modified collection exception error

carlbennett · carlbennett · commit f49207209c6e · 2023-03-12T16:22:47.000-05:00
diff --git a/src/Atlasd/Battlenet/Protocols/Game/Messages/SID_GETADVLISTEX.cs b/src/Atlasd/Battlenet/Protocols/Game/Messages/SID_GETADVLISTEX.cs
@@ -60,11 +60,12 @@ public override bool Invoke(MessageContext context)
 
                         lock (Battlenet.Common.ActiveGameAds)
                         {
+                            IList<GameAd> toDelete = new List<GameAd>();
                             foreach (var gameAd in Battlenet.Common.ActiveGameAds)
                             {
                                 if (gameAd.Clients.Count == 0)
                                 {
-                                    Battlenet.Common.ActiveGameAds.Remove(gameAd);
+                                    toDelete.Add(gameAd);
                                     continue;
                                 }
 
@@ -79,6 +80,11 @@ public override bool Invoke(MessageContext context)
 
                                 gameAds.Add(gameAd);
                             }
+                            while (toDelete.Count > 0)
+                            {
+                                Battlenet.Common.ActiveGameAds.Remove(toDelete[0]);
+                                toDelete.RemoveAt(0);
+                            }
                         }
 
                         return new SID_GETADVLISTEX().Invoke(new MessageContext(context.Client, MessageDirection.ServerToClient, new Dictionary<string, dynamic>(){

Original file line number	Diff line number	Diff line change
`@@ -60,11 +60,12 @@ public override bool Invoke(MessageContext context)`
`60`	`60`
`61`	`61`	`lock (Battlenet.Common.ActiveGameAds)`
`62`	`62`	`{`
	`63`	`+ IList<GameAd> toDelete = new List<GameAd>();`
`63`	`64`	`foreach (var gameAd in Battlenet.Common.ActiveGameAds)`
`64`	`65`	`{`
`65`	`66`	`if (gameAd.Clients.Count == 0)`
`66`	`67`	`{`
`67`		`- Battlenet.Common.ActiveGameAds.Remove(gameAd);`
	`68`	`+ toDelete.Add(gameAd);`
`68`	`69`	`continue;`
`69`	`70`	`}`
`70`	`71`
`@@ -79,6 +80,11 @@ public override bool Invoke(MessageContext context)`
`79`	`80`
`80`	`81`	`gameAds.Add(gameAd);`
`81`	`82`	`}`
	`83`	`+ while (toDelete.Count > 0)`
	`84`	`+ {`
	`85`	`+ Battlenet.Common.ActiveGameAds.Remove(toDelete[0]);`
	`86`	`+ toDelete.RemoveAt(0);`
	`87`	`+ }`
`82`	`88`	`}`
`83`	`89`
`84`	`90`	`return new SID_GETADVLISTEX().Invoke(new MessageContext(context.Client, MessageDirection.ServerToClient, new Dictionary<string, dynamic>(){`