Fix Channel.Designate race condition on DesignatedHeirs

wjlafrance · claude · wjlafrance · commit dbef8863cbd6 · 2026-03-16T20:19:07.000-05:00
Designate() wrote to the dictionary without a lock while RemoveUser()
locked it, creating a data race. Add matching lock.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/Atlasd/Battlenet/Channel.cs b/src/Atlasd/Battlenet/Channel.cs
@@ -285,7 +285,10 @@ public void Close()
 
         public void Designate(GameState designator, GameState heir)
         {
-            DesignatedHeirs[designator] = heir;
+            lock (DesignatedHeirs)
+            {
+                DesignatedHeirs[designator] = heir;
+            }
         }
 
         public bool DisbandInto(Channel destination)

Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,10 @@ public void Close()`
`285`	`285`
`286`	`286`	`public void Designate(GameState designator, GameState heir)`
`287`	`287`	`{`
`288`		`- DesignatedHeirs[designator] = heir;`
	`288`	`+ lock (DesignatedHeirs)`
	`289`	`+ {`
	`290`	`+ DesignatedHeirs[designator] = heir;`
	`291`	`+ }`
`289`	`292`	`}`
`290`	`293`
`291`	`294`	`public bool DisbandInto(Channel destination)`