fix(queryrealms): edge case parsing realms when zero arguments have been passed

richard-pianka · richard-pianka · commit 1d4324b3363d · 2023-03-31T01:34:19.000-04:00
diff --git a/src/Atlasd/Battlenet/Protocols/Game/Messages/SID_QUERYREALMS2.cs b/src/Atlasd/Battlenet/Protocols/Game/Messages/SID_QUERYREALMS2.cs
@@ -42,7 +42,12 @@ public override bool Invoke(MessageContext context)
                     }
                 case MessageDirection.ServerToClient:
                     {
-                        Dictionary<byte[], byte[]> realms = context.Arguments.ContainsKey("realms") ? (Dictionary<byte[], byte[]>)context.Arguments["realms"] : new Dictionary<byte[], byte[]>();
+                        Logging.WriteLine(Logging.LogLevel.Debug, Logging.LogType.Client_Game, context.Client.RemoteEndPoint, "foobar");
+
+                        Dictionary<byte[], byte[]> realms =
+                            context.Arguments == null || !context.Arguments.ContainsKey("realms") ?
+                            new Dictionary<byte[], byte[]>() :
+                            (Dictionary<byte[], byte[]>)context.Arguments["realms"];
 
                         /**
                          * (UINT32) Unknown (0)

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,12 @@ public override bool Invoke(MessageContext context)`
`42`	`42`	`}`
`43`	`43`	`case MessageDirection.ServerToClient:`
`44`	`44`	`{`
`45`		`- Dictionary<byte[], byte[]> realms = context.Arguments.ContainsKey("realms") ? (Dictionary<byte[], byte[]>)context.Arguments["realms"] : new Dictionary<byte[], byte[]>();`
	`45`	`+ Logging.WriteLine(Logging.LogLevel.Debug, Logging.LogType.Client_Game, context.Client.RemoteEndPoint, "foobar");`
	`46`	`+`
	`47`	`+ Dictionary<byte[], byte[]> realms =`
	`48`	`+ context.Arguments == null \|\| !context.Arguments.ContainsKey("realms") ?`
	`49`	`+ new Dictionary<byte[], byte[]>() :`
	`50`	`+ (Dictionary<byte[], byte[]>)context.Arguments["realms"];`
`46`	`51`
`47`	`52`	`/**`
`48`	`53`	`* (UINT32) Unknown (0)`