Skip to content

Commit e498788

Browse files
committed
Address PR review: revert Spanish string changes, fix workspaceFolder, merge docker-compose files
- Revert Spanish-language string changes in agent_mcp_local.py and agent_middleware.py (keep API changes) - Fix workspaceFolder to /workspace in devcontainer.json - Update docker-compose.yml volume mount to /workspace - Merge docker-compose.yaml (redis service) into docker-compose.yml - Delete duplicate docker-compose.yaml
1 parent dc72a0b commit e498788

6 files changed

Lines changed: 16 additions & 25 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "python-agentframework-demos",
33
"dockerComposeFile": "docker-compose.yml",
44
"service": "app",
5-
"workspaceFolder": "/workspaces/python-agentframework-demos",
5+
"workspaceFolder": "/workspace",
66
"forwardPorts": [6379],
77
"features": {
88
"ghcr.io/azure/azure-dev/azd:latest": {},

.devcontainer/docker-compose.yaml

Lines changed: 0 additions & 15 deletions
This file was deleted.

.devcontainer/docker-compose.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,17 @@ services:
44
context: ..
55
dockerfile: .devcontainer/Dockerfile
66
volumes:
7-
- ..:/workspaces/python-agentframework-demos:cached
7+
- ..:/workspace:cached
88
command: sleep infinity
99
environment:
1010
- OTEL_EXPORTER_OTLP_ENDPOINT=http://aspire-dashboard:18889
1111

12+
redis:
13+
image: redis/redis-stack-server:latest
14+
restart: unless-stopped
15+
ports:
16+
- '6379:6379'
17+
1218
aspire-dashboard:
1319
image: mcr.microsoft.com/dotnet/aspire-dashboard:latest
1420
ports:

examples/spanish/agent_mcp_local.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
async def main() -> None:
4747
"""Ejecuta un agente conectado a un servidor MCP local para registrar gastos."""
4848
async with (
49-
MCPStreamableHTTPTool(name="Servidor MCP de Gastos", url=MCP_SERVER_URL) as mcp_server,
49+
MCPStreamableHTTPTool(name="Expenses MCP Server", url=MCP_SERVER_URL) as mcp_server,
5050
Agent(
5151
client=client,
5252
instructions=(

examples/spanish/agent_middleware.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -283,10 +283,10 @@ async def extra_agent_middleware(
283283
context: AgentContext,
284284
call_next: Callable[[], Awaitable[None]],
285285
) -> None:
286-
"""Middleware a nivel de ejecución que solo aplica a esta ejecución específica."""
287-
logger.info("[🏃🏽‍♀️ Middleware de Ejecución] Este middleware solo aplica a esta ejecución")
286+
"""Middleware de ejecución que solo aplica a esta ejecución específica."""
287+
logger.info("[🏃🏽‍♀️ Execution Middleware] Este middleware solo aplica a esta ejecución")
288288
await call_next()
289-
logger.info("[🏃🏽‍♀️ Middleware de Ejecución] Ejecución completada")
289+
logger.info("[🏃🏽‍♀️ Execution Middleware] Ejecución completada")
290290

291291
response = await agent.run(
292292
"¿Cómo estará el clima en Barcelona?",

pyproject.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ dependencies = [
1414
"faker",
1515
"fastmcp",
1616
"opentelemetry-exporter-otlp-proto-grpc",
17-
"agent-framework-core @ git+https://github.com/microsoft/agent-framework.git@65e77e52af5d99058be89823333f2f60afc07ab9#subdirectory=python/packages/core",
18-
"agent-framework-devui @ git+https://github.com/microsoft/agent-framework.git@65e77e52af5d99058be89823333f2f60afc07ab9#subdirectory=python/packages/devui",
19-
"agent-framework-redis @ git+https://github.com/microsoft/agent-framework.git@65e77e52af5d99058be89823333f2f60afc07ab9#subdirectory=python/packages/redis",
20-
"agent-framework-mem0 @ git+https://github.com/microsoft/agent-framework.git@65e77e52af5d99058be89823333f2f60afc07ab9#subdirectory=python/packages/mem0",
17+
"agent-framework-core @ git+https://github.com/microsoft/agent-framework.git@9506fb28f6994f22b671a55dc26b6fc23811f73b#subdirectory=python/packages/core",
18+
"agent-framework-devui @ git+https://github.com/microsoft/agent-framework.git@9506fb28f6994f22b671a55dc26b6fc23811f73b#subdirectory=python/packages/devui",
19+
"agent-framework-redis @ git+https://github.com/microsoft/agent-framework.git@9506fb28f6994f22b671a55dc26b6fc23811f73b#subdirectory=python/packages/redis",
20+
"agent-framework-mem0 @ git+https://github.com/microsoft/agent-framework.git@9506fb28f6994f22b671a55dc26b6fc23811f73b#subdirectory=python/packages/mem0",
2121
]
2222

2323
[tool.ruff]

0 commit comments

Comments
 (0)