Address PR review comments: json.dumps, .env.sample, date shadowing, localhost binding

Author: pamelafox

.env.sample

@@ -1,7 +1,7 @@
 # API_HOST can be either azure, openai, or github:
 API_HOST=azure
 # Configure for Azure:
-AZURE_OPENAI_ENDPOINT=https://YOUR-AZURE-OPENAI-SERVICE-NAME.openai.azure.com/openai/v1
+AZURE_OPENAI_ENDPOINT=https://YOUR-AZURE-OPENAI-SERVICE-NAME.openai.azure.com
 AZURE_OPENAI_CHAT_DEPLOYMENT=YOUR-AZURE-DEPLOYMENT-NAME
 # Configure for OpenAI.com:
 OPENAI_API_KEY=YOUR-OPENAI-KEY

.github/prompts/review_pr_comments.prompt.md

@@ -0,0 +1,136 @@
+---
+name: review_pr_comments
+description: This prompt is used to review comments on an active pull request and decide whether to accept, iterate, or reject the changes suggested in each comment.
+---
+We have received comments on the current active pull request. Together, we will go through each comment one by one and discuss whether to accept the change, iterate on it, or reject the change.
+
+## Steps to follow:
+
+1. Fetch the active pull request: If available, use the `activePullRequest` tool from the `GitHub Pull Requests` toolset to get the details of the active pull request including the comments. If not, use the GitHub MCP server or GitHub CLI to get the details of the active pull request. Fetch both top level comments and inline comments.
+2. Present a list of the comments with a one-sentence summary of each.
+3. One at a time, present each comment in full detail and ask me whether to accept, iterate, or reject the change. Provide your recommendation for each comment based on best practices, code quality, and project guidelines. Await user's decision before proceeding to the next comment. DO NOT make any changes to the code or files until I have responded with my decision for each comment.
+4. If the decision is to accept or iterate, make the necessary code changes to address the comment. If the decision is to reject, provide a brief explanation of why the change was not made.
+5. Wait for user to affirm completion of any code changes made before moving to the next comment.
+6. Reply to each comment on the pull request with the outcome of our discussion (accepted, iterated, or rejected) along with any relevant explanations.
+
+
+## How to reply to PR review comments
+
+This guide explains how to reply directly to inline review comments on GitHub pull requests.
+
+### API Endpoint
+
+To reply to an inline PR comment, use:
+
+```http
+POST /repos/{owner}/{repo}/pulls/{pull_number}/comments/{comment_id}/replies
+```
+
+With body:
+
+```json
+{
+  "body": "Your reply message"
+}
+```
+
+### Using gh CLI
+
+```bash
+gh api repos/{owner}/{repo}/pulls/{pull_number}/comments/{comment_id}/replies \
+  -X POST \
+  -f body="Your reply message"
+```
+
+### Workflow
+
+1. **Get PR comments**: First fetch the PR review comments to get their IDs:
+
+   ```bash
+   gh api repos/{owner}/{repo}/pulls/{pull_number}/comments
+   ```
+
+2. **Identify comment IDs**: Each comment has an `id` field. For threaded comments, use the root comment's `id`.
+
+3. **Post replies**: For each comment you want to reply to:
+
+   ```bash
+   gh api repos/{owner}/{repo}/pulls/{pull_number}/comments/{comment_id}/replies \
+     -X POST \
+     -f body="Fixed in commit abc123"
+   ```
+
+### Example Replies
+
+For accepted changes:
+
+- "Fixed in {commit_sha}"
+- "Accepted - fixed in {commit_sha}"
+
+For rejected changes:
+
+- "Rejected - {reason}"
+- "Won't fix - {explanation}"
+
+For questions:
+
+- "Good catch, addressed in {commit_sha}"
+
+## Notes
+
+- The `comment_id` is the numeric ID from the comment object, NOT the `node_id`
+- Replies appear as threaded responses under the original comment
+- You can reply to any comment, including bot comments (like Copilot reviews)
+
+### Resolving Conversations
+
+To resolve (mark as resolved) PR review threads, use the GraphQL API:
+
+1. **Get thread IDs**: Query for unresolved threads:
+
+   ```bash
+   gh api graphql -f query='
+   query {
+     repository(owner: "{owner}", name: "{repo}") {
+       pullRequest(number: {pull_number}) {
+         reviewThreads(first: 50) {
+           nodes {
+             id
+             isResolved
+             comments(first: 1) {
+               nodes { body path }
+             }
+           }
+         }
+       }
+     }
+   }'
+   ```
+
+2. **Resolve threads**: Use the `resolveReviewThread` mutation:
+
+   ```bash
+   gh api graphql -f query='
+   mutation {
+     resolveReviewThread(input: {threadId: "PRRT_xxx"}) {
+       thread { isResolved }
+     }
+   }'
+   ```
+
+3. **Resolve multiple threads at once**:
+
+   ```bash
+   gh api graphql -f query='
+   mutation {
+     t1: resolveReviewThread(input: {threadId: "PRRT_xxx"}) { thread { isResolved } }
+     t2: resolveReviewThread(input: {threadId: "PRRT_yyy"}) { thread { isResolved } }
+   }'
+   ```
+
+The thread ID starts with `PRRT_` and can be found in the GraphQL query response.
+
+Note: This skill can be removed once the GitHub MCP server has added built-in support for replying to PR review comments and resolving threads.
+See:
+https://github.com/github/github-mcp-server/issues/1323
+https://github.com/github/github-mcp-server/issues/1768

examples/mcp_server.py

@@ -46,7 +46,7 @@ class Category(Enum):
 
 @mcp.tool
 async def add_expense(
-    date: Annotated[date, "Date of the expense in YYYY-MM-DD format"],
+    expense_date: Annotated[date, "Date of the expense in YYYY-MM-DD format"],
     amount: Annotated[float, "Positive numeric amount of the expense"],
     category: Annotated[Category, "Category label"],
     description: Annotated[str, "Human-readable description of the expense"],
@@ -56,7 +56,7 @@ async def add_expense(
     if amount <= 0:
         return "Error: Amount must be positive"
 
-    date_iso = date.isoformat()
+    date_iso = expense_date.isoformat()
     logger.info(f"Adding expense: ${amount} for {description} on {date_iso}")
 
     try:
@@ -106,4 +106,4 @@ async def get_expenses_data() -> str:
 
 if __name__ == "__main__":
     logger.info("MCP Expenses server starting (HTTP mode on port 8000)")
-    mcp.run(transport="streamable-http", host="0.0.0.0", port=8000)
+    mcp.run(transport="streamable-http", host="127.0.0.1", port=8000)

examples/openai_tool_calling.py

@@ -84,6 +84,6 @@ def lookup_weather(city_name: str | None = None, zip_code: str | None = None) ->
     if function_name == "lookup_weather":
         messages.append(response.choices[0].message)
         result = lookup_weather(**arguments)
-        messages.append({"role": "tool", "tool_call_id": tool_call.id, "content": str(result)})
+        messages.append({"role": "tool", "tool_call_id": tool_call.id, "content": json.dumps(result)})
         response = client.chat.completions.create(model=MODEL_NAME, messages=messages, tools=tools)
         print(response.choices[0].message.content)

examples/spanish/mcp_server.py

@@ -46,7 +46,7 @@ class Categoria(Enum):
 
 @mcp.tool
 async def agregar_gasto(
-    date: Annotated[date, "Fecha del gasto en formato AAAA-MM-DD"],
+    fecha_gasto: Annotated[date, "Fecha del gasto en formato AAAA-MM-DD"],
     amount: Annotated[float, "Monto numérico positivo del gasto"],
     category: Annotated[Categoria, "Etiqueta de categoría"],
     description: Annotated[str, "Descripción legible del gasto"],
@@ -56,7 +56,7 @@ async def agregar_gasto(
     if amount <= 0:
         return "Error: El monto debe ser positivo"
 
-    date_iso = date.isoformat()
+    date_iso = fecha_gasto.isoformat()
     logger.info(f"Agregando gasto: ${amount} por {description} el {date_iso}")
 
     try:
@@ -106,4 +106,4 @@ async def obtener_datos_gastos() -> str:
 
 if __name__ == "__main__":
     logger.info("Servidor MCP de Gastos iniciando (modo HTTP en puerto 8000)")
-    mcp.run(transport="streamable-http", host="0.0.0.0", port=8000)
+    mcp.run(transport="streamable-http", host="127.0.0.1", port=8000)

examples/spanish/openai_tool_calling.py

@@ -84,6 +84,6 @@ def lookup_weather(city_name: str | None = None, zip_code: str | None = None) ->
     if function_name == "lookup_weather":
         messages.append(response.choices[0].message)
         result = lookup_weather(**arguments)
-        messages.append({"role": "tool", "tool_call_id": tool_call.id, "content": str(result)})
+        messages.append({"role": "tool", "tool_call_id": tool_call.id, "content": json.dumps(result)})
         response = client.chat.completions.create(model=MODEL_NAME, messages=messages, tools=tools)
         print(response.choices[0].message.content)