Address PR review comments

- Remove hardcoded port 8101 from workflow_magenticone.py (EN+ES)
- Revert Spanish agent/workflow names to English in workflow_fan_out_fan_in_edges, workflow_converge
- Fix Run: -> Ejecutar: in Spanish workflow_magenticone.py
- Improve summarizer comment in workflow_aggregator_summary (EN+ES)
- Fix handoff output handling with get_outputs() guard in workflow_handoffbuilder_rules (EN+ES)
- Bump max_iterations 8->20 in workflow_conditional_state (EN+ES)
- Translate 'Please add a fix' to Spanish in workflow_aggregator_voting

Author: pamelafox

AGENTS.md

@@ -37,7 +37,7 @@ Each example .py file should have a corresponding file with the same name under
 * Identifiers (functions/classes/vars): English
 * User-facing output/data (e.g., example responses, sample values): Spanish
 * HITL control words: bilingual (approve/aprobar, exit/salir)
-* Agent or workflow names: Spanish ("Escritor" instead of "Writer")
+* Agent and workflow names: English ("TravelPlannerAgent" should be the same in both versions, not "AgentePlanificadorDeViajes")
 
 Use informal (tuteo) LATAM Spanish, tu not usted, puedes not podes, etc. The content is technical so if a word is best kept in English, then do so.
 

examples/spanish/workflow_aggregator_summary.py

@@ -114,8 +114,8 @@ async def run(self, results: list[AgentExecutorResponse], ctx: WorkflowContext[N
     ),
 )
 
-# El ejecutor resumidor envuelve un Agent para manejar el fan-in directamente —
-# formatea las salidas expertas recopiladas y sintetiza un brief.
+# El ejecutor resumidor envuelve un Agent que formatea las salidas
+# expertas recopiladas y las sintetiza en un brief ejecutivo conciso.
 summarizer = SummarizerExecutor(client=client)
 
 workflow = (

examples/spanish/workflow_aggregator_voting.py

@@ -165,7 +165,7 @@ async def main() -> None:
         # Caso claro: los tres deberían coincidir
         "La app se crashea cada vez que intento subir una foto. Código de error 500.",
         # Keyword → feature_request (add, wish), Sentiment → bug (angry), Intent → bug (fix broken)
-        "Ojalá el botón de exportar funcionara. Please add a fix — ¡pierdo datos a diario!",
+        "Ojalá el botón de exportar funcionara. Por favor agrega una solución — ¡pierdo datos a diario!",
         # Keyword → bug (error, fail), Sentiment → feature_request (hopeful), Intent → feature_request (new ability)
         "La búsqueda actual falla con consultas largas — estaría increíble si pudieras agregar fuzzy matching.",
     ]

examples/spanish/workflow_conditional_state.py

@@ -140,7 +140,7 @@ async def publisher(_response: AgentExecutorResponse, ctx: WorkflowContext[Never
 # add_edge(reviewer, editor, condition=needs_revision) se activa cuando needs_revision() retorna True.
 # add_edge(editor, reviewer) crea un bucle acotado de revisión-edición.
 workflow = (
-    WorkflowBuilder(start_executor=writer, max_iterations=8)
+    WorkflowBuilder(start_executor=writer, max_iterations=20)
     .add_edge(writer, store_post_text)
     .add_edge(store_post_text, reviewer)
     .add_edge(reviewer, publisher, condition=is_approved)

examples/spanish/workflow_converge.py

@@ -63,21 +63,21 @@ def parse_review_result(message: Any) -> ReviewResult | None:
     return message.agent_response.value
 
 
-def esta_aprobado(message: Any) -> bool:
+def is_approved(message: Any) -> bool:
     """Verifica si el contenido está aprobado (alta calidad)."""
     result = parse_review_result(message)
     return result is not None and result.score >= 80
 
 
-def necesita_edicion(message: Any) -> bool:
+def needs_editing(message: Any) -> bool:
     """Enruta al editor cuando la calidad está debajo del umbral."""
     result = parse_review_result(message)
     return result is not None and result.score < 80
 
 
 writer = Agent(
     client=client,
-    name="Escritor",
+    name="Writer",
     instructions=(
         "Eres un excelente escritor de contenido. "
         "Crea contenido claro y atractivo basado en la solicitud del usuario. "
@@ -88,7 +88,7 @@ def necesita_edicion(message: Any) -> bool:
 
 reviewer = Agent(
     client=client,
-    name="Revisor",
+    name="Reviewer",
     instructions=(
         "Eres un experto revisor de contenido. "
         "Evalúa el contenido del escritor basándote en:\n"
@@ -119,7 +119,7 @@ def necesita_edicion(message: Any) -> bool:
 
 publisher = Agent(
     client=client,
-    name="Publicador",
+    name="Publisher",
     instructions=(
         "Eres un agente de publicación. "
         "Recibes contenido aprobado o editado. "
@@ -129,7 +129,7 @@ def necesita_edicion(message: Any) -> bool:
 
 summarizer = Agent(
     client=client,
-    name="Resumidor",
+    name="Summarizer",
     instructions=(
         "Eres un agente resumidor. "
         "Crea un informe de publicación final que incluya:\n"
@@ -143,13 +143,13 @@ def necesita_edicion(message: Any) -> bool:
 
 workflow = (
     WorkflowBuilder(
-        name="FlujoConvergenteContenido",
+        name="ContentConverge",
         start_executor=writer,
         description="Rutas condicionales que convergen antes del resumen final.",
     )
     .add_edge(writer, reviewer)
-    .add_edge(reviewer, publisher, condition=esta_aprobado)
-    .add_edge(reviewer, editor, condition=necesita_edicion)
+    .add_edge(reviewer, publisher, condition=is_approved)
+    .add_edge(reviewer, editor, condition=needs_editing)
     .add_edge(editor, publisher)
     .add_edge(publisher, summarizer)
     .build()

examples/spanish/workflow_fan_out_fan_in_edges.py

@@ -105,7 +105,7 @@ async def aggregate(
 
 researcher = Agent(
     client=client,
-    name="Investigador",
+    name="Researcher",
     instructions=(
         "Eres un investigador de mercado experto. "
         "Dado el prompt, proporciona insights factuales concisos, oportunidades y riesgos. "
@@ -115,7 +115,7 @@ async def aggregate(
 
 marketer = Agent(
     client=client,
-    name="Estratega",
+    name="Marketer",
     instructions=(
         "Eres un estratega de marketing. "
         "Dado el prompt, propone una propuesta de valor clara y mensajes para la audiencia. "
@@ -137,7 +137,7 @@ async def aggregate(
 
 workflow = (
     WorkflowBuilder(
-        name="AristasDispersionReunion",
+        name="FanOutFanInEdges",
         description="Explicit fan-out/fan-in using edge groups.",
         start_executor=dispatcher,
         output_executors=[aggregator],

examples/spanish/workflow_handoffbuilder_rules.py

@@ -130,7 +130,10 @@ async def main() -> None:
     logger.info("Solicitud: %s\n", request)
 
     result = await workflow.run(request)
-    print(result[-1].text)
+    # El workflow de handoff devuelve la conversación completa como list[Message]
+    for output in result.get_outputs():
+        if isinstance(output, list):
+            print(output[-1].text)
 
     if async_credential:
         await async_credential.close()

examples/spanish/workflow_magenticone.py

@@ -3,7 +3,7 @@
 Este ejemplo muestra cómo un manager Magentic coordina tres especialistas para
 crear un plan de viaje, con salida en streaming y eventos del ledger de orquestación.
 
-Run:
+Ejecutar:
     uv run examples/spanish/workflow_magenticone.py
     uv run examples/spanish/workflow_magenticone.py --devui
 """
@@ -196,6 +196,6 @@ async def main() -> None:
     if "--devui" in sys.argv:
         from agent_framework.devui import serve
 
-        serve(entities=[magentic_workflow], port=8101, auto_open=True)
+        serve(entities=[magentic_workflow], auto_open=True)
     else:
         asyncio.run(main())

examples/workflow_aggregator_summary.py

@@ -114,8 +114,8 @@ async def run(self, results: list[AgentExecutorResponse], ctx: WorkflowContext[N
     ),
 )
 
-# The summarizer Executor wraps an Agent to handle fan-in directly —
-# it formats the collected expert outputs and synthesizes a brief.
+# The summarizer Executor wraps an Agent that formats the collected
+# expert outputs and synthesizes them into a concise executive brief.
 summarizer = SummarizerExecutor(client=client)
 
 workflow = (

examples/workflow_conditional_state.py

@@ -140,7 +140,7 @@ async def publisher(response: AgentExecutorResponse, ctx: WorkflowContext[Never,
 # add_edge(reviewer, editor, condition=needs_revision) fires when needs_revision() returns True.
 # add_edge(editor, reviewer) creates a bounded revise-review loop.
 workflow = (
-    WorkflowBuilder(start_executor=writer, max_iterations=8)
+    WorkflowBuilder(start_executor=writer, max_iterations=20)
     .add_edge(writer, store_post_text)
     .add_edge(store_post_text, reviewer)
     .add_edge(reviewer, publisher, condition=is_approved)