MoreJS has issues with modded enchantments

[armuell]

Minecraft Version

1.20.1

Mod Version

0.10.1

Describe the bug!

Only Fabric was tested, two different behaviors were observed with different mods that add enchantments. No errors were shown in the log. The two issues listed below can be reproduced independently.

Issue#1: When MoreJS and Vein Mining are installed the enchantment Vein Mining is removed from the pool when using an enchanting table (and perhaps other sources as well). This can be confirmed by adding a simple debug script and attempting to enchant a golden pickaxe using a maxed out enchanting table:

MoreJSEvents.filterAvailableEnchantments((event) => {
    //event.add("veinmining:vein_mining"); // uncomment to manually adding vein_mining as workaround for this bug
    console.info('Available Enchatments:')
    event.printEnchantmentInstances(); // Simple debug function to print all enchantments with level
});

Issue#2: When MoreJS, Yttr, and Trinkets are installed the enchantments Stabilization and Springing are added to the pool for all armors and tools when they intended to be exclusive to the Cuprosteel Coil trinket item. This can be confirmed by using the same debug script as above and the unexpected behavior occurred in both the enchanting table as well as generated loot in End Cities.

Crash Report

No response

Log

No response

Additions and Modifications

Yes

Additions and Modifications Description

• Architectury [9.2.14]
• Fabric API [0.92.9+1.20.1]
• KubeJS [2001.6.5-build.26]
• MoreJS [0.10.1]
• Rhino [2001.2.3-build.10]

Issue#1

• Vein Mining [1.5.0+1.20.1]

Issue#2

• Trinkets [3.7.2]
• Yttr [9.20.1031]

Did the issue happen in singleplayer or on a server?

Singleplayer