Skip to content

Commit c2617b9

Browse files
committed
improve the framework code
1 parent 2208037 commit c2617b9

2 files changed

Lines changed: 21 additions & 21 deletions

File tree

WKWebViewJavascriptBridge/WKWebViewJavascriptBridge.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,19 +56,19 @@ public class WKWebViewJavascriptBridge: NSObject {
5656

5757
extension WKWebViewJavascriptBridge: WKWebViewJavascriptBridgeBaseDelegate {
5858
func evaluateJavascript(javascript: String) {
59-
self.webView.evaluateJavaScript(javascript, completionHandler: nil)
59+
webView.evaluateJavaScript(javascript, completionHandler: nil)
6060
}
6161
}
6262

6363
extension WKWebViewJavascriptBridge: WKScriptMessageHandler {
6464
public func userContentController(_ userContentController: WKUserContentController, didReceive message: WKScriptMessage) {
6565
if message.name == iOS_Native_InjectJavascript {
66-
// self.base.injectJavascriptFile()
67-
print("self.base.injectJavascriptFile()")
66+
// base.injectJavascriptFile()
67+
print("base.injectJavascriptFile()")
6868
}
6969

7070
if message.name == iOS_Native_FlushMessageQueue {
71-
self.flushMessageQueue()
71+
flushMessageQueue()
7272
}
7373
}
7474
}

WKWebViewJavascriptBridge/WKWebViewJavascriptBridgeBase.swift

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ public class WKWebViewJavascriptBridgeBase: NSObject {
2626
var uniqueId = 0
2727

2828
func reset() {
29-
self.startupMessageQueue = [Message]()
30-
self.responseCallbacks = [String: Callback]()
31-
self.uniqueId = 0
29+
startupMessageQueue = [Message]()
30+
responseCallbacks = [String: Callback]()
31+
uniqueId = 0
3232
}
3333

3434
func send(handlerName: String, data: Any?, callback: Callback?) {
@@ -40,17 +40,17 @@ public class WKWebViewJavascriptBridgeBase: NSObject {
4040
}
4141

4242
if callback != nil {
43-
self.uniqueId += 1
44-
let callbackID = "native_iOS_cb_\(self.uniqueId)"
45-
self.responseCallbacks[callbackID] = callback
43+
uniqueId += 1
44+
let callbackID = "native_iOS_cb_\(uniqueId)"
45+
responseCallbacks[callbackID] = callback
4646
message["callbackID"] = callbackID
4747
}
4848

49-
self.queue(message: message)
49+
queue(message: message)
5050
}
5151

5252
func flush(messageQueueString: String) {
53-
guard let messages = self.deserialize(messageJSON: messageQueueString) else {
53+
guard let messages = deserialize(messageJSON: messageQueueString) else {
5454
log(messageQueueString)
5555
return
5656
}
@@ -59,9 +59,9 @@ public class WKWebViewJavascriptBridgeBase: NSObject {
5959
log(message)
6060

6161
if let responseID = message["responseID"] as? String {
62-
let callback = self.responseCallbacks[responseID]
62+
let callback = responseCallbacks[responseID]
6363
callback!(message["responseData"]!)
64-
self.responseCallbacks.removeValue(forKey: responseID)
64+
responseCallbacks.removeValue(forKey: responseID)
6565
} else {
6666
var callback: Callback?
6767
if let callbackID = message["callbackID"] {
@@ -78,7 +78,7 @@ public class WKWebViewJavascriptBridgeBase: NSObject {
7878
}
7979

8080
guard let handlerName = message["handlerName"] as? String else { return }
81-
guard let handler = self.messageHandlers[handlerName] else {
81+
guard let handler = messageHandlers[handlerName] else {
8282
log("NoHandlerException, No handler for message from JS: \(message)")
8383
return
8484
}
@@ -89,20 +89,20 @@ public class WKWebViewJavascriptBridgeBase: NSObject {
8989

9090
func injectJavascriptFile() {
9191
let js = WKWebViewJavascriptBridgeJS
92-
self.delegate?.evaluateJavascript(javascript: js)
92+
delegate?.evaluateJavascript(javascript: js)
9393
}
9494

9595
// MARK: - Private
9696
private func queue(message: Message) {
97-
if self.startupMessageQueue.isEmpty {
98-
self.dispatch(message: message)
97+
if startupMessageQueue.isEmpty {
98+
dispatch(message: message)
9999
} else {
100-
self.startupMessageQueue.append(message)
100+
startupMessageQueue.append(message)
101101
}
102102
}
103103

104104
private func dispatch(message: Message) {
105-
guard var messageJSON = self.serialize(message: message, pretty: false) else { return }
105+
guard var messageJSON = serialize(message: message, pretty: false) else { return }
106106

107107
messageJSON = messageJSON.replacingOccurrences(of: "\\", with: "\\\\")
108108
messageJSON = messageJSON.replacingOccurrences(of: "\"", with: "\\\"")
@@ -115,7 +115,7 @@ public class WKWebViewJavascriptBridgeBase: NSObject {
115115

116116
let javascriptCommand = "WKWebViewJavascriptBridge._handleMessageFromiOS('\(messageJSON)');"
117117
if Thread.current.isMainThread {
118-
self.delegate?.evaluateJavascript(javascript: javascriptCommand)
118+
delegate?.evaluateJavascript(javascript: javascriptCommand)
119119
} else {
120120
DispatchQueue.main.async {
121121
self.delegate?.evaluateJavascript(javascript: javascriptCommand)

0 commit comments

Comments
 (0)