ITS MFT Time-evolving dead maps (#12644)

* ITS - Adding static part to time dead maps

* do not forward empty objects

* object validity

* cleaning

---------

Co-authored-by: Nicolo Valle <nicolo.valle@cern.ch>

Author: nicolovalle

DataFormats/Detectors/ITSMFT/common/include/DataFormatsITSMFT/TimeDeadMap.h

@@ -58,7 +58,7 @@ class TimeDeadMap
 
   void decodeMap(o2::itsmft::NoiseMap& noisemap)
   { // for static part only
-    if (mMAP_VERSION != "3") {
+    if (mMAP_VERSION == "3") {
       LOG(error) << "Trying to decode static part of deadmap version " << mMAP_VERSION << ". Not implemented, doing nothing.";
       return;
     }

Detectors/ITSMFT/common/workflow/include/ITSMFTWorkflow/DeadMapBuilderSpec.h

@@ -82,17 +82,22 @@ class ITSMFTDeadMapBuilder : public Task
 
   bool mRunMFT = false;
   bool mDoLocalOutput = false;
+  bool mSkipStaticMap = false;
   uint16_t N_CHIPS;
   uint16_t N_CHIPS_ITSIB = o2::itsmft::ChipMappingITS::getNChips(0);
   int mTFLength = 32; // TODO find utility for proper value -- o2::base::GRPGeomHelper::getNHBFPerTF() returns 128 see https://github.com/AliceO2Group/AliceO2/blob/051b56f9f136e7977e83f5d26d922db9bd6ecef5/Detectors/Base/src/GRPGeomHelper.cxx#L233 and correct also default option is getSpec
 
   uint mStepCounter = 0;
   uint mTFCounter = 0;
 
+  long mTimeStart = -1; // TODO: better to use RCT info?
+
   std::string mObjectName;
   std::string mLocalOutputDir;
 
-  std::string MAP_VERSION = "3"; // to change in case the encoding or the format change
+  std::string MAP_VERSION = "4"; // to change in case the encoding or the format change
+
+  std::vector<bool> mStaticChipStatus{};
 
   std::vector<uint16_t> mDeadMapTF{};
 

Detectors/ITSMFT/common/workflow/src/DeadMapBuilderSpec.cxx

@@ -46,22 +46,29 @@ void ITSMFTDeadMapBuilder::init(InitContext& ic)
 
   LOG(info) << "ITSMFTDeadMapBuilder init... " << mSelfName;
 
+  mTFSampling = ic.options().get<int>("tf-sampling");
+  mTFLength = ic.options().get<int>("tf-length");
+  mDoLocalOutput = ic.options().get<bool>("local-output");
+  mObjectName = ic.options().get<std::string>("outfile");
+  mLocalOutputDir = ic.options().get<std::string>("output-dir");
+  mSkipStaticMap = ic.options().get<bool>("skip-static-map");
+
+  mTimeStart = o2::ccdb::getCurrentTimestamp();
+
   if (mRunMFT) {
     N_CHIPS = o2::itsmft::ChipMappingMFT::getNChips();
   } else {
     N_CHIPS = o2::itsmft::ChipMappingITS::getNChips();
   }
 
   mDeadMapTF.clear();
-
+  mStaticChipStatus.clear();
   mMapObject.clear();
   mMapObject.setMapVersion(MAP_VERSION);
 
-  mTFSampling = ic.options().get<int>("tf-sampling");
-  mTFLength = ic.options().get<int>("tf-length");
-  mDoLocalOutput = ic.options().get<bool>("local-output");
-  mObjectName = ic.options().get<std::string>("outfile");
-  mLocalOutputDir = ic.options().get<std::string>("output-dir");
+  if (!mSkipStaticMap) {
+    mStaticChipStatus.resize(N_CHIPS, false);
+  }
 
   LOG(info) << "Sampling one TF every " << mTFSampling;
 
@@ -87,6 +94,30 @@ std::vector<uint16_t> ITSMFTDeadMapBuilder::getChipIDsOnSameCable(uint16_t chip)
 void ITSMFTDeadMapBuilder::finalizeOutput()
 {
 
+  if (!mSkipStaticMap) {
+    std::vector<uint16_t> staticmap{};
+    int staticmap_chipcounter = 0;
+    for (uint16_t el = 0; el < mStaticChipStatus.size(); el++) {
+      if (mStaticChipStatus[el]) {
+        continue;
+      }
+      staticmap_chipcounter++;
+      bool previous_dead = (el > 0 && !mStaticChipStatus[el - 1]);
+      bool next_dead = (el < mStaticChipStatus.size() - 1 && !mStaticChipStatus[el + 1]);
+      if (!previous_dead && next_dead) {
+        staticmap.push_back(el | (uint16_t)(0x8000));
+      } else if (previous_dead && next_dead) {
+        continue;
+      } else {
+        staticmap.push_back(el);
+      }
+    }
+
+    LOG(info) << "Filling static part of the map with " << staticmap_chipcounter << " dead chips, saved into " << staticmap.size() << " words";
+
+    mMapObject.fillMap(staticmap);
+  }
+
   if (mDoLocalOutput) {
     std::string localoutfilename = mLocalOutputDir + "/" + mObjectName;
     TFile outfile(localoutfilename.c_str(), "RECREATE");
@@ -151,6 +182,14 @@ void ITSMFTDeadMapBuilder::run(ProcessingContext& pc)
     }
   }
 
+  // do AND operation before unmasking the full ITS lane
+
+  if (!mSkipStaticMap) {
+    for (size_t el = 0; el < mStaticChipStatus.size(); el++) {
+      mStaticChipStatus[el] = mStaticChipStatus[el] || ChipStatus[el];
+    }
+  }
+
   // for ITS, declaring dead only chips belonging to lane with no hits
   if (!mRunMFT) {
     for (uint16_t el = N_CHIPS_ITSIB; el < ChipStatus.size(); el++) {
@@ -199,17 +238,15 @@ void ITSMFTDeadMapBuilder::run(ProcessingContext& pc)
 void ITSMFTDeadMapBuilder::PrepareOutputCcdb(DataAllocator& output)
 {
 
-  long tstart = o2::ccdb::getCurrentTimestamp();
-  long secinyear = 365L * 24 * 3600;
-  long tend = o2::ccdb::getFutureTimestamp(secinyear);
+  long tend = o2::ccdb::getCurrentTimestamp();
 
   std::map<std::string, std::string> md = {
     {"map_version", MAP_VERSION}};
 
   std::string path = mRunMFT ? "MFT/Calib/" : "ITS/Calib/";
   std::string name_str = "TimeDeadMap";
 
-  o2::ccdb::CcdbObjectInfo info((path + name_str), name_str, mObjectName, md, tstart, tend);
+  o2::ccdb::CcdbObjectInfo info((path + name_str), name_str, mObjectName, md, mTimeStart - 120 * 1000, tend + 60 * 1000);
 
   auto image = o2::ccdb::CcdbApi::createObjectImage(&mMapObject, &info);
   info.setFileName(mObjectName);
@@ -239,7 +276,11 @@ void ITSMFTDeadMapBuilder::endOfStream(EndOfStreamContext& ec)
   if (!isEnded && !mRunStopRequested) {
     LOG(info) << "endOfStream report:" << mSelfName;
     finalizeOutput();
-    PrepareOutputCcdb(ec.outputs());
+    if (mMapObject.getEvolvingMapSize() > 0) {
+      PrepareOutputCcdb(ec.outputs());
+    } else {
+      LOG(warning) << "Time-dependent dead map is empty and will not be forwarded as output";
+    }
     isEnded = true;
   }
   return;
@@ -300,6 +341,7 @@ DataProcessorSpec getITSMFTDeadMapBuilderSpec(std::string datasource, bool doMFT
     AlgorithmSpec{adaptFromTask<ITSMFTDeadMapBuilder>(datasource, doMFT)},
     Options{{"tf-sampling", VariantType::Int, 1000, {"Process every Nth TF. Selection according to first TF orbit."}},
             {"tf-length", VariantType::Int, 32, {"Orbits per TF."}},
+            {"skip-static-map", VariantType::Bool, false, {"Do not fill static part of the map."}},
             {"outfile", VariantType::String, objectname_default, {"ROOT object file name."}},
             {"local-output", VariantType::Bool, false, {"Save ROOT tree file locally."}},
             {"output-dir", VariantType::String, "./", {"ROOT tree local output directory."}}}};