DPL: fix use after free spotted by ASAN

Author: ktf

Framework/Core/src/runDataProcessing.cxx

@@ -509,6 +509,14 @@ struct ControlWebSocketHandler : public WebSocketHandler {
     ParsedConfigMatch configMatch;
     ParsedMetricMatch metricMatch;
 
+    auto doParseConfig = [](std::string const& token, ParsedConfigMatch& configMatch, DeviceInfo& info) -> bool {
+      auto ts = "                 " + token;
+      if (DeviceConfigHelper::parseConfig(ts, configMatch)) {
+        DeviceConfigHelper::processConfig(configMatch, info);
+        return true;
+      }
+      return false;
+    };
     LOG(debug3) << "Data received: " << std::string_view(frame, s);
     if (DeviceMetricsHelper::parseMetric(token, metricMatch)) {
       // We use this callback to cache which metrics are needed to provide a
@@ -517,13 +525,10 @@ struct ControlWebSocketHandler : public WebSocketHandler {
       DeviceMetricsHelper::processMetric(metricMatch, (*mContext.metrics)[mIndex], newMetricCallback);
       didProcessMetric = true;
       didHaveNewMetric |= hasNewMetric;
-    } else if (ControlServiceHelpers::parseControl(token, match)) {
-      assert(mContext.infos);
+    } else if (ControlServiceHelpers::parseControl(token, match) && mContext.infos) {
       ControlServiceHelpers::processCommand(*mContext.infos, mPid, match[1].str(), match[2].str());
-    } else if (DeviceConfigHelper::parseConfig(std::string{"                 "} + token, configMatch)) {
+    } else if (doParseConfig(token, configMatch, (*mContext.infos)[mIndex]) && mContext.infos) {
       LOG(debug2) << "Found configuration information for pid " << mPid;
-      assert(mContext.infos);
-      DeviceConfigHelper::processConfig(configMatch, (*mContext.infos)[mIndex]);
     } else {
       LOG(error) << "Unexpected control data: " << std::string_view(frame, s);
     }