TRD TRAP simulation uses OpenMP

- output tracklets are sorted by HCId
- parallelisation is done over collisions
- TODO: check hit calculation in TRAP simulation

Author: martenole

DataFormats/Detectors/TRD/include/DataFormatsTRD/Constants.h

@@ -39,6 +39,7 @@ constexpr int NROWC0 = 12;   // the number of pad rows for chambers of type C0 (
 constexpr int NROWC1 = 16;   // the number of pad rows for chambers of type C1 (installed in stack 2)
 
 constexpr int NMCMROB = 16;     // the number of MCMs per ROB
+constexpr int NMCMHCMAX = 64;   // the maximum number of MCMs for one half chamber (C1 type)
 constexpr int NMCMROBINROW = 4; // the number of MCMs per ROB in row direction
 constexpr int NMCMROBINCOL = 4; // the number of MCMs per ROB in column direction
 constexpr int NROBC0 = 6;       // the number of ROBs per C0 chamber

Detectors/TRD/base/include/TRDBase/Digit.h

@@ -63,6 +63,7 @@ class Digit
   void setADC(const gsl::span<ADC_t>& adc) { std::copy(adc.begin(), adc.end(), mADC.begin()); }
   // Get methods
   int getDetector() const { return mDetector; }
+  int getHCId() const { return mDetector * 2 + (mROB % 2); }
   int getRow() const { return FeeParam::getPadRowFromMCM(mROB, mMCM); }
   int getPad() const { return FeeParam::getPadColFromADC(mROB, mMCM, mChannel); }
   int getROB() const { return mROB; }

Detectors/TRD/simulation/src/TrapSimulator.cxx

@@ -107,6 +107,7 @@ void TrapSimulator::reset()
   //clear the adc data
   std::fill(mADCR.begin(), mADCR.end(), 0);
   std::fill(mADCF.begin(), mADCF.end(), 0);
+  std::fill(mADCDigitIndices.begin(), mADCDigitIndices.end(), -1);
 
   for (auto filterreg : mInternalFilterRegisters) {
     filterreg.ClearReg();
@@ -2069,7 +2070,8 @@ void TrapSimulator::fitTracklet()
         }
         bool printoutadcs = false;
         for (int i = 0; i < 21; i++) {
-          if (adchitbp & (1U << i)) {
+          // FIXME it can happen that there is a hit found in a channel where there is no digit provided as input. Is this expected?
+          if ((adchitbp & (1U << i)) && (mADCDigitIndices[i] >= 0)) {
             mTrackletDigitCount.back() += 1;
             mTrackletDigitIndices.push_back(mADCDigitIndices[i]);
           }

Detectors/TRD/workflow/include/TRDWorkflow/TRDTrapSimulatorSpec.h

@@ -20,6 +20,7 @@
 #include "TRDSimulation/TrapSimulator.h"
 #include "TRDSimulation/TrapConfig.h"
 #include "DataFormatsTRD/Tracklet64.h"
+#include "DataFormatsTRD/Constants.h"
 #include <SimulationDataFormat/MCCompLabel.h>
 #include <SimulationDataFormat/ConstMCTruthContainer.h>
 
@@ -41,23 +42,20 @@ class TRDDPLTrapSimulatorTask : public o2::framework::Task
 
 
  private:
-  std::array<TrapSimulator, 128> mTrapSimulator; //the up to 128 trap simulators for a single chamber
   TrapConfig* mTrapConfig = nullptr;
   unsigned long mRunNumber = 297595; //run number to anchor simulation to.
-  int mShowTrackletStats = 1;        // show some statistics for each run
   bool mEnableOnlineGainCorrection{false};
   bool mUseMC{false}; // whether or not to use MC labels
   bool mEnableTrapConfigDump{false};
   std::string mTrapConfigName;      // the name of the config to be used.
   std::string mOnlineGainTableName;
   std::unique_ptr<Calibrations> mCalib; // store the calibrations connection to CCDB. Used primarily for the gaintables in line above.
-  std::chrono::duration<double> mTrapSimTime{0}; // timer for the actual processing in the TRAP chips
 
   TrapConfig* getTrapConfig();
   void loadTrapConfig();
   void loadDefaultTrapConfig();
   void setOnlineGainTables();
-  void processTRAPchips(int currDetector, int& nTrackletsInTrigRec, std::vector<Tracklet64>& trapTrackletsAccum, o2::dataformats::MCTruthContainer<o2::MCCompLabel>& lblTracklets, const o2::dataformats::ConstMCTruthContainer<o2::MCCompLabel>* lblDigits);
+  void processTRAPchips(int& nTracklets, std::vector<Tracklet64>& trackletsAccum, std::array<TrapSimulator, constants::NMCMHCMAX>& trapSimulators, std::vector<short>& digitCounts, std::vector<int>& digitIndices);
 };
 
 o2::framework::DataProcessorSpec getTRDTrapSimulatorSpec(bool useMC);