TPC Workflow: Give a proper error when some TPC digit MC labels are missing

Author: davidrohr

DataFormats/Detectors/TPC/include/DataFormatsTPC/WorkflowHelper.h

@@ -49,7 +49,6 @@ struct getWorkflowTPCInput_ret_internal {
   std::map<int, InputRef> inputrefs;
   std::vector<o2::dataformats::ConstMCLabelContainerView> mcInputs;
   std::vector<gsl::span<const char>> inputs;
-  std::array<int, constants::MAXSECTOR> inputDigitsMCIndex;
   std::vector<o2::dataformats::ConstMCLabelContainerView> inputDigitsMC;
   std::unique_ptr<ClusterNative[]> clusterBuffer;
   ClusterNativeHelper::ConstMCLabelContainerViewWithBuffer clustersMCBuffer;
@@ -69,13 +68,17 @@ static auto getWorkflowTPCInput(o2::framework::ProcessingContext& pc, int verbos
   if (do_clusters && do_digits) {
     throw std::invalid_argument("Currently cannot process both clusters and digits");
   }
+  std::array<int, constants::MAXSECTOR> inputDigitsMCIndex;
 
   if (do_mcLabels) {
     std::vector<o2::framework::InputSpec> filter = {
       {"check", o2::framework::ConcreteDataTypeMatcher{o2::header::gDataOriginTPC, "DIGITSMCTR"}, o2::framework::Lifetime::Timeframe},
       {"check", o2::framework::ConcreteDataTypeMatcher{o2::header::gDataOriginTPC, "CLNATIVEMCLBL"}, o2::framework::Lifetime::Timeframe},
     };
     unsigned long recvMask = 0;
+    if (do_digits) {
+      std::fill(inputDigitsMCIndex.begin(), inputDigitsMCIndex.end(), -1);
+    }
     for (auto const& ref : o2::framework::InputRecordWalker(pc.inputs(), filter)) {
       auto const* sectorHeader = o2::framework::DataRefUtils::getHeader<TPCSectorHeader*>(ref);
       if (sectorHeader == nullptr) {
@@ -93,7 +96,7 @@ static auto getWorkflowTPCInput(o2::framework::ProcessingContext& pc, int verbos
       recvMask |= (sectorHeader->sectorBits & tpcSectorMask);
       retVal->internal.inputrefs[sector].labels = ref;
       if (do_digits) {
-        retVal->internal.inputDigitsMCIndex[sector] = retVal->internal.inputDigitsMC.size();
+        inputDigitsMCIndex[sector] = retVal->internal.inputDigitsMC.size();
         retVal->internal.inputDigitsMC.emplace_back(o2::dataformats::ConstMCLabelContainerView(pc.inputs().get<gsl::span<char>>(ref)));
       }
     }
@@ -104,9 +107,12 @@ static auto getWorkflowTPCInput(o2::framework::ProcessingContext& pc, int verbos
       for (unsigned int i = 0; i < constants::MAXSECTOR; i++) {
         if (tpcSectorMask & (1ul << i)) {
           if (verbosity >= 1) {
-            LOG(INFO) << "GOT MC LABELS FOR SECTOR " << i << " -> " << retVal->internal.inputDigitsMC[retVal->internal.inputDigitsMCIndex[i]].getNElements();
+            LOG(INFO) << "GOT MC LABELS FOR SECTOR " << i << " -> " << retVal->internal.inputDigitsMC[inputDigitsMCIndex[i]].getNElements();
+          }
+          if (inputDigitsMCIndex[i] == -1) {
+            throw std::runtime_error("digit mc labels missing");
           }
-          retVal->inputDigitsMCPtrs[i] = &retVal->internal.inputDigitsMC[retVal->internal.inputDigitsMCIndex[i]];
+          retVal->inputDigitsMCPtrs[i] = &retVal->internal.inputDigitsMC[inputDigitsMCIndex[i]];
         } else {
           retVal->inputDigitsMCPtrs[i] = nullptr;
         }