Skip to content

Commit 2577c69

Browse files
committed
Update integrated AGLint to v2.0.9
Merge in ADGUARD-FILTERS/vscode-adblock-syntax from update-aglint-to-v2.0.9 to master Squashed commit of the following: commit 94481a7 Author: scripthunter7 <d.tota@adguard.com> Date: Fri Apr 26 11:04:49 2024 +0200 changelog commit 62f66e1 Author: scripthunter7 <d.tota@adguard.com> Date: Fri Apr 26 11:02:25 2024 +0200 update, format bamboo specs commit 1864990 Author: scripthunter7 <d.tota@adguard.com> Date: Fri Apr 26 11:02:08 2024 +0200 update gh workflows commit ada5a35 Author: scripthunter7 <d.tota@adguard.com> Date: Fri Apr 26 11:01:45 2024 +0200 update integrated aglint
1 parent 16e8508 commit 2577c69

10 files changed

Lines changed: 63 additions & 63 deletions

File tree

.github/workflows/check.yml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Check code
22

33
env:
4-
NODE_VERSION: 18
4+
NODE_VERSION: 20
55

66
on:
77
push:
@@ -17,10 +17,10 @@ jobs:
1717
runs-on: ubuntu-latest
1818
steps:
1919
- name: Check out to repository
20-
uses: actions/checkout@v3
20+
uses: actions/checkout@v4
2121

2222
- name: Set up Node.js
23-
uses: actions/setup-node@v3
23+
uses: actions/setup-node@v4
2424
with:
2525
node-version: ${{ env.NODE_VERSION }}
2626
cache: yarn
@@ -41,12 +41,15 @@ jobs:
4141
run: yarn test
4242

4343
notify:
44-
name: Send Slack notification
45-
needs:
46-
- check_code
47-
44+
name: Send Slack notification on failure
45+
needs: check_code
46+
# Run this job only if the previous job failed and the event was triggered by the 'AdguardTeam/VscodeAdblockSyntax' repository
47+
# Note: 'always()' is needed to run the notify job even if the test job was failed
4848
if:
49-
${{ always() &&
49+
${{
50+
always() &&
51+
needs.check_code.result == 'failure' &&
52+
github.repository == 'AdguardTeam/VscodeAdblockSyntax' &&
5053
(
5154
github.event_name == 'push' ||
5255
github.event_name == 'workflow_dispatch' ||
@@ -55,14 +58,12 @@ jobs:
5558
}}
5659
runs-on: ubuntu-latest
5760
steps:
58-
- name: Conclusion
59-
uses: technote-space/workflow-conclusion-action@v3
60-
6161
- name: Send Slack notification
6262
uses: 8398a7/action-slack@v3
6363
with:
64-
status: ${{ env.WORKFLOW_CONCLUSION }}
65-
fields: workflow, repo, message, commit, author, eventName, ref
64+
status: failure
65+
fields: workflow, repo, message, commit, author, eventName, ref, job
66+
job_name: check_code
6667
env:
6768
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6869
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

.github/workflows/release.yml

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Create GitHub Release
22

33
env:
4-
NODE_VERSION: 18
4+
NODE_VERSION: 20
55

66
on:
77
push:
@@ -17,10 +17,10 @@ jobs:
1717
runs-on: ubuntu-latest
1818
steps:
1919
- name: Check out the repository
20-
uses: actions/checkout@v3
20+
uses: actions/checkout@v4
2121

2222
- name: Set up Node.js
23-
uses: actions/setup-node@v3
23+
uses: actions/setup-node@v4
2424
with:
2525
node-version: ${{ env.NODE_VERSION }}
2626
registry-url: https://registry.npmjs.org
@@ -50,7 +50,7 @@ jobs:
5050
yarn extract-changelog -e $VERSION
5151
5252
- name: Create GitHub Release
53-
uses: softprops/action-gh-release@v1
53+
uses: softprops/action-gh-release@v2
5454
with:
5555
files: |
5656
syntaxes/out/adblock.plist
@@ -63,26 +63,22 @@ jobs:
6363

6464
notify:
6565
name: Send Slack notification
66-
needs:
67-
- release
68-
66+
needs: release
67+
# Note: 'always()' is needed to run the notify job even if the test job was failed
6968
if:
70-
${{ always() &&
71-
(
72-
github.event_name == 'push' ||
73-
github.event_name == 'workflow_dispatch'
74-
)
69+
${{
70+
always() &&
71+
github.repository == 'AdguardTeam/VscodeAdblockSyntax' &&
72+
github.event_name == 'push'
7573
}}
7674
runs-on: ubuntu-latest
7775
steps:
78-
- name: Conclusion
79-
uses: technote-space/workflow-conclusion-action@v3
80-
8176
- name: Send Slack notification
8277
uses: 8398a7/action-slack@v3
8378
with:
84-
status: ${{ env.WORKFLOW_CONCLUSION }}
85-
fields: workflow, repo, message, commit, author, eventName, ref
79+
status: ${{ needs.release.result }}
80+
fields: workflow, repo, message, commit, author, eventName, ref, job
81+
job_name: release
8682
env:
8783
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8884
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog][keepachangelog], and this project adheres to [Semantic Versioning][semver].
66

7+
## 1.1.9 - 2024-04-26
8+
9+
### Changed
10+
11+
- Updated integrated [AGLint] to v2.0.9
12+
13+
714
## 1.1.8 - 2024-04-03
815

916
### Fixed

bamboo-specs/bamboo.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
---
22
!include 'test.yaml'
3-
43
---
54
!include 'increment.yaml'
6-
75
---
86
!include 'build.yaml'
9-
107
---
118
!include 'deploy.yaml'
12-
139
---
1410
!include 'permissions.yaml'

bamboo-specs/build.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ plan:
55
key: VSCODEADBLOCKSYNTAXBUILD
66
name: vscode adblock syntax - build release
77
variables:
8-
dockerNode: adguard/node-ssh:18.13--1
8+
dockerNode: adguard/node-ssh:21.7--1
99

1010
stages:
1111
- Build:
@@ -21,7 +21,7 @@ Build:
2121
docker:
2222
image: ${bamboo.dockerNode}
2323
volumes:
24-
${system.YARN_DIR}: "${bamboo.cacheYarn}"
24+
${system.YARN_DIR}: '${bamboo.cacheYarn}'
2525
tasks:
2626
- checkout:
2727
force-clean-build: true
@@ -95,7 +95,7 @@ Build:
9595
ls -la
9696
9797
echo "Size before cleanup:" && du -h | tail -n 1
98-
98+
9999
# cleanup root directory
100100
rm -rf node_modules
101101
@@ -104,7 +104,7 @@ Build:
104104
105105
# cleanup server directory
106106
rm -rf server/node_modules
107-
107+
108108
echo "Size after cleanup:" && du -h | tail -n 1
109109
# Store the .vsix file as a build artifact
110110
artifacts:

bamboo-specs/deploy.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ environments:
1010

1111
marketplace.visualstudio.com:
1212
docker:
13-
image: adguard/node-ssh:18.13--1
13+
image: adguard/node-ssh:21.7--1
1414
volumes:
15-
${system.YARN_DIR}: "${bamboo.cacheYarn}"
15+
${system.YARN_DIR}: '${bamboo.cacheYarn}'
1616
triggers: []
1717
tasks:
1818
- checkout:
@@ -56,13 +56,13 @@ marketplace.visualstudio.com:
5656
ls -la
5757
5858
echo "Size before cleanup:" && du -h | tail -n 1
59-
59+
6060
# cleanup root directory
6161
# note: no need to clean client and server directories here, because we only installed
6262
# dependencies in the root directory (for the vsce publish command above)
6363
# TODO: switch to yarn workspaces
6464
rm -rf node_modules
65-
65+
6666
echo "Size after cleanup:" && du -h | tail -n 1
6767
requirements:
6868
- adg-docker: 'true'
@@ -78,7 +78,7 @@ open-vsx.org:
7878
docker:
7979
image: adguard/node-ssh:18.13--1
8080
volumes:
81-
${system.YARN_DIR}: "${bamboo.cacheYarn}"
81+
${system.YARN_DIR}: '${bamboo.cacheYarn}'
8282
triggers: []
8383
tasks:
8484
- checkout:
@@ -122,13 +122,13 @@ open-vsx.org:
122122
ls -la
123123
124124
echo "Size before cleanup:" && du -h | tail -n 1
125-
125+
126126
# cleanup root directory
127127
# note: no need to clean client and server directories here, because we only installed
128128
# dependencies in the root directory (for the vsce publish command above)
129129
# TODO: switch to yarn workspaces
130130
rm -rf node_modules
131-
131+
132132
echo "Size after cleanup:" && du -h | tail -n 1
133133
requirements:
134134
- adg-docker: 'true'

bamboo-specs/increment.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ plan:
55
key: VSCODEADBLOCKSYNTAXINCR
66
name: vscode adblock syntax - increment
77
variables:
8-
dockerNode: adguard/node-ssh:18.13--1
8+
dockerNode: adguard/node-ssh:21.7--1
99

1010
stages:
1111
- Increment:
@@ -17,9 +17,9 @@ stages:
1717
Increment:
1818
key: INCR
1919
docker:
20-
image: "${bamboo.dockerNode}"
20+
image: '${bamboo.dockerNode}'
2121
volumes:
22-
${system.YARN_DIR}: "${bamboo.cacheYarn}"
22+
${system.YARN_DIR}: '${bamboo.cacheYarn}'
2323
other:
2424
clean-working-dir: true
2525
tasks:

bamboo-specs/test.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ plan:
55
key: VSCODEADBLOCKSYNTAXTEST
66
name: vscode adblock syntax - tests
77
variables:
8-
dockerNode: adguard/node-ssh:18.13--1
8+
dockerNode: adguard/node-ssh:21.7--1
99

1010
stages:
1111
- Build:
@@ -17,9 +17,9 @@ stages:
1717
Build:
1818
key: BUILD
1919
docker:
20-
image: "${bamboo.dockerNode}"
20+
image: '${bamboo.dockerNode}'
2121
volumes:
22-
${system.YARN_DIR}: "${bamboo.cacheYarn}"
22+
${system.YARN_DIR}: '${bamboo.cacheYarn}'
2323
tasks:
2424
- checkout:
2525
force-clean-build: true
@@ -78,7 +78,7 @@ Build:
7878
ls -la
7979
8080
echo "Size before cleanup:" && du -h | tail -n 1
81-
81+
8282
# cleanup root directory
8383
rm -rf node_modules
8484
@@ -87,7 +87,7 @@ Build:
8787
8888
# cleanup server directory
8989
rm -rf server/node_modules
90-
90+
9191
echo "Size after cleanup:" && du -h | tail -n 1
9292
requirements:
9393
- adg-docker: true

server/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"vscode-languageserver-textdocument": "^1.0.8"
1313
},
1414
"devDependencies": {
15-
"@adguard/aglint": "2.0.8",
15+
"@adguard/aglint": "2.0.9",
1616
"@types/clone-deep": "^4.0.1",
1717
"@types/semver": "^7.5.0",
1818
"clone-deep": "^4.0.1",

server/yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
# yarn lockfile v1
33

44

5-
"@adguard/aglint@2.0.8":
6-
version "2.0.8"
7-
resolved "https://registry.yarnpkg.com/@adguard/aglint/-/aglint-2.0.8.tgz#82661e1bef23025161dc74d7b3dd24218f2e04d4"
8-
integrity sha512-aRioaWDWItE3hjgvfUFvuzynQhorOk6/1aFug12Zsv1fmSZbmsx8tfP+RK/Z/oRx5QoSuHD+5y8lPYd34+qddw==
5+
"@adguard/aglint@2.0.9":
6+
version "2.0.9"
7+
resolved "https://registry.yarnpkg.com/@adguard/aglint/-/aglint-2.0.9.tgz#2082b12107dd2090102a72d64d8397a09f5e98d0"
8+
integrity sha512-1xnQdGNwk6xb9m8YyxbaMLbSTQ59tehlwv7P92O7MqIMFLoLJy70HPrx3JOTj+GRrSNQOuJFHJnl7LVvF7pyUw==
99
dependencies:
10-
"@adguard/agtree" "^1.1.7"
10+
"@adguard/agtree" "^1.1.8"
1111
"@inquirer/checkbox" "^1.3.7"
1212
"@inquirer/select" "^1.2.7"
1313
chalk "4.1.2"
@@ -24,10 +24,10 @@
2424
terminal-link "2.1.1"
2525
text-table "^0.2.0"
2626

27-
"@adguard/agtree@^1.1.7":
28-
version "1.1.7"
29-
resolved "https://registry.yarnpkg.com/@adguard/agtree/-/agtree-1.1.7.tgz#0bafee0396da704958ba6014ad83565e57c5b279"
30-
integrity sha512-xol2aSim0BYnxCk/OULE3qXFToSnadNsl4q6DDjhHkXvKTr0Y6hnfq4Ub3BGgEpyzGYYkN37BDz8IEUDdpRyew==
27+
"@adguard/agtree@^1.1.8":
28+
version "1.1.8"
29+
resolved "https://registry.yarnpkg.com/@adguard/agtree/-/agtree-1.1.8.tgz#e001389bdb08476eb3c55e56922179a14e9b5fbf"
30+
integrity sha512-5k9bYA+JSfZgYTvwahkM8ihIf1fvP+RxA1dKLgkRIGa6ixOSWNKv/pN0Rpiy0DwZJbC9X/OeZrtdW66jASH/JA==
3131
dependencies:
3232
"@adguard/ecss-tree" "^1.0.8"
3333
"@adguard/scriptlets" "^1.9.61"

0 commit comments

Comments
 (0)