#1834: fix incorrect listing of found shared/synced dataExtensions

Author: JoernBerkefeld

lib/metadataTypes/DataExtension.js

@@ -1673,10 +1673,9 @@ class DataExtension extends MetadataType {
      * Used by {@link MetadataType.getDependentFiles}.
      *
      * @param {string[]} notFound keys that were not found in the child BU retrieve folder
-     * @param {TypeKeyCombo} notFoundList accumulator of all not-found keys
      * @returns {Promise.<string[]>} keys that should still trigger the default "not found" warning
      */
-    static async handleNotFoundDependencies(notFound, notFoundList) {
+    static async handleNotFoundDependencies(notFound) {
         // on parent BU, shared DE check is not applicable
         if (this.buObject.eid === this.buObject.mid) {
             return notFound;
@@ -1708,17 +1707,13 @@ class DataExtension extends MetadataType {
                 Util.logger.warn(
                     `References to it may need to be changed during deployment via mcdev templating or manually. To update the shared dataExtension itself, run build for the parent BU and deploy it separately.`
                 );
-                notFoundList[this.definition.type] ||= [];
-                notFoundList[this.definition.type].push(key);
             } else if (contentType === 'synchronizeddataextension') {
                 Util.logger.warn(
                     `dataExtension '${key}' is a synchronized dataExtension stored in _ParentBU_. It cannot be included in the child BU deployment package.`
                 );
                 Util.logger.warn(
                     `The reference to it likely needs to be changed during deployment via mcdev templating or manually.`
                 );
-                notFoundList[this.definition.type] ||= [];
-                notFoundList[this.definition.type].push(key);
             } else {
                 // regular dataExtension found on parent BU cannot be used from a child BU; treat as not found
                 stillNotFound.push(key);

lib/metadataTypes/MetadataType.js

@@ -2785,7 +2785,7 @@ class MetadataType {
             (key) => !multiTypeKeyList[this.definition.type].includes(key)
         );
         if (notFound && notFound.length) {
-            const remainingNotFound = await this.handleNotFoundDependencies(notFound, notFoundList);
+            const remainingNotFound = await this.handleNotFoundDependencies(notFound);
             if (remainingNotFound.length) {
                 Util.logger.warn(
                     Util.getGrayMsg(
@@ -2815,10 +2815,9 @@ class MetadataType {
      * Used by {@link MetadataType.getDependentFiles}.
      *
      * @param {string[]} notFound keys that could not be found in the retrieve folder
-     * @param {TypeKeyCombo} notFoundList accumulator of all not-found keys
      * @returns {Promise.<string[]>} keys that should still trigger the default "not found" warning
      */
-    static async handleNotFoundDependencies(notFound, notFoundList) {
+    static async handleNotFoundDependencies(notFound) {
         return notFound;
     }