#841: code review fixes

Author: JoernBerkefeld

@types/lib/metadataTypes/DataFilter.d.ts.map

@@ -41,7 +41,8 @@ class FileLocation extends MetadataType {
                 null,
                 key
             );
-            this.cache.dataItems = dataItems.metadata;
+            this.cache[this.buObject.mid] ||= {};
+            this.cache[this.buObject.mid].dataItems = dataItems.metadata;
         } catch (ex) {
             if (ex.code === 'ERR_BAD_REQUEST') {
                 // if retrieve-by-key comes up empty, the data-endpoint returns a code 400
@@ -105,8 +106,8 @@ class FileLocation extends MetadataType {
             }
             Object.assign(metadata, fileTransferLocation);
         } else {
-            if (!metadata.customerKey && this.cache.dataItems) {
-                const nameMatch = Object.values(this.cache.dataItems).find(
+            if (!metadata.customerKey && this.cache[this.buObject.mid]?.dataItems) {
+                const nameMatch = Object.values(this.cache[this.buObject.mid].dataItems).find(
                     (item) => item.name === metadata.name
                 );
                 if (nameMatch) {
@@ -270,11 +271,10 @@ class FileLocation extends MetadataType {
     /**
      * Delete a metadata item from the specified business unit
      *
-     * @param {string} key Identifier of data extension
+     * @param {string} key Identifier of item
      * @returns {Promise.<boolean>} deletion success flag
      */
     static async deleteByKey(key) {
-        // delete only works with the query's object id
         return super.deleteByKeyREST(
             '/data/v1/filetransferlocation/' + encodeURIComponent(key),
             key,

@types/lib/metadataTypes/FileLocation.d.ts

@@ -12,6 +12,7 @@ export default {
     lastmodDateField: null,
     lastmodNameField: null,
     restPagination: false,
+    maxKeyLength: 36, // confirmed max length
     type: 'fileLocation',
     typeDescription:
         'Used for export or import of files to/from Marketing Cloud. Previously this was labeled ftpLocation.',