Skip to content

Commit 9d8ee7e

Browse files
Merge pull request #2569 from Accenture/bug/2568-type-filter-references-datafilter-with-wrong-name-breaking-build---dependencies
Bug/2568 type filter references datafilter with wrong name breaking build dependencies
2 parents 78b6177 + 2900768 commit 9d8ee7e

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

@types/lib/metadataTypes/Filter.d.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

@types/lib/metadataTypes/definitions/Filter.definition.d.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/metadataTypes/DataExtensionField.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ class DataExtensionField extends MetadataType {
406406
.toSorted();
407407
if (removedFieldNames.length > 0) {
408408
Util.logger.warn(
409-
` - dataExtension ${deKey}: found ${removedFieldNames.length} field${removedFieldNames.length>1?'s':''} on the server but not in the deploy payload. Fields cannot be auto-deleted due to potential data loss. To delete them, please run:`
409+
` - dataExtension ${deKey}: found ${removedFieldNames.length} field${removedFieldNames.length > 1 ? 's' : ''} on the server but not in the deploy payload. Fields cannot be auto-deleted due to potential data loss. To delete them, please run:`
410410
);
411411
Util.logger.info(
412412
Util.getGrayMsg(

lib/metadataTypes/definitions/Filter.definition.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export default {
99
'folder-hidden',
1010
],
1111
dependencyGraph: {
12-
filterDefinition: ['r__dataFilter_key'],
12+
dataFilter: ['r__dataFilter_key'],
1313
dataExtension: ['r__source_dataExtension_key', 'r__destination_dataExtension_key'],
1414
},
1515
hasExtended: false,
@@ -30,8 +30,7 @@ export default {
3030
maxKeyLength: 36, // confirmed max length
3131
type: 'filter',
3232
soapType: 'FilterActivity',
33-
typeDescription:
34-
'Used in automations to filter lists and DEs. Depends on type "FilterDefinitions".',
33+
typeDescription: 'Used in automations to filter lists and DEs. Depends on type "DataFilter".',
3534
typeRetrieveByDefault: true,
3635
typeCdpByDefault: true,
3736
typeName: 'Automation: Filter Activity',

0 commit comments

Comments
 (0)