#9: code review fixes & enhanced tests

Author: JoernBerkefeld

lib/metadataTypes/DataFilter.js

@@ -168,6 +168,7 @@ class DataFilter extends MetadataType {
         Folder.client = this.client;
         Folder.buObject = this.buObject;
         Folder.properties = this.properties;
+        this.cache[this.buObject.mid] ||= {};
         this.cache[this.buObject.mid].folderMeasure ||= {};
         this.cache[this.buObject.mid].folderMeasure = (
             await Folder.retrieveForCache(null, subTypeArr)
@@ -301,7 +302,7 @@ class DataFilter extends MetadataType {
      * @param {DataFilterMap} metadataTypeMap -
      */
     static async _cacheMeasures(metadataTypeMap) {
-        if (this.cache[this.buObject.mid].measures) {
+        if (this.cache?.[this.buObject.mid]?.measures) {
             return;
         }
         const subscriberFilters = Object.values(metadataTypeMap)

test/type.dataFilter.test.js

@@ -81,16 +81,24 @@ describe('type: dataFilter', () => {
         it('Should create & upsert a dataFilter', async () => {
             // WHEN
 
-            await handler.deploy('testInstance/testBU', ['dataFilter']);
+            const deployed = await handler.deploy('testInstance/testBU', ['dataFilter']);
             // THEN
             assert.equal(process.exitCode, 0, 'deploy should not have thrown an error');
             // get results from cache
             const result = cache.getCache();
             assert.equal(
                 result.dataFilter ? Object.keys(result.dataFilter).length : 0,
                 2,
-                'unexptected number of dataFilters in cache'
+                'unexpected number of dataFilters in cache'
             );
+            assert.equal(
+                deployed?.['testInstance/testBU']?.dataFilter
+                    ? Object.keys(deployed['testInstance/testBU'].dataFilter).length
+                    : 0,
+                2,
+                'unexpected number of dataFilters deployed'
+            );
+
             // confirm created item
             assert.deepEqual(
                 await testUtils.getActualJson('testNew_dataFilter', 'dataFilter'),

test/type.filter.test.js

@@ -77,15 +77,22 @@ describe('type: filter', () => {
         it('Should create & upsert a filter', async () => {
             // WHEN
 
-            await handler.deploy('testInstance/testBU', ['filter']);
+            const deployed = await handler.deploy('testInstance/testBU', ['filter']);
             // THEN
             assert.equal(process.exitCode, 0, 'deploy should not have thrown an error');
             // get results from cache
             const result = cache.getCache();
             assert.equal(
                 result.filter ? Object.keys(result.filter).length : 0,
                 2,
-                'unexptected number of filters in cache'
+                'unexpected number of filters in cache'
+            );
+            assert.equal(
+                deployed?.['testInstance/testBU']?.filter
+                    ? Object.keys(deployed['testInstance/testBU'].filter).length
+                    : 0,
+                2,
+                'unexpected number of filters deployed'
             );
             // confirm created item
             assert.deepEqual(