Code cleanup

Author: ATrefzer

ApprovalTestTool/Hash.cs

@@ -3,7 +3,6 @@
 
 namespace ApprovalTestTool;
 
-/// <summary>
 public static class Hash
 {
     public static string ComputeHash(string input)

CSharpCodeAnalyst/App.xaml.cs

@@ -110,7 +110,7 @@ private void StartUi()
         mainWindow.SetViewer(explorationGraphViewer, messaging);
 
         var projectStorage = new JsonProjectStorage(uiNotification);
-        var projectService = new ProjectService(projectStorage, uiNotification, userSettings);
+        var projectService = new ProjectService(projectStorage, userSettings);
 
         var viewModel = new MainViewModel(messaging, applicationSettings, userSettings, analyzerManager, refactoringService, projectService);
         var graphViewModel = new GraphViewModel(explorationGraphViewer, explorer, messaging, applicationSettings, refactoringService);

CSharpCodeAnalyst/Features/AdvancedSearch/AdvancedSearchControl.xaml

@@ -5,8 +5,9 @@
              xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
              xmlns:resources="clr-namespace:CSharpCodeAnalyst.Resources"
              xmlns:dd="urn:gong-wpf-dragdrop"
+             xmlns:advancedSearch="clr-namespace:CSharpCodeAnalyst.Features.AdvancedSearch"
              mc:Ignorable="d"
-             d:DataContext="{d:DesignInstance local:AdvancedSearchViewModel}"
+             d:DataContext="{d:DesignInstance advancedSearch:AdvancedSearchViewModel}"
              d:DesignHeight="300" d:DesignWidth="300">
     <UserControl.Resources>
         <ResourceDictionary>

CSharpCodeAnalyst/Features/AdvancedSearch/SearchItemViewModel.cs

@@ -9,21 +9,19 @@ namespace CSharpCodeAnalyst.Features.AdvancedSearch;
 [DebuggerDisplay("{Type} {Name} - {FullPath}")]
 public sealed class SearchItemViewModel : INotifyPropertyChanged
 {
-    private bool _isSelected;
-
     public string Name { get; set; } = string.Empty;
     public string Type { get; set; } = string.Empty;
     public string FullPath { get; set; } = string.Empty;
     public CodeElement? CodeElement { get; set; }
 
     public bool IsSelected
     {
-        get => _isSelected;
+        get;
         set
         {
-            if (_isSelected != value)
+            if (field != value)
             {
-                _isSelected = value;
+                field = value;
                 OnPropertyChanged(nameof(IsSelected));
             }
         }

CSharpCodeAnalyst/Features/Analyzers/AnalyzerManager.cs

@@ -63,11 +63,11 @@ public void LoadAnalyzers(IPublisher messaging, IUserNotification userNotificati
         _analyzers.Clear();
 
         IAnalyzer analyzer = new Analyzer(messaging);
-        analyzer.DataChanged += (sender, args) => RaiseAnalyzerDataChanged();
+        analyzer.DataChanged += (_, _) => RaiseAnalyzerDataChanged();
         _analyzers.Add(analyzer.Id, analyzer);
 
         analyzer = new ArchitecturalRules.Analyzer(messaging, userNotification);
-        analyzer.DataChanged += (sender, args) => RaiseAnalyzerDataChanged();
+        analyzer.DataChanged += (_, _) => RaiseAnalyzerDataChanged();
         _analyzers.Add(analyzer.Id, analyzer);
     }
 

CSharpCodeAnalyst/Features/Analyzers/ArchitecturalRules/Analyzer.cs

@@ -60,7 +60,7 @@ public void Analyze(CodeGraph.Graph.CodeGraph graph)
         _openDialog.OnValidateRequested = OnValidateRules;
 
         // Handle dialog closing
-        _openDialog.Closed += (sender, args) =>
+        _openDialog.Closed += (_, _) =>
         {
             _openDialog = null;
             _currentGraph = null;

CSharpCodeAnalyst/Features/Analyzers/ArchitecturalRules/Presentation/ArchitecturalRulesDialog.xaml.cs

@@ -8,7 +8,6 @@ namespace CSharpCodeAnalyst.Features.Analyzers.ArchitecturalRules.Presentation;
 
 public partial class ArchitecturalRulesDialog : INotifyPropertyChanged
 {
-    private string _rulesText = string.Empty;
 
     public ArchitecturalRulesDialog()
     {
@@ -18,15 +17,15 @@ public ArchitecturalRulesDialog()
 
     public string RulesText
     {
-        get => _rulesText;
+        get;
         set
         {
-            if (_rulesText == value) { return; }
+            if (field == value) { return; }
 
-            _rulesText = value;
+            field = value;
             OnPropertyChanged();
         }
-    }
+    } = string.Empty;
 
     /// <summary>
     /// Callback invoked when the Validate button is clicked

CSharpCodeAnalyst/Features/Analyzers/ArchitecturalRules/Presentation/RuleViolationsViewModel.cs

@@ -57,7 +57,7 @@ public override ObservableCollection<TableRow> GetData()
         return _violations;
     }
 
-    public override DataTemplate? GetRowDetailsTemplate()
+    public override DataTemplate GetRowDetailsTemplate()
     {
         var uri = new Uri(
             "/CSharpCodeAnalyst;component/Features/Analyzers/ArchitecturalRules/Presentation/RelationshipViewModelTemplate.xaml",

CSharpCodeAnalyst/Features/Analyzers/ArchitecturalRules/Rules/IsolateRule.cs

@@ -17,7 +17,7 @@ public override List<Relationship> ValidateRule(
 
         foreach (var relationship in allRelationships)
         {
-            // ISOLATE violation: source uses anything outside of itself
+            // ISOLATE violation: source uses anything outside itself
             if (sourceIds.Contains(relationship.SourceId) && !sourceIds.Contains(relationship.TargetId))
             {
                 violations.Add(relationship);

CSharpCodeAnalyst/Features/Analyzers/EventRegistration/Presentation/EventImbalancesViewModel.cs

@@ -34,7 +34,7 @@ public override ObservableCollection<TableRow> GetData()
         return _imbalances;
     }
 
-    public override DataTemplate? GetRowDetailsTemplate()
+    public override DataTemplate GetRowDetailsTemplate()
     {
         var uri = new Uri(
             "/CSharpCodeAnalyst;component/Features/Analyzers/EventRegistration/Presentation/SourceLocationTemplate.xaml",