Skip to content

Commit 67499cb

Browse files
committed
Fix AAC-LC Specific Config in test vectors to obey ISO+IEC-14496-1:2010 spec.
- Resolves both parts A and B in #119 for the test vectors. - Part A: Add missing "expandable" size field to both of the `DecoderConfigDescriptor` and `DecoderSpecificInfo`. - Part B: Flip `DecoderConfigDescriptor` `reserved` bit to 1. - Based on AOMediaCodec/iamf-tools@57324193.
1 parent b5f358a commit 67499cb

19 files changed

Lines changed: 1 addition & 1 deletion

proto/codec_config.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ message AacDecoderConfig {
9999
optional uint32 object_type_indication = 1 [default = 0x40];
100100
optional uint32 stream_type = 2 [default = 5];
101101
optional bool upstream = 3 [default = false];
102-
optional bool reserved = 4;
102+
optional bool reserved = 4 [default = true]; // As per ISO 14496-1:2010.
103103
optional uint32 buffer_size_db = 5;
104104
optional uint32 max_bitrate = 6;
105105
optional uint32 average_bit_rate = 7;

tests/test_000076.iamf

2 Bytes
Binary file not shown.

tests/test_000076_f.mp4

2 Bytes
Binary file not shown.

tests/test_000076_s.mp4

2 Bytes
Binary file not shown.

tests/test_000090.iamf

2 Bytes
Binary file not shown.

tests/test_000090_f.mp4

2 Bytes
Binary file not shown.

tests/test_000090_s.mp4

2 Bytes
Binary file not shown.

tests/test_000091.iamf

2 Bytes
Binary file not shown.

tests/test_000091_f.mp4

2 Bytes
Binary file not shown.

tests/test_000091_s.mp4

2 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)