Split out is_valid_to_decode from is_valid.

  - `is_valid_to_decode`: Implies at least one mix in the test vector can be decoded.
    - A compliant decoder should be able to find and decode a valid mix.
  - `is_valid`: Implies all mixes in the the test vector could be decoded.
    - The encoder will more strictly prevent encoding certain types of reserved fields which is not aware of.
    - This maintains the safety rails on the encoder which prevent it from using certain types of extension fields under normal circumstances.
    - May be used to prevent other types of reserved fields in the future.
    - May rename to `is_valid_to_encode` in the future.
  - `test_summary.csv`: Add a column for `is_valid_to_decode`.
  - The concepts are identical for test vectors with only one mix presentation (most of the test suite).
    - Hence, most existing test vectors have matching `is_valid` and `is_valid_to_decode`.
  - The concepts are distinguished when there is one valid mix and one invalid mix (i.e. `test_000120`, `test_000122`, `test_000129`, `test_000130`).
    - Typically we want safety rails and do not want to accidentally encode strange mixes that will never be decoded.

Author: jwcullen

proto/test_vector_metadata.proto

@@ -32,7 +32,15 @@ message TestVectorMetadata {
   // Prefix of the output file names. Leave empty to skip writing to output
   // files.
   optional string file_name_prefix = 2;
+
+  // TODO(b/269708630): Rename `is_valid` to `is_valid_to_encode`.
+  // `true` when all mixes are valid to encode. Mixes may be invalid if they
+  // contain any mixes that use certain reserved values, or if they exercise any
+  // features which are not supported by the encoder.
   optional bool is_valid = 3;
+  // `true` when a compliant decoder would decode at least one valid mix. Some
+  // other mixes may be invalid or use reserved values which may be ignored.
+  optional bool is_valid_to_decode = 14 [default = true];
   optional string mp4_fixed_timestamp = 4;
   reserved 5;
   repeated string primary_tested_spec_sections = 6;

tests/README.md

@@ -18,6 +18,7 @@ test_vector_metadata {
     "not have sufficient `num_samples_to_trim_at_end`."
   file_name_prefix: "test_000000_3"
   is_valid: false
+  is_valid_to_decode: false
   validate_user_loudness: true
   mp4_fixed_timestamp: "2023-04-06 00:00:00"
   primary_tested_spec_sections: [

tests/test_000000_3.textproto

@@ -17,6 +17,7 @@ test_vector_metadata {
     "added."
   file_name_prefix: "test_000002"
   is_valid: true
+  is_valid_to_decode: true
   validate_user_loudness: true
   mp4_fixed_timestamp: "2023-04-19 00:00:00"
   primary_tested_spec_sections: [

tests/test_000002.textproto

@@ -17,6 +17,7 @@ test_vector_metadata {
     "parameter blocks."
   file_name_prefix: "test_000003"
   is_valid: true
+  is_valid_to_decode: true
   validate_user_loudness: true
   mp4_fixed_timestamp: "2023-04-19 00:00:00"
   primary_tested_spec_sections: [

tests/test_000003.textproto

@@ -17,6 +17,7 @@ test_vector_metadata {
     "trimming."
   file_name_prefix: "test_000005"
   is_valid: true
+  is_valid_to_decode: true
   validate_user_loudness: true
   mp4_fixed_timestamp: "2023-04-19 00:00:00"
   primary_tested_spec_sections: ["3.2/num_samples_to_trim_at_end"]

tests/test_000005.textproto

@@ -17,6 +17,7 @@ test_vector_metadata {
     "delimiters."
   file_name_prefix: "test_000006"
   is_valid: true
+  is_valid_to_decode: true
   validate_user_loudness: true
   mp4_fixed_timestamp: "2023-04-19 00:00:00"
   primary_tested_spec_sections: [

tests/test_000006.textproto

@@ -17,6 +17,7 @@ test_vector_metadata {
     "case-sensitive and should be lowercase."
   file_name_prefix: "test_000007"
   is_valid: false
+  is_valid_to_decode: false
   validate_user_loudness: true
   mp4_fixed_timestamp: "2023-04-19 00:00:00"
   primary_tested_spec_sections: ["3.4/ia_code"]

tests/test_000007.textproto

@@ -17,6 +17,7 @@ test_vector_metadata {
     "input wav file to make it shorter."
   file_name_prefix: "test_000012"
   is_valid: true
+  is_valid_to_decode: true
   validate_user_loudness: true
   mp4_fixed_timestamp: "2023-04-19 00:00:00"
   primary_tested_spec_sections: ["3.2/num_samples_to_trim_at_end"]

tests/test_000012.textproto

@@ -17,6 +17,7 @@ test_vector_metadata {
     "input wav file to make it shorter."
   file_name_prefix: "test_000013"
   is_valid: true
+  is_valid_to_decode: true
   validate_user_loudness: true
   mp4_fixed_timestamp: "2023-04-19 00:00:00"
   primary_tested_spec_sections: ["3.2/num_samples_to_trim_at_end"]