Fix non-string input issue

Fix the bug for issue #108

Author: Jacobluke-

dabest/plot_tools.py

@@ -173,16 +173,23 @@ def error_bar(
 
     kwargs["zorder"] = kwargs["zorder"]
 
-    for xpos, central_measure in enumerate(central_measures):
+    for xpos, val in enumerate(central_measures.index):
+        central_measure = central_measures[val]
         kwargs["color"] = custom_palette[xpos]
 
         if method == "sankey_error_bar":
             _xpos = pos[xpos] + offset[xpos]
         else:
             _xpos = xpos + offset[xpos]
 
-        low = lows[xpos]
-        high = highs[xpos]
+        # Fix for the non-string x-axis issue #108
+        if central_measures.index.dtype.name == "category":
+            low = lows[xpos]
+            high = highs[xpos]
+        else: 
+            low = lows[val]
+            high = highs[val]
+
         if low == high == central_measure:
             low_to_mean = mlines.Line2D(
                 [_xpos, _xpos], [low, central_measure], **kwargs

dabest/plotter.py

@@ -807,15 +807,31 @@ def effectsize_df_plotter(effectsize_df, **plot_kwargs):
     rawdata_axes.xaxis.set_major_locator(matplotlib.ticker.FixedLocator(ticks_loc))
     for xticklab in rawdata_axes.xaxis.get_ticklabels():
         t = xticklab.get_text()
-        if t.rfind("\n") != -1:
-            te = t[t.rfind("\n") + len("\n") :]
-            N = str(counts.loc[te])
-            te = t
-        else:
-            te = t
+        # Extract the text after the last newline, if present
+        te = t[t.rfind("\n") + len("\n"):] if t.rfind("\n") != -1 else t
+
+        try:
+            # Try to access 'counts' directly with 'te'.
             N = str(counts.loc[te])
+        except KeyError:
+            # If direct access fails, attempt a numeric interpretation.
+            try:
+                # Attempt to convert 'te' to numeric (float or int, as appropriate)
+                numeric_key = pd.to_numeric(te, errors='coerce')
+                # 'pd.to_numeric()' will convert strings to float or int, as appropriate,
+                # and will return NaN if conversion fails. It preserves integers.
+                if pd.notnull(numeric_key):  # Check if conversion was successful
+                    N = str(counts.loc[numeric_key])
+                else:
+                    raise ValueError  # Raise an error to trigger the except block
+            except (ValueError, KeyError):
+                # Handle cases where 'te' cannot be converted or the converted key doesn't exist
+                print(f"Key '{te}' not found in counts.")
+                N = "N/A"
+
+        # Append the modified tick label with the count to the list
+        ticks_with_counts.append(f"{te}\nN = {N}")
 
-        ticks_with_counts.append("{}\nN = {}".format(te, N))
 
     if plot_kwargs["fontsize_rawxlabel"] is not None:
         fontsize_rawxlabel = plot_kwargs["fontsize_rawxlabel"]

nbs/API/plot_tools.ipynb

@@ -228,16 +228,23 @@
     "\n",
     "    kwargs[\"zorder\"] = kwargs[\"zorder\"]\n",
     "\n",
-    "    for xpos, central_measure in enumerate(central_measures):\n",
+    "    for xpos, val in enumerate(central_measures.index):\n",
+    "        central_measure = central_measures[val]\n",
     "        kwargs[\"color\"] = custom_palette[xpos]\n",
     "\n",
     "        if method == \"sankey_error_bar\":\n",
     "            _xpos = pos[xpos] + offset[xpos]\n",
     "        else:\n",
     "            _xpos = xpos + offset[xpos]\n",
     "\n",
-    "        low = lows[xpos]\n",
-    "        high = highs[xpos]\n",
+    "        # Fix for the non-string x-axis issue #108\n",
+    "        if central_measures.index.dtype.name == \"category\":\n",
+    "            low = lows[xpos]\n",
+    "            high = highs[xpos]\n",
+    "        else: \n",
+    "            low = lows[val]\n",
+    "            high = highs[val]\n",
+    "\n",
     "        if low == high == central_measure:\n",
     "            low_to_mean = mlines.Line2D(\n",
     "                [_xpos, _xpos], [low, central_measure], **kwargs\n",

nbs/API/plotter.ipynb

@@ -866,15 +866,31 @@
     "    rawdata_axes.xaxis.set_major_locator(matplotlib.ticker.FixedLocator(ticks_loc))\n",
     "    for xticklab in rawdata_axes.xaxis.get_ticklabels():\n",
     "        t = xticklab.get_text()\n",
-    "        if t.rfind(\"\\n\") != -1:\n",
-    "            te = t[t.rfind(\"\\n\") + len(\"\\n\") :]\n",
-    "            N = str(counts.loc[te])\n",
-    "            te = t\n",
-    "        else:\n",
-    "            te = t\n",
+    "        # Extract the text after the last newline, if present\n",
+    "        te = t[t.rfind(\"\\n\") + len(\"\\n\"):] if t.rfind(\"\\n\") != -1 else t\n",
+    "\n",
+    "        try:\n",
+    "            # Try to access 'counts' directly with 'te'.\n",
     "            N = str(counts.loc[te])\n",
+    "        except KeyError:\n",
+    "            # If direct access fails, attempt a numeric interpretation.\n",
+    "            try:\n",
+    "                # Attempt to convert 'te' to numeric (float or int, as appropriate)\n",
+    "                numeric_key = pd.to_numeric(te, errors='coerce')\n",
+    "                # 'pd.to_numeric()' will convert strings to float or int, as appropriate,\n",
+    "                # and will return NaN if conversion fails. It preserves integers.\n",
+    "                if pd.notnull(numeric_key):  # Check if conversion was successful\n",
+    "                    N = str(counts.loc[numeric_key])\n",
+    "                else:\n",
+    "                    raise ValueError  # Raise an error to trigger the except block\n",
+    "            except (ValueError, KeyError):\n",
+    "                # Handle cases where 'te' cannot be converted or the converted key doesn't exist\n",
+    "                print(f\"Key '{te}' not found in counts.\")\n",
+    "                N = \"N/A\"\n",
+    "\n",
+    "        # Append the modified tick label with the count to the list\n",
+    "        ticks_with_counts.append(f\"{te}\\nN = {N}\")\n",
     "\n",
-    "        ticks_with_counts.append(\"{}\\nN = {}\".format(te, N))\n",
     "\n",
     "    if plot_kwargs[\"fontsize_rawxlabel\"] is not None:\n",
     "        fontsize_rawxlabel = plot_kwargs[\"fontsize_rawxlabel\"]\n",