Fixed bug involving labels not being compared for image comparisons by lowering tolerance to 8

Author: sunroofgod

nbs/tests/mpl_image_tests/test_03_plotting.py

@@ -132,62 +132,62 @@ def create_demo_dataset(seed=9999, N=20):
 )
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_01_gardner_altman_unpaired_meandiff():
     return two_groups_unpaired.mean_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_02_gardner_altman_unpaired_mediandiff():
     return two_groups_unpaired.median_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_03_gardner_altman_unpaired_hedges_g():
     return two_groups_unpaired.hedges_g.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_04_gardner_altman_paired_meandiff():
     return two_groups_paired.mean_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_04_gardner_altman_paired_hedges_g():
     return two_groups_paired.hedges_g.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_05_cummings_two_group_unpaired_meandiff():
     return two_groups_unpaired.mean_diff.plot(fig_size=(4, 6), float_contrast=False)
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_06_cummings_two_group_paired_meandiff():
     return two_groups_paired.mean_diff.plot(fig_size=(6, 6), float_contrast=False)
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_07_cummings_multi_group_unpaired():
     return multi_2group.mean_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_08_cummings_multi_group_paired():
     return multi_2group_paired.mean_diff.plot(fig_size=(6, 6))
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_09_cummings_shared_control():
     return shared_control.mean_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_10_cummings_multi_groups():
     return multi_groups.mean_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_11_inset_plots():
     # Load the iris dataset.
     try:
@@ -242,31 +242,31 @@ def test_11_inset_plots():
     return fig
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_12_gardner_altman_ylabel():
     return two_groups_unpaired.mean_diff.plot(
         swarm_label="This is my\nrawdata", contrast_label="The bootstrap\ndistribtions!"
     )
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_13_multi_2group_color():
     return multi_2group.mean_diff.plot(color_col="Gender")
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_14_gardner_altman_paired_color():
     return two_groups_paired.mean_diff.plot(fig_size=(6, 6), color_col="Gender")
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_15_change_palette_a():
     return multi_2group.mean_diff.plot(
         fig_size=(8, 6), color_col="Gender", custom_palette="Dark2"
     )
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_16_change_palette_b():
     return multi_2group.mean_diff.plot(custom_palette="Paired")
 
@@ -279,36 +279,36 @@ def test_16_change_palette_b():
 }
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_17_change_palette_c():
     return multi_2group.mean_diff.plot(custom_palette=my_color_palette)
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_18_desat():
     return multi_2group.mean_diff.plot(
         custom_palette=my_color_palette, swarm_desat=0.75, halfviolin_desat=0.25
     )
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_19_dot_sizes():
     return multi_2group.mean_diff.plot(raw_marker_size=3, es_marker_size=12)
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_20_change_ylims():
     return multi_2group.mean_diff.plot(swarm_ylim=(0, 5), contrast_ylim=(-2, 2))
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_21_invert_ylim():
     return multi_2group.mean_diff.plot(
         contrast_ylim=(2, -2), contrast_label="More negative is better!"
     )
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_22_ticker_gardner_altman():
     f = two_groups_unpaired.mean_diff.plot()
 
@@ -324,7 +324,7 @@ def test_22_ticker_gardner_altman():
     return f
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_23_ticker_cumming():
     f = multi_2group.mean_diff.plot(swarm_ylim=(0, 6), contrast_ylim=(-3, 1))
 
@@ -358,14 +358,14 @@ def test_23_ticker_cumming():
 long_df["dummy"] = np.repeat(np.nan, len(long_df))
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_24_wide_df_nan():
     wide_df_dabest = load(wide_df, idx=("Control", "Test 1", "Test 2", "Test 3"))
 
     return wide_df_dabest.mean_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_25_long_df_nan():
     long_df_dabest = load(
         long_df, x="group", y="value", idx=("Control", "Test 1", "Test 2", "Test 3")
@@ -374,17 +374,17 @@ def test_25_long_df_nan():
     return long_df_dabest.mean_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_26_slopegraph_kwargs():
     return two_groups_paired.mean_diff.plot(slopegraph_kwargs=dict(linestyle="dotted"))
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_27_gardner_altman_reflines_kwargs():
     return two_groups_unpaired.mean_diff.plot(reflines_kwargs=dict(linestyle="dotted"))
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_28_unpaired_cumming_reflines_kwargs():
     return two_groups_unpaired.mean_diff.plot(
         fig_size=(12, 10),
@@ -394,7 +394,7 @@ def test_28_unpaired_cumming_reflines_kwargs():
     )
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_29_paired_cumming_slopegraph_reflines_kwargs():
     return two_groups_paired.mean_diff.plot(
         float_contrast=False,
@@ -405,17 +405,17 @@ def test_29_paired_cumming_slopegraph_reflines_kwargs():
     )
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_30_sequential_cumming_slopegraph():
     return multi_groups_sequential.mean_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_31_baseline_cumming_slopegraph():
     return multi_groups_baseline.mean_diff.plot()
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_99_style_sheets():
     # Perform this test last so we don't have to reset the plot style.
     plt.style.use("dark_background")

nbs/tests/mpl_image_tests/test_07_delta-delta_plots.py

@@ -82,86 +82,86 @@ def create_demo_dataset_delta(seed=9999, N=20):
                 paired="sequential", id_col="ID")
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_47_cummings_unpaired_delta_delta_meandiff():
     return unpaired.mean_diff.plot();
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_48_cummings_sequential_delta_delta_meandiff():
     return sequential.mean_diff.plot();
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_49_cummings_baseline_delta_delta_meandiff():
     return baseline.mean_diff.plot();
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_50_delta_plot_ylabel():
     return baseline.mean_diff.plot(swarm_label="This is my\nrawdata",
                                    contrast_label="The bootstrap\ndistribtions!", 
                                    delta2_label="This is delta!");
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_51_delta_plot_change_palette_a():
     return sequential.mean_diff.plot(custom_palette="Dark2");
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_52_delta_specified():
     return unpaired_specified.mean_diff.plot();
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_53_delta_change_ylims():
     return sequential.mean_diff.plot(swarm_ylim=(0, 9),
                                        contrast_ylim=(-2, 2),
                                        fig_size=(15,6));
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_54_delta_invert_ylim():
     return sequential.mean_diff.plot(contrast_ylim=(2, -2),
                                        contrast_label="More negative is better!");
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_55_delta_median_diff():
     return sequential.median_diff.plot();
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_56_delta_cohens_d():
     return unpaired.cohens_d.plot();
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_57_delta_show_delta2():
     return unpaired.mean_diff.plot(show_delta2=False);
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_58_delta_axes_invert_ylim():
     return unpaired.mean_diff.plot(delta2_ylim=(2, -2),
                                    delta2_label="More negative is better!");
 
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_59_delta_axes_invert_ylim_not_showing_delta2():
     return unpaired.mean_diff.plot(delta2_ylim=(2, -2),
                                    delta2_label="More negative is better!",
                                    show_delta2=False);
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_71_unpaired_delta_g():
     return unpaired.delta_g.plot();
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_72_sequential_delta_g():
     return sequential.mean_diff.plot();
 
-@pytest.mark.mpl_image_compare(tolerance=10)
+@pytest.mark.mpl_image_compare(tolerance=8)
 def test_73_baseline_delta_g():
     return baseline.mean_diff.plot();