Fix bug for non-string cols and deprecation in sns

Fix the bug #108 where non-string column names are supplied in DABEST usages by coordinating with the deprecation of providing only ‘palette’ with no ‘hue’

Author: Jacobluke-

dabest/plotter.py

@@ -604,17 +604,31 @@ def effectsize_df_plotter(effectsize_df, **plot_kwargs):
     else:
         if not proportional:
             # Plot the raw data as a swarmplot.
-            rawdata_plot = sns.swarmplot(
-                data=plot_data,
-                x=xvar,
-                y=yvar,
-                ax=rawdata_axes,
-                order=all_plot_groups,
-                hue=color_col,
-                palette=plot_palette_raw,
-                zorder=1,
-                **swarmplot_kwargs
-            )
+            if color_col is None: # Determine the use of hue
+                rawdata_plot = sns.swarmplot(
+                    data=plot_data,
+                    x=xvar,
+                    y=yvar,
+                    ax=rawdata_axes,
+                    order=all_plot_groups,
+                    hue=xvar,
+                    palette=plot_palette_raw,
+                    zorder=1,
+                    **swarmplot_kwargs
+                )
+                rawdata_plot.legend().set_visible(False)
+            else:
+                rawdata_plot = sns.swarmplot(
+                    data=plot_data,
+                    x=xvar,
+                    y=yvar,
+                    ax=rawdata_axes,
+                    order=all_plot_groups,
+                    hue=color_col,
+                    palette=plot_palette_raw,
+                    zorder=1,
+                    **swarmplot_kwargs
+                )
         else:
             # Plot the raw data as a barplot.
             bar1_df = pd.DataFrame(
@@ -672,6 +686,10 @@ def effectsize_df_plotter(effectsize_df, **plot_kwargs):
                 if bootstraps_color_by_group:
                     line_colors.append(plot_palette_raw[all_plot_groups[jj]])
 
+                # Break the loop since hue in Seaborn adds collections to axes and it will result in index out of range
+                if jj >= n_groups - 1 and color_col is None:
+                    break
+
             if len(line_colors) != len(all_plot_groups):
                 line_colors = ytick_color
 
@@ -1534,3 +1552,4 @@ def effectsize_df_plotter(effectsize_df, **plot_kwargs):
 
     # Return the figure.
     return fig
+

nbs/API/plotter.ipynb

@@ -663,17 +663,31 @@
     "    else:\n",
     "        if not proportional:\n",
     "            # Plot the raw data as a swarmplot.\n",
-    "            rawdata_plot = sns.swarmplot(\n",
-    "                data=plot_data,\n",
-    "                x=xvar,\n",
-    "                y=yvar,\n",
-    "                ax=rawdata_axes,\n",
-    "                order=all_plot_groups,\n",
-    "                hue=color_col,\n",
-    "                palette=plot_palette_raw,\n",
-    "                zorder=1,\n",
-    "                **swarmplot_kwargs\n",
-    "            )\n",
+    "            if color_col is None: # Determine the use of hue\n",
+    "                rawdata_plot = sns.swarmplot(\n",
+    "                    data=plot_data,\n",
+    "                    x=xvar,\n",
+    "                    y=yvar,\n",
+    "                    ax=rawdata_axes,\n",
+    "                    order=all_plot_groups,\n",
+    "                    hue=xvar,\n",
+    "                    palette=plot_palette_raw,\n",
+    "                    zorder=1,\n",
+    "                    **swarmplot_kwargs\n",
+    "                )\n",
+    "                rawdata_plot.legend().set_visible(False)\n",
+    "            else:\n",
+    "                rawdata_plot = sns.swarmplot(\n",
+    "                    data=plot_data,\n",
+    "                    x=xvar,\n",
+    "                    y=yvar,\n",
+    "                    ax=rawdata_axes,\n",
+    "                    order=all_plot_groups,\n",
+    "                    hue=color_col,\n",
+    "                    palette=plot_palette_raw,\n",
+    "                    zorder=1,\n",
+    "                    **swarmplot_kwargs\n",
+    "                )\n",
     "        else:\n",
     "            # Plot the raw data as a barplot.\n",
     "            bar1_df = pd.DataFrame(\n",
@@ -731,6 +745,10 @@
     "                if bootstraps_color_by_group:\n",
     "                    line_colors.append(plot_palette_raw[all_plot_groups[jj]])\n",
     "\n",
+    "                # Break the loop since hue in Seaborn adds collections to axes and it will result in index out of range\n",
+    "                if jj >= n_groups - 1 and color_col is None:\n",
+    "                    break\n",
+    "\n",
     "            if len(line_colors) != len(all_plot_groups):\n",
     "                line_colors = ytick_color\n",
     "\n",
@@ -1592,7 +1610,7 @@
     "        plt.rcParams[parameter] = original_rcParams[parameter]\n",
     "\n",
     "    # Return the figure.\n",
-    "    return fig"
+    "    return fig\n"
    ]
   },
   {